Question

我正在尝试为测试控制器编写测试用例，这里是控制器的代码

@Controller
@RequestMapping("/")
@SessionAttributes({"roles", "departments"})
public class AppController {

    @Autowired
    UserService userService;

    @Autowired
    RoleService roleService;

    @Autowired
    DepartmentService departmentService;

    @Autowired
    MessageSource messageSource;

    @Autowired
    PersistentTokenBasedRememberMeServices persistentTokenBasedRememberMeServices;

    @Autowired
    AuthenticationTrustResolver authenticationTrustResolver;

    static final Logger logger = LoggerFactory.getLogger(AppController.class);

    /**
     * This method will list all existing users.
     */
    @RequestMapping(value = { "/", "/list" }, method = RequestMethod.GET)
    public String listUsers(ModelMap model) {

        List<User> users = userService.findAllUsers();
        model.addAttribute("users", users);
        model.addAttribute("loggedinuser", getPrincipal());
        return "userslist";
    }
    /**
     * This method returns the principal[user-name] of logged-in user.
     */
    private String getPrincipal(){
        String userName = null;
        Object principal = getCurrentUser();

        if (principal instanceof UserDetails) {
            userName = ((UserDetails)principal).getUsername();
        } else {
            userName = principal.toString();
        }
        return userName;
    }

    private Object getCurrentUser(){
        return SecurityContextHolder.getContext().getAuthentication().getPrincipal();
    }
//The rest part of the controller}

我使用基于本教程的TestNG：http://websystique.com/springmvc/spring-4-mvc-and-hibernate4-integration-testing-example-using-annotations/，目前我的测试用例中有以下内容：

//all the import file
public class AppControllerTest {

    @Mock
    UserService userService;

    @Mock
    MessageSource message;

    @InjectMocks
    AppController appController;

    @Spy
    List<User> users = new ArrayList<User>();

    @Spy
    ModelMap model;

    @Mock
    BindingResult result;

    @BeforeClass
    public void setUp(){
        MockitoAnnotations.initMocks(this);
        users = getUsers();
    }

    private List<User> getUsers() {
        // TODO Auto-generated method stub
        User u1 = new User();
        u1.setId(1);
        u1.setFirstName("Admin");
        u1.setLastName("Admin");
        u1.setUsername("admin");
        u1.setEmail("admin@akb.co.jp");
        u1.setDateOfBirth(new LocalDate());
        u1.setPassword("admin");
        Department admin = new Department();
        admin.setId(1);
        admin.setName("Admin");
        admin.setDescription("Admin");
        u1.setDepartment(admin);
        Role adminRole = new Role();
        adminRole.setId(1);
        adminRole.setRoleName("ADMIN");
        Set<Role> roles = new HashSet<>();
        roles.add(adminRole);
        u1.setRoles(roles);

        User u2 = new User();
        u2.setId(1);
        u2.setFirstName("Alice");
        u2.setLastName("Lin");
        u2.setUsername("alice.lin");
        u2.setEmail("alice.lin@akb.co.jp");
        u2.setDateOfBirth(new LocalDate());
        u2.setPassword("Alice0102");
        u2.setDepartment(admin);
        u2.setRoles(roles);

        users.add(u1);
        users.add(u2);
        return users;
    }

    @Test
    public void listUsers(){
        when(userService.findAllUsers()).thenReturn(users);
        Assert.assertEquals(appController.listUsers(model), "userslist");
        Assert.assertEquals(model.get("users"), users);
        verify(userService, atLeastOnce()).findAllUsers();
    }
}

现在问题是，如果我没有评论这一行model.addAttribute("loggedinuser", getPrincipal()); 在我的控制器类中，当我运行maven测试时，它会抛出空指针异常，这很明显，因为在我的测试用例中我没有登录到应用程序。我能做什么才能让测试通过包括这一行？

Answer 1

您应该重构代码，以便getCurrentUser（）调用在单独的类中。你应该保持这些分开，因为很可能其他控制器需要进行相同的调用。但是对于这种情况，你需要重构，因为你不能模拟私有方法调用（至少不使用Mockito）。

一旦用户相关的调用在一个单独的类中，您可以像使用@Mock注释一样完成上面的其他服务来模拟它。

具有弹簧安全性的Spring MVC测试控制器

1 个答案: