Question

I'm developing an application that reads a message input from telegram with a set of variables, and then starts a game with the user. So I created a class that represents an instance of the game, making one game per chat possible:

class Battle:
    def __init__(self, mainchat):
        self.mainchat = mainchat
        print('Instance of battle started on chat %s' % self.mainchat)
    pcount = 0
    team1 = []
    team2 = []
    p1 = ()
    p2 = ()
    p1score = 0
    p2score = 0
    battlechoicep1 = -1
    battlechoicep2 = -1

so, as soon as I get a message, I start an instance of a battle based on user inputes, e.g.

battle = Battle(chat_id)
battle.p1 = 'Paul'
battle.battlechoicep1 = 4
...

this way has been working fine right now, but every time I want to reset the battle, I go through a function that does this:

    battle.pcount = 0
    battle.team1 = []
    battle.team2 = []
    battle.p1 = ()
    battle.p2 = ()
    battle.p1score = 0
    battle.p2score = 0
    battle.battlechoicep1 = -1
    battle.battlechoicep2 = -1
    save() # outside function that saves the scores into a pickle file
    return

So, I would like to make it so this is a function inside my class, so everytime I call battle.reset it would call something like this

def reset():
    battle.pcount = 0
    battle.team1 = []
    battle.team2 = []
    battle.p1 = ()
    battle.p2 = ()
    battle.p1score = 0
    battle.p2score = 0
    battle.battlechoicep1 = -1
    battle.battlechoicep2 = -1
    save() # outside function that saves the scores into a pickle file
    return

I don't know how is the right approach to this problem, I don't even know if what I've been doing up to now is 'correct' (it is working at least). Creating the function inside the class (like def reset(self):) seems to have no effect.

Answer 1

You're on the right track with def reset(self). You just need to change the instances of battle to self in the method itself. NOTE: This needs to be a method of the Battle class.

def reset(self):
    self.pcount = 0
    ... # etc
    save() # outside function that saves the scores into a pickle file

When you pass in self as the first parameter of a class method, it allows the method to work on the instance of the class that you've called it on. If you just do def reset(self) without changing the battle to self, it will try to modify a variable in the current scope called battle, which in this case probably doesn't exist.

The other thing you could do if you just want reset to create a completely new object without preserving any of the attributes, you can just do:

def reset(self):
    return Battle()

Answer 2

You're almost there!

class Battle:
    def __init__(self, mainchat):
        self.mainchat = mainchat
        print('Instance of battle started on chat %s' % self.mainchat)
        self.reset()

    def reset(self):
        self.team1, self.team2 = [], []
        self.p1 = self.p2 = ()  #New tuples will be assigned and overwritten
        self.pcount = self.p1score = self.p2score = 0
        self.battlechoicep1 = self.battlechoicep2 = -1
        save() # outside function that saves the scores into a pickle file

So when you need to reset, just call battle.reset()! Maybe the save function can also be a class method as well, just follow the same format.

How to create and keep a set of variables in python?

2 个答案: