Question

我想修复valgrind报告的问题：

==7182== Conditional jump or move depends on uninitialised value(s)
==7182==    at 0x40EC75C: strstr (in /lib/libc-2.9.so)
==7182==    by 0x804A977: search_graph_begin (compression.c:462)
==7182==    by 0x804AB60: search_graph_end (compression.c:497)
==7182==    by 0x804AA97: search_graph_begin (compression.c:477)
==7182==    by 0x804B59A: do_g_decompress (compression.c:767)
==7182==    by 0x804996C: main (server.c:302)

我的相关代码部分是：

    void search_graph_begin(char* buf, FILE *dest,int* graph_count,int extension,
  char* graphs,char* directory,int have)
    {
 char* begingraph = NULL;
 begingraph = strstr(buf,"<GRAPH>");
 if (begingraph != NULL)
 {
  if ( (int)(begingraph - buf) > 1)
  {
   printf("(int)(begingraph-buf) %d\n",(int)(begingraph-buf));
   xwrite(dest,buf,(int)(begingraph-buf));
  }
  (*graph_count)++;
  sprintf(graphs,"%s/tmp/graphs%d/graph%d",directory,extension,(*graph_count));
  /*open file to save received graph data*/
  FILE* graphfile = fopen(graphs,"wb");
  if (graphfile == NULL)
   fprintf(stderr,"could not create graph file\n");

  search_graph_end(begingraph+strlen("<GRAPH>")+1,graphfile,dest,graph_count,extension,graphs,directory,
    have-(begingraph+strlen("<GRAPH>")+1-buf));
 }
 else
 {
  if (have > 1)
  xwrite(dest,buf,have);
  buf = NULL;
 }
    }

     void search_graph_end(char* buf, FILE* graphfile, FILE *dest,int* graph_count,int extension,
  char* graphs,char* directory,int have)
     {
 char* endgraph = NULL;
 endgraph = strstr(buf,"<GRAPH/>");
 if (endgraph != NULL)
 {
  xwrite(graphfile,buf,sizeof(char)*(endgraph-buf));
  fclose(graphfile);
  search_graph_begin(endgraph+strlen("<GRAPH/>")+1,dest,graph_count,extension,graphs,directory,
    have-(endgraph+strlen("<GRAPH/>")+1-buf));
 }
 else
 {
  if (have > 1)
  xwrite(graphfile,buf,have);
  buf = NULL;
 }
    }

程序在valgrind下运行正常，但不是这样的情况。该程序的想法是循环读取缓冲区并在valise和不同文件之间写入文本

Answer 1

在一个环境中崩溃的程序，但在一个稍微不同的环境中崩溃（在Valgrind下，在gdb中，不同的-O）是一个由bug引起的未定义行为的迹象。事实是，实际的错误（例如，一个一个一个写）可以在程序中的位置找到。堆栈跟踪仅告知您检测到错误的位置。您需要超越堆栈跟踪以查找实际错误。你的程序的哪一部分负责初始化Valgrind抱怨的价值？

valgrind条件跳转或移动取决于未初始化的值

1 个答案: