在#34; TypeError:无法读取属性' _id'未定义"

时间:2016-06-25 15:43:58

标签: javascript node.js mongodb

使用MEAN"完成#34; Full Stack JavaScript开发的第8章中的示例。由Adam Bretz& Colin Ihrig和书中的代码似乎并不完整(可能是故意的)。我花了很多时间调试谷歌搜索和搜索StackOverflow。脚本可以执行正常,直到insertEmployee然后保释。我无法弄清楚如何设置insertEmployee参数(pd,devops,acct)的参数。我陷入了#34;回调地狱"!

基本上我使用Node来填充MongoDb

  

如果我将insertEmployee函数设置为对所有使用pd._id   员工很好,但使用devops._id或acct._id总会导致   

下面的错误
*TypeError: Cannot read property '_id' of undefined
    at insertEmployees (/Users/Bluemagma/Sites/NodeJS Example Application/database/humanresourcesSchema.js:111:17)
    at /Users/Bluemagma/Sites/NodeJS Example Application/database/humanresourcesSchema.js:199:3
    at /Users/Bluemagma/Sites/NodeJS Example Application/database/humanresourcesSchema.js:62:4
    at Function.<anonymous> (/Users/Bluemagma/Sites/NodeJS Example Application/node_modules/mongoose/lib/model.js:3352:16)
    at /Users/Bluemagma/Sites/NodeJS Example Application/node_modules/mongoose/lib/model.js:1863:18
    at /Users/Bluemagma/Sites/NodeJS Example Application/node_modules/async/lib/async.js:726:13
    at /Users/Bluemagma/Sites/NodeJS Example Application/node_modules/async/lib/async.js:52:16
    at done (/Users/Bluemagma/Sites/NodeJS Example Application/node_modules/async/lib/async.js:246:17)
    at /Users/Bluemagma/Sites/NodeJS Example Application/node_modules/async/lib/async.js:44:16
    at /Users/Bluemagma/Sites/NodeJS Example Application/node_modules/async/lib/async.js:723:17
    at /Users/Bluemagma/Sites/NodeJS Example Application/node_modules/async/lib/async.js:167:37
    at model.callbackWrapper (/Users/Bluemagma/Sites/NodeJS Example Application/node_modules/mongoose/lib/model.js:1841:11)
    at next_ (/Users/Bluemagma/Sites/NodeJS Example Application/node_modules/hooks-fixed/hooks.js:89:34)
    at fnWrapper (/Users/Bluemagma/Sites/NodeJS Example Application/node_modules/hooks-fixed/hooks.js:186:18)
    at /Users/Bluemagma/Sites/NodeJS Example Application/node_modules/mongoose/lib/model.js:3352:16
    at /Users/Bluemagma/Sites/NodeJS Example Application/node_modules/mongoose/lib/model.js:228:5*

继承人源资源的代码.Schema.js

var mongoose = require('mongoose');
var Schema = mongoose.Schema;
var db = mongoose.connection;
var dbUrl = 'mongodb://localhost/humanResources';

var TeamSchema = new Schema({
    name: {
        type: String,
        required: true
    }
});

var Team = mongoose.model('Team', TeamSchema);

var EmployeeSchema = new Schema({
    name: {
        first: {
            type: String,
            required: true
        },
        last: {
            type: String,
            required: true
        }
    },
    team: {
        type: Schema.Types.ObjectId,
        ref: 'Team'
    },
    image: {
        type: String,
        default: 'images/user.png'
    },
    address: {
        lines: {
            type: [String]
        },
        postal: {
            type: String
        }
    }
});

var Employee = mongoose.model('Employee', EmployeeSchema);

db.on('error', function () {
    console.log('there was an error communicating with the damn database');
});

function insertTeams (callback) {
    Team.create([{
        name: 'Product Development'
    }, {
        name: 'Dev Ops'
    }, {
        name: 'Accounting'
    }], function (error, pd, devops, acct) {
        if (error) {
            return callback(error);
        } else {
            console.info('teams sucessfully added sir!');
            callback(null, pd, devops, acct);           
        }
    });
}

function retrieveEmployee (data, callback) {
    Employee.findOne({
        _id: data.employee._id
    }).populate('team').exec(function (error, result) {
        if (error) {
            return callback (error);
        } else {
            console.log('*** Single Employee Result ***');
            console.dir(result);
            callback(null, data);
        }
    });
}

function retrieveEmployees (data, callback) {
    Employee.find({
        'name.first': /J/i
    }, function (error, results) {
        if (error) {
            return callback(error);
        } else {
            console.log('*** Multiple Employees Result ***');
            console.dir(results);
            callback(null, data);
        }
    });
}

function insertEmployees (pd, devops, acct, callback) {
  Employee.create([{
    name: {
      first: 'John',
      last: 'Adams'
    },
    Team: pd._id,
    address: {
      lines: ['2 Lincoln Memorial Cir NW'],
      postal: '20037'
    }
  }, {
    name: {
      first: 'Thomas',
      last: 'Jefferson'
    },
    Team: devops._id,
    address: {
      lines: ['1600 Pennsylvania Avenue', 'White House'],
      postal: '20500'
    }
  }, {
    name: {
      first: 'James',
      last: 'Madison'
    },
    team: acct._id,
    address: {
      lines: ['2 15th St NW', 'PO Box 8675309'],
      postal: '20007'
    }
  }, {
    name: {
      first: 'James',
      last: 'Monroe'
    },
    team: acct._id,
    address: {
      lines: ['1850 West Basin Dr SW', 'Suite 210'],
      postal: '20242'
    }
  }], function (error, johnadams) {
    if (error) {
      return callback(error);
    } else {
      console.info('employees successfully added sir!');
      callback(null, {
        team: pd,
        employee: johnadams
      });
    }
  })
}

function updateEmployee (first, last, data, callback) {
    console.log('*** Changin names ***');
    console.dir(data.employee);

    var employee = data.employee;
    employee.name.first = first;
    employee.name.last = last;

    employee.save(function (error, result) {
        if (error) {
            return callback (error);
        } else {
            console.log('*** Changed name to Andrew Jackson ***');
            console.log(result);
            callback(null, data);
        }
    });
}

function removeTeams () {
    console.info("deleting all previously added teams sir!");
    Team.remove({}, function(error, response) {
        if(error) {
            console.error("tried to delete all teams but " + error);
        }
        console.info("done deleting all teams sir!");
    });
}

function removeEmployees () {
    console.info("deleting all previously added employees sir!");
    Employee.remove({}, function(error, response) {
        if(error) {
            console.error("tried to delete all employees but " + error);
        }
        console.info("done deleting all employees sir!");
    });
}

mongoose.connect(dbUrl, function (err) {
    if (err) {
        return console.log('there was a problem connecting to the database sir!' + err);
    }
    console.log('connected to the database sir!');
    removeTeams();
    removeEmployees();
    insertTeams(function (error, pd, devops, acct) {
        if (error) {
            return console.log(error);
        }
        insertEmployees(pd, devops, acct, function (err, result){

            retrieveEmployee(result, function(err, result) {

                retrieveEmployees(result, function(err, result) {

                    updateEmployee('Andrew', 'Jackson', result, function(err, result) {
                        if (err) {
                        console.error(err);
                    } else {
                        console.info("database activity complete sir!");
                    }

                    db.close();
                    process.exit();
                    });
                });
            });
        });
    });
});

感谢您对Node和Mongo Geniuses的帮助!我期待了解有关回调的更多信息

2 个答案:

答案 0 :(得分:1)

function insertTeams (callback) {
    Team.create([{
        name: 'Product Development'
    }, {
        name: 'Dev Ops'
    }, {
        name: 'Accounting'
    }], function (error, pd, devops, acct) {
        if (error) {
            return callback(error);
        } else {
            console.info('teams sucessfully added sir!');
            callback(null, pd, devops, acct);           
        }
    });
}

这里的回调看起来很可疑。您将一个数组作为单个参数传递给Team.create(),因此回调将被调用为function(err, results),其中results是一个包含插入文档的数组。

因此,当您调用类似callback(null, pd, devops, acct);的回调时,错误将为null,pd将是您的结果数组,devops和acct将是未定义的。

您可以将团队作为单独的参数传递给Team.create,然后也会使用多个参数调用回调,或者保持原样,并调整回调以处理数组。

Mongoose examples.

或者这是&#34;架子我已经好几天了,我只需要删除两个括号&#34;版本(希望如此):

function insertTeams (callback) {
    Team.create({
        name: 'Product Development'
    }, {
        name: 'Dev Ops'
    }, {
        name: 'Accounting'
    }, function (error, pd, devops, acct) {
        if (error) {
            return callback(error);
        } else {
            console.info('teams sucessfully added sir!');
            callback(null, pd, devops, acct);           
        }
    });
}

一些安装得好的console.log()可以帮助您找到丢失变量的位置。

答案 1 :(得分:0)

我感觉你在insertTeams函数中遇到错误。

当它调用带有错误的回调函数(insertEmployees)时,如果出现错误,该函数根本不会尝试捕获或处理错误。相反,它调用回调并仅将错误本身作为参数传递。由于insertEmployees没有任何错误处理,因此它不会在启动之前检查是否发生了错误。因此,当它试图调用devops的_id属性时,devop是未定义的,因为在调用函数时它没有被定义。因此,JS出错了。

有关详细信息,您可能希望尝试在insertTeams中记录错误。

编辑:我认为问题仍然是使用回调调用insertEmployees(错误)。您可以访问错误的_id字段,因为错误存在,因此至少会返回undefined。但是,其他参数没有定义,因为它们没有传递给函数,因此只要您尝试访问它们的_id字段,就会出现错误,因为您尝试访问其中的某个字段。未定义的对象。