为什么只有一个JavaScript函数执行onClick?

时间:2016-06-25 14:10:56

标签: javascript html css html5 javascript-events

我是JavaScript的新手,据说我在代码中遇到了一个奇怪的错误。我的HTML中有三个图像,点击时应该以模态打开。由于某种原因,模态将卡在最后一个新图像上。例如,如果我点击第一个,然后是第三个,那么第二个,无论我点击第二个显示的是什么图像。我尝试通过将H1标签替换为图像名称进行调试,该标签抛出了另一条曲线,因为现在需要两次单击才能执行模态。我不确定我在做什么,感谢任何帮助。

JS -

<script>
function mode(param)
{

    smode = param;
    document.getElementById("h1thing").innerHTML = smode;
    document.getElementById("myImage").src = smode;
    run();

}
function run(){
// Get the modal
var modal = document.getElementById('myModal');


// Get the button that opens the modal
var btn = document.getElementById(smode);

// Get the <span> element that closes the modal
var span = document.getElementsByClassName("close")[0];


// When the user clicks the button, open the modal
btn.onclick = function() {
    modal.style.display = "block";

}

// When the user clicks on <span> (x), close the modal
span.onclick = function() {
    modal.style.display = "none";
    smode = "";

}



// When the user clicks anywhere outside of the modal, close it
window.onclick = function(event) {
    if (event.target == modal) {
        modal.style.display = "none";
        smode = "";
    }
}
}
</script>

HTML -

<body>

<h2 id="h1thing">Modal Example</h2>


<!-- Trigger/Open The Modal -->
<center>
<div class="floated_img">
    <input id="ScreenShot.png" type="image" src="ScreenShot.png" width="400" height="300" alt="ScreenShot" onclick="myFunction();mode('ScreenShot.png');">
    </input>
</div>
<div class="floated_img">
    <input id="ScreenShot2.png" type="image" src="ScreenShot2.png" width="400" height="300" alt="ScreenShot2" onclick="myFunction();mode('ScreenShot2.png');">
    </input>
</div>
<div class="floated_img">
    <input id="kimlexi.jpg" type="image" src="kimlexi.jpg" width="400" height="300" alt="Kimlexi" onclick="myFunction();mode('kimlexi.jpg');">
    </input>
</div>
</center>
<!-- The Modal -->
<div id="myModal" class="modal">
  <!-- Modal content -->
  <div class="modal-content">
    <span class="close">

            <img src="x.png" width="40" height="40" alt="X">
    </span>
    <center>
        <img id="myImage" src="" width="600" height="500" alt="Kimlexi">
    </center>
  </div>

</div>
</body>

CSS -

<style>
button {
    background:transparent;
      border:none;
      outline:none;
      display:block;
      height:200px;
      width:200px;
      cursor:pointer;
}
/* The Modal (background) */
.modal {
    display: none; /* Hidden by default */
    position: fixed; /* Stay in place */
    z-index: 1; /* Sit on top */
    padding-top: 100px; /* Location of the box */
    left: 0;
    top: 0;
    width: 100%; /* Full width */
    height: 100%; /* Full height */
    overflow: auto; /* Enable scroll if needed */
    background-color: rgb(0,0,0); /* Fallback color */
    background-color: rgba(0,0,0,0.4); /* Black w/ opacity */
}


/* Modal Content */
.modal-content {
    background-color: #fefefe;
    margin: auto;
    padding: 20px;
    border: 1px solid #888;
    width: 80%;
}

/* The Close Button */
.close {
    color: #aaaaaa;
    float: right;
    font-size: 28px;
    font-weight: bold;
}

.close:hover,
.close:focus {
    color: #000;
    text-decoration: none;
    cursor: pointer;
}

.floated_img
{
    float: left;
}
</style>

1 个答案:

答案 0 :(得分:0)

问题

这里有两个问题。

  1. 第一次单击按钮不会打开模式。第一次单击图像时(让我们使用第一个图像作为示例),执行mode('ScreenShot.png')
    1. 将smode设置为'ScreenShot.png'
    2. <h1>
    3. 中显示smode(='ScreenShot.png')
    4. 将smode(='ScreenShot.png')设为<img>的{​​{1}}
    5. 调用run(),它会更改按钮的src处理程序,但从不实际打开模态!
  2. 第二次单击同一按钮可能会显示错误的图像。这是因为按钮的onclick处理程序在上面的步骤1.4中被覆盖(它被覆盖,未添加),并且新事件处理程序(onclick)仅使模式可见但不更改图像源。
  3. 建议的解决方案

    如果只设置一次btn.onclick = function() { modal.style.display = "block"; }处理程序,会更容易。这是一个解决方案。

    JS -

    onclick

    HTML -

    function openModal(imgSrc)
    {
        document.getElementById("myImage").src = imgSrc;
        document.getElementById("myModal").style.display = "block";
    }
    
    function closeModal() {
        document.getElementById('myModal').style.display = "none";
    }
    
    // When the user clicks anywhere outside of the modal, close it
    window.onclick = function(event) {
        if (event.target == document.getElementById('myModal')) {
            closeModal();
        }
    }