Question

我正在尝试在CodeIgniter上构建我的第一个应用程序。这也是我第一次尝试尽可能地坚持OOP和MVC。到目前为止一切顺利，但现在我正在尝试编写我的第一个模型，我遇到了一些麻烦。这是我得到的错误：

发生数据库错误

错误号码：1064

您的SQL语法有错误;查看与MySQL服务器版本对应的手册，以便在第3行的'Castledine'附近使用正确的语法

SELECT * FROM（authors）WHERE author =厄尔Castledine

正如您将在下面看到的那样，与我的模型中的以下行相关：

$this->db->get_where('authors', array('author' => $author));

我不太确定为什么它会抛出错误。是因为厄尔Castledine没有引号？如果是这样，为什么CI不把它们放在那里？我怀疑这是问题，而不是认为这是我的错，但我不确定。

我也有另一个问题。标签和作者都没有插入各自的表中。他们的insert语句包含在一个条件中，该条件应该确保它们不存在，但它似乎失败并且插入永远不会发生。我认为它失败了，因为标签没有被放入数据库中，而是在它抛出错误之前它在作者部分中。我知道如何使用纯PHP执行此操作，但我正在尝试使用纯CI ActiveRecord方式。

以下是我正在使用的声明：

 if ($this->db->count_all_results() == 0)

我正在使用它而不是我通常使用的那个：

if (mysql_num_rows() == 0)

我做错了吗？

这是我的模型和控制器（只有重要的功能），尽我所能评论。

型号：

function new_book($book, $tags, $authors, $read) {

    // Write book details to books table
    $this->db->insert('books', $book);

    // Write tags to tag table and set junction
    foreach ($tags as $tag) {
        // Check to see if the tag is already in the 'tags' table
        $this->db->get_where('tags', array('tag' => $tag));
        // trying to use this like mysql_num_rows()
        if ($this->db->count_all_results() == 0) {
            // Put it there
            $this->db->insert('tags', $tag);
        }
        // Set the junction
        // I only need the id, so...
        $this->db->select('id');
        // SELECT id FROM tags WHERE tag = $tag
        $query = $this->db->get_where('tags', array('tag' => $tag));
        // INSERT INTO books_tags (book_id, tag_id) VALUES ($book['isbn'], $query->id)
        $this->db->insert('books_tags', array('book_id' => $book['isbn'], 'tag_id' => $query->id));
    }

    // Write authors to author table and set junction
    // Same internal comments apply from tags above
    foreach ($authors as $author) {
        $this->db->get_where('authors', array('author' => $author));
        if ($this->db->count_all_results() == 0) {
            $this->db->insert('authors', $author);
        }
        $this->db->select('id');
        $query = $this->db->get_where('authors', array('author' => $author));
        $this->db->insert('authors_books', array('book_id' => $book['isbn'], 'author_id' => $query));
    }

    // If the user checked that they've read the book
    if (!empty($read)) {
        // Get their user id
        $user = $this->ion_auth->get_user();
        // INSERT INTO books_users (book_id, tag_id) VALUES ($book['isbn'], $user->id)
        $this->db->insert('books_users', array('book_id' => $book['isbn'], 'user_id' => $user->id));
    }

}

控制器：

function confirm() {

    // Make sure they got here by form result, send 'em packing if not
            $submit = $this->input->post('details');
    if (empty($submit)) {
        redirect('add');
    }

            // Set up form validation
    $this->load->library('form_validation');
    $this->form_validation->set_error_delimiters('<h3 class="error">', ' Also, you&rsquo;ll need to choose your file again.</h3>');
    $this->form_validation->set_rules('isbn','ISBN-10','trim|required|exact_length[10]|alpha_numeric|unique[books.isbn]');
    $this->form_validation->set_rules('title','title','required');
    $this->form_validation->set_rules('tags','tags','required');

            // Set up upload
    $config['upload_path'] = './books/';
    $config['allowed_types'] = 'pdf|chm';
    $this->load->library('upload', $config);

            // If they failed validation or couldn't upload the file
    if ($this->form_validation->run() == FALSE || $this->upload->do_upload('file') == FALSE) {
        // Get the book from Amazon
                    $bookSearch = new Amazon();
        try {
            $amazon = $bookSearch->getItemByAsin($this->input->post('isbn'));
        } catch (Exception $e) {
            echo $e->getMessage();
        }
                    // Send them back to the form
        $data['image'] = $amazon->Items->Item->LargeImage->URL;
        $data['content'] = 'add/details';
        $data['error'] = $this->upload->display_errors('<h3 class="error">','</h3>');
        $this->load->view('global/template', $data);

            // If they did everything right
            } else {
                    // Get the book from Amazon
        $bookSearch = new Amazon();
        try {
            $amazon = $bookSearch->getItemByAsin($this->input->post('isbn'));
        } catch (Exception $e) {
            echo $e->getMessage();
        }

        // Grab the file info
                    $file = $this->upload->data();

        // Prep the data for the books table
                    $book = array(
            'isbn' => $this->input->post('isbn'),
            'title' => mysql_real_escape_string($this->input->post('title')),
            'date' => $amazon->Items->Item->ItemAttributes->PublicationDate,
            'publisher' => mysql_real_escape_string($amazon->Items->Item->ItemAttributes->Publisher),
            'pages' => $amazon->Items->Item->ItemAttributes->NumberOfPages,
            'review' => mysql_real_escape_string($amazon->Items->Item->EditorialReviews->EditorialReview->Content),
            'image' => mysql_real_escape_string($amazon->Items->Item->LargeImage->URL),
            'thumb' => mysql_real_escape_string($amazon->Items->Item->SmallImage->URL),
            'filename' => $file['file_name']
        );

        // Get the tags, explode by comma or space
                    $tags = preg_split("/[\s,]+/", $this->input->post('tags'));
                    // Get the authors
                    $authors = array();
                    foreach ($amazon->Items->Item->ItemAttributes->Author as $author) {
                        array_push($authors, $author);
                    }
                    // Find out whether they've read it
                    $read = $this->input->post('read');
                    // Send it up to the database
                    $this->load->model('add_model', 'add');
                    $this->add->new_book($book, $tags, $authors, $read);
                    // For now... Later I'll load a view
                    echo 'Success';

    }

}

任何人都可以帮助阐明我做错了什么吗？非常感谢。

马库斯

Answer 1

你在使用count_all_results（）的地方，我认为你的意思是使用 num_rows （）。 count_all_results（）实际上会创建一个SELECT COUNT（*）查询。

调试问题...
如果要测试insert（）是否有效，请使用affected_rows()，例如：

var_dump($this->db->affected_rows());

您可以随时输出last_query()的最后一个查询，例如：

var_dump($this->db->last_query());

您还可以打开Profiler，以便通过添加控制器来查看正在运行的所有查询：

$this->output->enable_profiler(TRUE);

Answer 2

我设法自己解决了这个问题。控制器没有真正改变，但这是新模型：

function new_book($book, $tags, $authors, $read) {

    // Write book details to books table
    $this->db->insert('books', $book);

    // Write tags to tag table and set junction
    foreach ($tags as $tag) {
        // Check to see if the tag is already in the 'tags' table
        $query = $this->db->get_where('tags', array('tag' => $tag));
        // trying to use this like mysql_num_rows()
        if ($query->num_rows() == 0) {
            // Put it there
            $this->db->insert('tags', array('tag' => $tag));
        }
        // Set the junction
        // I only need the id, so...
        $this->db->select('id');
        // SELECT id FROM tags WHERE tag = $tag
        $query = $this->db->get_where('tags', array('tag' => $tag));
        $result = $query->row();
        // INSERT INTO books_tags (book_id, tag_id) VALUES ($book['isbn'], $query->id)
        $this->db->insert('books_tags', array('book_id' => $book['isbn'], 'tag_id' => $result->id));
    }

    // Write authors to author table and set junction
    // Same internal comments apply from tags above
    foreach ($authors as $author) {
        $query = $this->db->get_where('authors', array('author' => mysql_real_escape_string($author)));
        if ($query->num_rows() == 0) {
            $this->db->insert('authors', array('author' => mysql_real_escape_string($author)));
        }
        $this->db->select('id');
        $query = $this->db->get_where('authors', array('author' => mysql_real_escape_string($author)));
        $result = $query->row();
        $this->db->insert('authors_books', array('book_id' => $book['isbn'], 'author_id' => $result->id));
    }

    // If the user checked that they've read the book
    if (!empty($read)) {
        // Get their user id
        $user = $this->ion_auth->get_user();
        // INSERT INTO books_users (book_id, tag_id) VALUES ($book['isbn'], $user->id)
        $this->db->insert('books_users', array('book_id' => $book['isbn'], 'user_id' => $user->id));
    }

}

CodeIgniter ActiveRecord问题

2 个答案: