存储返回值然后使用vs直接使用c ++

时间:2010-09-23 22:32:29

标签: c++ function parameters return-value

嘿伙计们,我正在写一些代码,我发现了一个奇怪的错误。函数convert_vector2d(& i_scale)将字符串转换为vector2d(继承自sf :: vector2f)。如果你检查下几行代码,我会做两次相同的操作。

代码:全选

float x = convert_Vector2D(&i_scale).x;
float y = convert_Vector2D(&i_scale).y;
object.SetScale( ( convert_Vector2D(&i_scale) ) );
ss = object.GetScale();
object.SetScale( x , y );
ss = object.GetScale();

我第一次使用convert_vector2d和ss = 1,1的返回向量调用setScale。然后我再次使用x,y(存储的结果)调用object.setScale,当我调用object.getScale时,我得到ss = 1,2(预期/正确)。

我逐步完成了convert函数,它通过两个函数调用返回1,2。

代码:全选

const Vector2D Map::convert_Vector2D(std::string * string_to_convert)
{
    size_t foundit = 0;
    Vector2D temp;
    std::string one, two;
    if( (foundit = string_to_convert->find(',')) != std::string::npos &&
        string_to_convert->find_first_of(',') == string_to_convert->find_last_of(',') ) // only one comma per line.
    {
        one = string_to_convert->substr(0, foundit);
        two = string_to_convert->substr(foundit+1, string_to_convert->size()); // +1 to skip over the comma.

        temp.x = (float)strtod( one.c_str(), NULL );
        temp.y = (float)strtod( two.c_str(), NULL );

        check_conversion_errors_vector2d(temp, string_to_convert);
    }
    else
    {
        Debugger::print("MapLoader: Error: more then one comma on line %d of file %s. Stopping reading of file.\n",
            i_Current_Line, mMapName.c_str() );
        i_QuitParsing = true; // TODO: maybe add return after this line?
    }

    return temp;
}

关于我为什么会有不同行为的任何想法?

void Drawable::SetScale(float ScaleX, float ScaleY)
{
    SetScaleX(ScaleX);
    SetScaleY(ScaleY);
}

void Drawable::SetScale(const Vector2f& Scale)
{
    SetScaleX(Scale.x);
    SetScaleY(Scale.y);
}

void Drawable::SetScaleX(float FactorX)
{
    if (FactorX > 0)
     {
          myScale.x       = FactorX;
          myNeedUpdate    = true;
          myInvNeedUpdate = true;
     }
}


void Drawable::SetScaleY(float FactorY)
{
     if (FactorY > 0)
     {
          myScale.y = FactorY;
          myNeedUpdate    = true;
          myInvNeedUpdate = true;
     }
 }

SFML拷贝构造函数和成员变量:

// = equals operator assignment
Vector2D& operator=(const Vector2D &rhs)
{
    if(this == &rhs)
    {
        return *this;
    }
    else
    {
        this->x = rhs.x;
        this->y = rhs.y;
        return *this;
    }
}
// = equals operator assignment
Vector2D& operator=(const sf::Vector2f &rhs)
{
    this->x = rhs.x;
    this->y = rhs.y;
    return *this;
}

float x, y;

1 个答案:

答案 0 :(得分:0)

不要在堆栈上分配Vector2D,使用new在堆上执行。您对函数外部的temp的引用是未定义的,可能是垃圾。