为什么我的Django表单没有引发验证错误?

时间:2016-05-19 15:24:04

标签: python django validation python-3.x django-forms

以下是我的表单代码:

class ConfirmEmailForm(forms.Form):
    email = forms.EmailField()
    subscribe = forms.IntegerField()
    code = forms.CharField(max_length=80)

    def clean_subscribe(self):
        value = bool(self.cleaned_data['subscribe'])
        self.cleaned_data['subscribe'] = value
        return value

    def clean(self):
        cleaned_data = super(ConfirmEmailForm, self).clean()
        email = cleaned_data['email']
        code = cleaned_data['code']
        user = User.objects.filter(username=email).first()
        if not user:
            raise forms.ValidationError('Email not found')
        self.cleaned_data['user'] = user
        if user.emailverification.is_key_expired():
            raise forms.ValidationError('Link expired, please regenerate')
        if not user.emailverification.key == code:
            raise forms.ValidationError('Invalid Link')
        return cleaned_data

我正在使用此表单进行GET请求。现在当我在没有email字段的情况下发送请求时,我预计会在cleaned_data处引发错误,但是它不会引发任何错误,而是我KeyError下一行。

显然它会引发KeyError,因为它不存在。但我的问题是,为什么super(ConfirmEmailForm, self).clean()本身没有提出错误。

以下是完整的追溯:

Environment:


Request Method: GET
Request URL: http://localhost:8000/user/confirm/?code=g&subscribe=1

Django Version: 1.9.6
Python Version: 3.5.1
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'nightreads',
 'nightreads.posts',
 'nightreads.user_manager']
Installed Middleware:
['django.middleware.security.SecurityMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.auth.middleware.SessionAuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware']



Traceback:

File "/Users/avi/.virtualenvs/nightreads/lib/python3.5/site-packages/django/core/handlers/base.py" in get_response
  149.                     response = self.process_exception_by_middleware(e, request)

File "/Users/avi/.virtualenvs/nightreads/lib/python3.5/site-packages/django/core/handlers/base.py" in get_response
  147.                     response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/Users/avi/.virtualenvs/nightreads/lib/python3.5/site-packages/django/views/generic/base.py" in view
  68.             return self.dispatch(request, *args, **kwargs)

File "/Users/avi/.virtualenvs/nightreads/lib/python3.5/site-packages/django/views/generic/base.py" in dispatch
  88.         return handler(request, *args, **kwargs)

File "/Users/avi/Documents/code/nightreads/nightreads/user_manager/views.py" in get
  54.         if form.is_valid():

File "/Users/avi/.virtualenvs/nightreads/lib/python3.5/site-packages/django/forms/forms.py" in is_valid
  161.         return self.is_bound and not self.errors

File "/Users/avi/.virtualenvs/nightreads/lib/python3.5/site-packages/django/forms/forms.py" in errors
  153.             self.full_clean()

File "/Users/avi/.virtualenvs/nightreads/lib/python3.5/site-packages/django/forms/forms.py" in full_clean
  363.         self._clean_form()

File "/Users/avi/.virtualenvs/nightreads/lib/python3.5/site-packages/django/forms/forms.py" in _clean_form
  390.             cleaned_data = self.clean()

File "/Users/avi/Documents/code/nightreads/nightreads/user_manager/forms.py" in clean
  30.         email = cleaned_data['email']

Exception Type: KeyError at /user/confirm/
Exception Value: 'email'

为什么会这样?我该如何解决这个问题?在clean中访问经过验证和清理的数据的正确方法是什么?

3 个答案:

答案 0 :(得分:3)

如果clean方法出错,它会将其添加到错误列表中,但不会引发错误。

您可以找到代码行here

        except ValidationError as e:
            self.add_error(name, e)

您可以使用cleaned_data.get('email')来解决此问题,如果找不到该值,则None会返回{ - 1}},然后您可以检查该值。

答案 1 :(得分:2)

在执行cleaned_data['email']之前,检查是否存在任何错误。

def clean(self):
    cleaned_data = super(ConfirmEmailForm, self).clean()

    if any(self.errors):
        return self.errors

    email = cleaned_data['email']
    code = cleaned_data['code']

希望这对你有用。

答案 2 :(得分:0)

我认为这是因为当您使用clean方法时,此方法引发的Any ValidationError不会与特定字段关联;

尝试创建除此之外的自定义。

相关问题