Question

我正在使用Crystal Reports 13添加命令从通过Oracle 11g客户端连接的Oracle数据库中选择记录。我收到的错误是ORA-00933：SQL命令没有正确结束，但我找不到任何与我的代码有关的事情（不完整）：

/*  Determine units with billing code effective dates in the previous month  */
SELECT "UNITS"."UnitNumber", "BILL"."EFF_DT"
FROM "MFIVE"."BILL_UNIT_ACCT" "BILL"
LEFT OUTER JOIN "MFIVE"."VIEW_ALL_UNITS" "UNITS" ON "BILL"."UNIT_ID" = "UNITS"."UNITID"
WHERE  "UNITS"."OwnerDepartment" LIKE '580' AND TO_CHAR("BILL"."EFF_DT", 'MMYYYY') = TO_CHAR(ADD_MONTHS(TRUNC(SYSDATE), -1), 'MMYYYY')

INNER JOIN

/*  Loop through previously identified units and determine last billing code change prior to preious month  */
(
SELECT "BILL2"."UNIT_ID", MAX("BILL2"."EFF_DT")
FROM "MFIVE"."BILL_UNIT_ACCT" "BILL2"
WHERE TO_CHAR("BILL2"."EFF_DT", 'MMYYYY') < TO_CHAR(ADD_MONTHS(TRUNC(SYSDATE), -1), 'MMYYYY')
GROUP BY "BILL2"."UNIT_ID"
)

ON "BILL"."UNIT_ID" = "BILL2"."UNIT_ID"
ORDER BY "UNITS"."UnitNumber", "BILL"."EFF_DT" DESC

我们是向其他机构出租车辆（单位）的国家实体。每个单元都有一个带有相关生效日期的帐单代码。该应用程序将开发上个月帐单代码更改的单位报告。

使问题复杂化的是，对于上述每个单元，报告还必须显示上个月之前的最新帐单代码和相关生效日期。一个简短的例子：

鉴于此数据并假设它现在是2016年4月（为清楚起见而订购）......

Unit    Billing Code    Effective Date  Excluded
----    ------------    --------------  --------
1       A               04/15/2016      Present month
1       B               03/29/2016
1       A               03/15/2016
1       C               03/02/2016
1       B               01/01/2015
2       C               03/25/2016
2       A               03/04/2016
2       B               07/24/2014
2       A               01/01/2014      A later effective date prior to previous month exists
3       D               11/28/2014      No billing code change during previous month

报告应返回以下内容......

Unit    Billing Code    Effective Date
----    ------------    --------------
1       B               03/29/2016
1       A               03/15/2016
1       C               03/02/2016
1       B               01/01/2015
2       C               03/25/2016
2       A               03/04/2016
2       B               07/24/2014

任何解决错误的帮助都将受到赞赏。

Answer 1

在WHERE子句之前有一个INNER JOIN子句。这是无效的语法 - 如果你交换它们应该有效：

SELECT "UNITS"."UnitNumber",
       "BILL"."EFF_DT"
FROM   "MFIVE"."BILL_UNIT_ACCT" "BILL"
       LEFT OUTER JOIN
       "MFIVE"."VIEW_ALL_UNITS" "UNITS"
       ON "BILL"."UNIT_ID" = "UNITS"."UNITID"

INNER JOIN

/*  Loop through previously identified units and determine last billing code change prior to preious month  */
    (
    SELECT "UNIT_ID",
           MAX("EFF_DT")
    FROM   "MFIVE"."BILL_UNIT_ACCT"
    WHERE  TO_CHAR("EFF_DT", 'MMYYYY') < TO_CHAR(ADD_MONTHS(TRUNC(SYSDATE), -1), 'MMYYYY')
    GROUP BY "UNIT_ID"
    ) "BILL2"

    ON "BILL"."UNIT_ID" = "BILL2"."UNIT_ID"
WHERE  "UNITS"."OwnerDepartment" LIKE '580'
AND    TO_CHAR("BILL"."EFF_DT", 'MMYYYY') = TO_CHAR(ADD_MONTHS(TRUNC(SYSDATE), -1), 'MMYYYY')
ORDER BY "UNITS"."UnitNumber", "BILL"."EFF_DT" DESC

此外，您需要将"BILL2"别名移到()括号之外，因为您不需要括号内的别名，但您在外面。

您确定需要双引号""吗？双引号强制列名称中的区分大小写 - 默认行为是Oracle将所有表和列名称转换为大写以从用户抽象区分大小写 - 因为您使用双引号和大写名称引用似乎是多余的。

Answer 2

解决方案：

SELECT DISTINCT "BILL2".*
FROM "MFIVE"."BILL_UNIT_ACCT" "BILL"
LEFT JOIN

  /*  Returns all rows for each unit with effective date >= maximum prior effective date and effective date < current month */
  (
  SELECT "UNITS"."UnitNumber" AS "UNITNO",
    UPPER("UNITS"."SpecNoDescription") AS "TS_DESCR",
    "UNITS"."UsingDepartment" AS "USING_DEPT",
    "UNITS"."OwnerDepartment" AS "OWNING_DEPT",
    "BILL"."BILLING_CODE",
    "BILL"."EFF_DT",
    "BILL"."UNIT_ID"
  FROM "MFIVE"."BILL_UNIT_ACCT" "BILL"
  LEFT OUTER JOIN "MFIVE"."VIEW_ALL_UNITS" "UNITS" ON "BILL"."UNIT_ID" =  "UNITS"."UNITID"
  WHERE TO_NUMBER(TO_CHAR(TRUNC("BILL"."EFF_DT"), 'YYYYMM'), '999999') < TO_NUMBER(TO_CHAR(TRUNC(ADD_MONTHS(SYSDATE, 0)), 'YYYYMM'), '999999') AND
"UNITS"."OwnerDepartment" = '580' AND
"BILL"."EFF_DT" >=

    /*  Returns maximum effective date prior to previous month for each unit  */
    (
    SELECT MAX("BILL3"."EFF_DT")
    FROM "MFIVE"."BILL_UNIT_ACCT" "BILL3"
    WHERE "BILL3"."UNIT_ID" = "BILL"."UNIT_ID" AND
      TO_NUMBER(TO_CHAR(TRUNC("BILL3"."EFF_DT"), 'YYYYMM'), '999999') < TO_NUMBER(TO_CHAR(TRUNC(ADD_MONTHS(SYSDATE, -1)), 'YYYYMM'), '999999')
    GROUP BY "BILL3"."UNIT_ID"
    ) 

  ) BILL2

ON "BILL"."UNIT_ID" = "BILL2"."UNIT_ID"
WHERE TO_CHAR("BILL"."EFF_DT", 'YYYYMM') = TO_CHAR(ADD_MONTHS(TRUNC(SYSDATE), -1), 'YYYYMM')
ORDER BY "BILL2"."UNITNO", "BILL2"."EFF_DT" DESC

Answer 3

如果where之前Join对您很重要，请使用CTE。（为临时表使用with子句并加入临时表。）

  With c as (SELECT "UNITS"."UnitNumber", "BILL"."EFF_DT","BILL"."UNIT_ID"  -- Correction:  Was " BILL"."UNIT_ID" (spacetanker)
    FROM "MFIVE"."BILL_UNIT_ACCT" "BILL" -- Returning unit id column too, to be used in join

LEFT OUTER JOIN "MFIVE"."VIEW_ALL_UNITS" "UNITS" ON "BILL"."UNIT_ID" = "UNITS"."UNITID"
    WHERE  "UNITS"."OwnerDepartment" LIKE '580' AND TO_CHAR("BILL"."EFF_DT", 'MMYYYY') = TO_CHAR(ADD_MONTHS(TRUNC(SYSDATE), -1), 'MMYYYY'))

    select * from c     --Filter out your required columns from c and d alias results, e.g c.UNIT_ID
    INNER JOIN

    --Loop through previously identified units and determine last billing code change prior to preious month  */
    (
    SELECT "BILL2"."UNIT_ID", MAX("BILL2"."EFF_DT")
    FROM "MFIVE"."BILL_UNIT_ACCT" "BILL2"
    WHERE TO_CHAR("BILL2"."EFF_DT", 'MMYYYY') < TO_CHAR(ADD_MONTHS(TRUNC(SYSDATE), -1), 'MMYYYY')
    GROUP BY "BILL2"."UNIT_ID"
    ) d

    ON c."UNIT_ID" = d."UNIT_ID"
     order by c."UnitNumber", c."EFF_DT" desc  -- COrrection:  Removed semicolon that Crystal Reports didn't like (spacetanker)

看来这个查询有很多调整范围。但是，有权访问数据和需求规范的人是最好的判断。

编辑： 由于您在原始问题的select语句中使用BILL.EFF_DT，因此您无法在上个月之前看到数据，该语句将被过滤以仅提供上个月的日期（..AND TO_CHAR("BILL"."EFF_DT", 'MMYYYY') = TO_CHAR(ADD_MONTHS(TRUNC(SYSDATE), -1), 'MMYYYY'))

如果你想要你想要的数据，我想你必须使用BILL2部分（我的子查询中的d部分），给Max（EFF_DT）一个别名，并在select子句中使用该别名。

SQL命令未正确结束 - Oracle子查询

3 个答案: