rspec控制器规格测试后期行动

时间:2016-04-28 21:27:24

标签: ruby-on-rails rspec controller

由于某种原因post spec工作正常,但post_comment_spec测试失败。帖子有很多post_comments,post_comment属于post。

错误:

1) Posts::PostCommentsController when user is logged in POST create with invalid attributes doesn't save the new product in the db
 Failure/Error: <span class="post-comment-updated"><%= local_time_ago(post_comment.updated_at) %></span>

 ActionView::Template::Error:
   undefined method `to_time' for nil:NilClass

posts_controller

def create
  @post = current_user.posts.new(post_params)
  authorize @post
  if @post.save
    respond_to do |format|
      format.js
    end
  else
    respond_to do |format|
      format.js
    end
  end
end  

post_comments_controller

def create
  @post = Post.find(params[:post_id])
  @post_comment = @post.post_comments.build(post_comment_params)
  authorize @post_comment
  @post_comment.user = current_user
  #@post_comment.save!
  if @post_comment.save
    @post.send_post_comment_creation_notification(@post_comment)
    @post_comment_reply = PostCommentReply.new
    respond_to do |format|
      format.js
    end
  else
    respond_to do |format|
      format.js
    end
  end
end

posts_controller_spec.rb

describe "POST create" do
  let!(:profile) { create(:profile, user: @user) }

  context "with invalid attributes" do
    subject(:create_action) { xhr :post, :create, post: attributes_for(:post, user: @user, body: "") }

    it "doesn't save the new product in the db" do
      expect{ create_action }.to_not change{ Post.count }
    end
  end
end

post_comments_controller_spec.rb

describe "POST create" do
  let!(:profile) { create(:profile, user: @user) }
  let!(:post_instance) { create(:post, user: @user) }

  context "with invalid attributes" do
    subject(:create_action) { xhr :post, :create, post_id: post_instance.id, post_comment: attributes_for(:post_comment, post_id: post_instance.id, user: @user, body: "") }

    it "doesn't save the new product in the db" do
      expect{ create_action }.to_not change{ PostComment.count }
    end
  end
end

create.js.erb for post

$("ul.errors").html("");
<% if @post.errors.any? %>
  $('.alert-danger').show();
  $('ul.errors').show();
  <% @post.errors.full_messages.each do |message| %>
    $("ul.errors").append($("<li />").html("<%= message.html_safe %>"));
  <% end %>
<% else %>
  $('ul.errors').hide();
  $('.alert-danger').hide();
  $('.post-index').prepend('<%= j render @post %>');
  collectionPostEditDropdown();
  $('.post-create-body').val('');
  $('#img-prev').attr('src', "#");
  $('#img-prev').addClass('hidden');
  $('.btn-create-post').prop('disabled',true);
  $('.remove-post-preview').addClass('hidden');
<% end %>

post_comment的create.js.erb

<% unless @post_comment.errors.any? %>
  $("#post-comment-text-area-<%= @post_comment.post_id%>").val('');
  $(".post-comment-insert-<%= @post_comment.post_id %>").prepend('<%= j render @post_comment %>');
  $(".best_in_place").best_in_place();
<% end %>

1 个答案:

答案 0 :(得分:1)

如错误所述,对local_time_ago的调用最终会尝试在{0}上调用to_time - 因此您的评论在其updated_at属性中没有任何内容。

post_comments_controller.rb 中,为什么要评论#@post_comment.save!

@post_comment.save返回的是什么?我怀疑保存由于某种原因失败了,但您仍在尝试呈现期望有效create.js.erb对象的@post_comment

编辑:当create.js.erb失败时,您不应该呈现@post_comment.save,因为它期望有效的@post_comment对象。在这种情况下,您可能希望render json: nil, status: :ok