Question

我正在使用自定义属性SpecificationAttribute和VerificationAttribute来装饰我的MSTest测试，后来我将其用于生成html测试规范报告。

属性如下所示：

[AttributeUsage(AttributeTargets.Method, AllowMultiple = true)]
public class SpecificationAttribute : Attribute
{
    public SpecificationAttribute(int step, string text)
    {
        Step = step;
        Text = text;
    }

    public int Step { get; set; }

    public string Text { get; set; }
}

我编写了一个测试，断言测试方法在使用属性时必须有独特的步骤。例如，以下用法无法通过我的测试：

[Specification(1, "Click Button)]
[Verification(1, "Verify popup")]
[Specification(1, "Click close")]
[Verification(2, "Verify popup disappears")]

我的测试看起来像这样：

[TestMethod]
public void TestForNoDuplicateStepsOnMethod()
{
    var specificationMethods = Assembly.GetExecutingAssembly().GetTypes()
        .Where(type =>
            type.GetCustomAttribute<CompilerGeneratedAttribute>() == null &&
                type.GetCustomAttribute<TestClassAttribute>() != null)
        .SelectMany(type => type.GetMethods())
        .Where(methodInfo =>
            methodInfo.GetCustomAttribute<TestMethodAttribute>() != null &&
            methodInfo.GetCustomAttributes<SpecificationAttribute>().Any())
        .ToArray();

    foreach (var method in specificationMethods)
    {
        var specificationAttributes = method.GetCustomAttributes<SpecificationAttribute>();

        var duplicates = specificationAttributes.GroupBy(s => s.Step).Where(grp => grp.Count() > 1).SelectMany(x => x).ToList();

        if (duplicates.Any())
        {
            var initialMessage = $@"{Environment.NewLine}{method.DeclaringType}.{method.Name} contains several SpecificationAttribute with the same step number." + Environment.NewLine + Environment.NewLine;

            var message = duplicates.Aggregate(initialMessage, (s, attribute) => s + attribute.Step + " " + attribute.Text + Environment.NewLine);

            Assert.Fail(message);
        }
    }
}

我想重写最后一部分，以便它成为Linq查询的一部分。这可能吗？此外，我当前的测试只输出一个失败的方法。如果Linq查询可以包含具有唯一步骤编号的失败条件的所有方法，那将是可取的。

Answer 1

如果你不需要对var specificationMethods做更多的操作，你可以试试这个：

 [TestMethod]
    public void TestForNoDuplicateStepsOnMethod()
    {
        Assembly.GetExecutingAssembly().GetTypes()
            .Where(type =>
                type.GetCustomAttribute<CompilerGeneratedAttribute>() == null &&
                    type.GetCustomAttribute<TestClassAttribute>() != null)
            .SelectMany(type => type.GetMethods())
            .Where(methodInfo =>
                methodInfo.GetCustomAttribute<TestMethodAttribute>() != null &&
                methodInfo.GetCustomAttributes<SpecificationAttribute>().Any())
            .ToList().ForEach (method=> 
        {
            var specificationAttributes = method.GetCustomAttributes<SpecificationAttribute>();

            var duplicates = specificationAttributes.GroupBy(s => s.Step).Where(grp => grp.Count() > 1).SelectMany(x => x).ToList();

            if (duplicates.Any())
            {
                var initialMessage = $@"{Environment.NewLine}{method.DeclaringType}.{method.Name} contains several SpecificationAttribute with the same step number." + Environment.NewLine + Environment.NewLine;

                var message = duplicates.Aggregate(initialMessage, (s, attribute) => s + attribute.Step + " " + attribute.Text + Environment.NewLine);

                Assert.Fail(message);
            }
    }
  }
}

Answer 2

（编辑以解决积极测试的问题）试试这个，但恕我直言，它更难阅读。

[TestMethod]
public void TestForNoDuplicateStepsOnMethod()
{
    var errors = Assembly.GetExecutingAssembly().GetTypes()
        .Where(type =>
            type.GetCustomAttribute<CompilerGeneratedAttribute>() == null &&
                type.GetCustomAttribute<TestClassAttribute>() != null)
        .SelectMany(type => type.GetMethods())
        .Where(methodInfo =>
            methodInfo.GetCustomAttribute<TestMethodAttribute>() != null &&
            methodInfo.GetCustomAttributes<SpecificationAttribute>().Any())
        .Select(method =>
            method.GetCustomAttributes<SpecificationAttribute>()
        .GroupBy(s => s.Step)
            .Where(grp => grp.Count() > 1)
            .Select(x => x.Aggregate(
                $@"{Environment.NewLine}{method.DeclaringType}.{method.Name} contains several SpecificationAttribute with the same step number." 
                + Environment.NewLine,
                (s, attribute) => s + attribute.Step + " " + attribute.Text + Environment.NewLine))
                .Aggregate("", (s, message) => s + message))
            .Aggregate("", (s, message) => s + message);
        Assert.AreEqual("", errors);
}

我怎样才能重写这个foreach，成为之前Linq表达式的一部分？

2 个答案: