为什么Jenkins的SonarQube插件会抱怨open语句,如果我在finally块中关闭它?
(我需要在单独的函数中验证数据库连接。)
final String PING = "SELECT 1 from dual";
public boolean validateConnection(Connection conn) {
PreparedStatement statement = null;
try{
if(conn == null){
LOGGER.log( LogEntries.PingError, "Null connection on PING. Reached max # of connections or network issue. Stats: "+getCacheStatistics() );
return false;
}
if(conn.isClosed()){
// logger
return false;
}
statement = conn.prepareStatement( PING ); //%%%%%% SONAR: Close this "PreparedStatement".
statement.setQueryTimeout(QUERY_TIMEOUT);
try( ResultSet rs = statement.executeQuery() ){
if ( rs != null && rs.next() ) {
return true;
}
}catch(Exception exRs){
// logger
throw exRs;
}
}catch(Exception ex){
// logger
}finally{
try{
statement.close();
}catch(Exception excpt){
// logger
}
}
return false;
}
答案 0 :(得分:1)
我按照@TT和声纳停止投诉的建议,以这种方式重构了我的代码。
public boolean validateConnection(Connection conn) {
LOGGER.log( LogEntries.PingConn );
try{
if(conn == null){
LOGGER.log( LogEntries.PingError, "Null connection on PING. Reached max # of connections or network issue. Stats: "+getCacheStatistics() );
return false;
}
if(conn.isClosed()){
LOGGER.log( LogEntries.PingError, "Found closed connection during validation PING." );
return false;
}
try( PreparedStatement statement = conn.prepareStatement( PING ) ){
statement.setQueryTimeout(QUERY_TIMEOUT);
try( ResultSet rs = statement.executeQuery() ){
if ( rs != null && rs.next() ) {
return true;
}
}
}
}catch(Exception ex){
LOGGER.log( LogEntries.PingError, ex );
}
return false;
}
没有"尝试使用资源"代码可以通过以下方式重构,但在这种情况下,声纳仍然抱怨:
public boolean validateConnection(Connection conn) {
LOGGER.log( LogEntries.PingConn );
PreparedStatement statement = null;
ResultSet rs = null;
try{
if(conn == null){
LOGGER.log( LogEntries.PingError, "Null connection on PING. Reached max # of connections or network issue. Stats: "+getCacheStatistics() );
return false;
}
if(conn.isClosed()){
LOGGER.log( LogEntries.PingError, "Found closed connection during validation PING." );
return false;
}
statement = conn.prepareStatement( PING );
statement.setQueryTimeout( QUERY_TIMEOUT );
rs = statement.executeQuery();
if ( rs != null && rs.next() ) {
return true;
}
}catch(Exception ex){
LOGGER.log( LogEntries.PingError, ex );
}finally{
try {
if(rs!=null){
rs.close();
}
} catch (SQLException eClosing1) {
LOGGER.log( LogEntries.PingError, eClosing1 );
}finally{
try {
if(statement!=null){
statement.close();
}
}catch (SQLException eClosing2) {
LOGGER.log( LogEntries.PingError, eClosing2 );
}
}
}
return false;
}
答案 1 :(得分:0)
我没有看到将所有嵌套的try
块放在没有catch
的位置。
在try
检查catch
和finally
之后,您只需要第statment
个connection
和null
。