Question

我正在尝试对自定义操作结果进行单元测试。我最近观看了Jimmy Bogard的优秀MvcConf视频（“让你的控制器节食”）http://www.viddler.com/explore/mvcconf/videos/1/并开始尝试实现一些自定义动作结果。我已经成功地解决了这个问题，ActionResult在运行时工作正常，但我在尝试对它们进行单元测试时遇到了麻烦。

不幸的是，在代码下载中，Jimmy的自定义操作方法没有单元测试......这让我很奇怪。

我意识到action方法只返回ActionResult类型的实例及其实际调用ExecuteResult方法的MVC框架，当然在运行单元测试时它不可用。所以我的单元测试现在只是创建一个自定义ActionResult的实例，然后我调用ExecuteResult。

在我的自定义ActionResult的ExecuteResult方法中，它还调用了我传递给它的ViewResult的ExecuteResult方法。那时它爆炸了。我应该如何嘲笑/抄袭这些东西以使我的单元测试工作？

public class SendToAFriendActionResult : ActionResult
{

    public const string INVALID_CAPTCHA = "You don't appear to have filled out the two words from the security image correctly to prove you're a human. Please try again.";
    public const string INVALID_MODEL_STATE = "You don't appear to have filled out all the details correctly. Please try again.";
    public const string CONTACT_FAIL = "Unfortunately we experiend a problem sending the link. Please try again later.";
    public const string SEND_TO_A_FRIEND_FAIL_KEY = "ContactFail";

    private  RedirectResult _success;
    private  ViewResult _failure;
    private readonly SendToAFriendModel _model;
    private readonly bool _captchaValid;
    private readonly MessageBuilderServiceBase _mbs;

    public RedirectResult Success
    {
        get { return _success; }
        set { _success = value; }
    }

    public ViewResult Failure
    {
        get { return _failure; }
        set { _failure = value; }
    }

    public SendToAFriendActionResult(RedirectResult success, ViewResult failure, SendToAFriendModel model, bool captchaValid, MessageBuilderServiceBase mbs)
    {
        _success = success;
        _failure = failure;
        _model = model;
        _captchaValid = captchaValid;
        _mbs = mbs;
    }

    public override void ExecuteResult(ControllerContext context)
    {

        if (!_captchaValid)
        {
            Failure.TempData[SEND_TO_A_FRIEND_FAIL_KEY] = INVALID_CAPTCHA;

            // On reaching this point I receive the error
            // Object reference not set to an instance of an object
            // as the MVC framework calls FindView 
            Failure.ExecuteResult(context);
            return;
        }

        if (!context.Controller.ViewData.ModelState.IsValid)
        {
            Failure.TempData[SEND_TO_A_FRIEND_FAIL_KEY] = INVALID_MODEL_STATE;
            Failure.ExecuteResult(context);
            return;
        }

        _mbs.RecipientEmailAddress = _model.EmailRecipient;
        _mbs.SendersName = _model.SendersName;
        _mbs.Url = _model.URL;
        var result = _mbs.sendMessage();

        if (!result)
        {
            Failure.TempData[SEND_TO_A_FRIEND_FAIL_KEY] = CONTACT_FAIL;
            Failure.ExecuteResult(context);
            return;
        }

        Success.ExecuteResult(context);
    }
}

这是我单元测试的开始......

        IMessageService _emailMessageSerivce;
        IGalleryRepository _repository;

        var stfModel = new SendToAFriendModel
        {
            SendersName = "Someone",
            URL = "http://someurl.com",
            EmailRecipient = "a-friend@somewherelse.com"
        };

        var failure = new ViewResult() {ViewName ="SendToFriend"};
        const bool captchaValid = false;
        var fakeControlllerContext = MockRepository.GenerateStub<ControllerContext>(null);

        var stf = new SendToAFriendActionResult(null, failure, stfModel, captchaValid, null);
        stf.ExecuteResult(fakeControlllerContext);

我在SUT中发表评论以表明问题是否发生。

我知道我应该以某种方式抄袭/嘲笑，但我似乎无法解决这个问题。

Answer 1

来自 ASP.NET MVC 2 In Action （由Jimmy Bogard合着）：

通过采用难以测试的代码一个动作并将其放入执行动作结果的方法，你确保行动成为现实更容易进行单元测试。那是因为当你进行单元测试时动作，你断言行动的类型动作返回的结果和行动结果的状态。该执行动作结果的方法不作为单位的一部分执行测试

单元测试旨在隔离行为和顾虑。您可以通过从自定义Action中调用ExecuteResult来混淆问题。相反，我会让SendToAFriendActionResult返回实际的ActionResult（失败或成功）：

public ActionResult GetAction(..)
{
   ActionResult result;
   //logic here to determine which ActionResult to return
   return result;
}

在您的控制器中：

  public ViewResult SendToAFriend()
    {
       return SendToAFriendActionResult(null, failure, stfModel, captchaValid, null)
            .GetAction();
    }

此方法将允许MVC框架完成其工作并将这些问题隔离在自定义ActionResult之外。您的测试应断言，根据您设置的参数返回正确类型的操作，失败或成功。

如何对自定义动作结果进行单元测试

1 个答案: