无法在多线程中实现同步

时间:2015-12-13 05:32:33

标签: java multithreading synchronization java-threads

我基本上试图实现多人在线预订单程出租车的真实例子。在我的代码中,我有3个类 - 出租车,客户和服务器。
必须有多个客户(线程)和一个出租车。但是我无法做到这一点。每当我创建新客户时,都会创建一个新的出租车实例 这是出租车类代码 -

    public class taxi  {
        boolean BOOKED=false;
         String id;
        void book(){
            try {
                Thread.sleep(1000);
            } catch (InterruptedException e) {
                // TODO Auto-generated catch block
                e.printStackTrace();
            }
            BOOKED=true;
            System.out.println("Customer "+Thread.currentThread().getName()+" BOOKED taxi");
        }

        void release(){
            BOOKED=false;
            System.out.println("Customer "+Thread.currentThread().getName()+" RELEASED taxi");
        }

        void setId(String id){
            this.id=id;
        }

        String getId(){
            return id;
        }

    }

客户类代码 -

public class customer extends Thread {
     taxi t=new taxi();
        public  void run(){
            //System.out.println(t.hashCode());
            t.setId(Thread.currentThread().getName());
            System.out.println("Customer "+Thread.currentThread().getName()+" trying to BOOK taxi");
            t.book();
            System.out.println("Customer "+Thread.currentThread().getName()+" is currently USING taxi");

            try {


Thread.sleep(2000);
        } catch (InterruptedException e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
        }
        System.out.println("Customer "+Thread.currentThread().getName()+" RELEASING taxi");
        t.release();
        try {
            Thread.sleep(3000);
        } catch (InterruptedException e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
        }
        System.out.println("taxi used by customer "+Thread.currentThread().getName()+" set id to "+t.getId());
    }



}

服务器类代码 -

public class server {

public static void main(String args[]){

         customer A=new customer();
         customer B=new customer();
         customer C=new customer();
         customer D=new customer();
        Thread t=new Thread();
         A.setName("A");
         B.setName("B");
         C.setName("C");
         D.setName("D");

         A.start();
         B.start();
         C.start();
         D.start();




    }


    }


这是我的输出 -

Customer B trying to BOOK taxi
Customer D trying to BOOK taxi
Customer A trying to BOOK taxi
Customer C trying to BOOK taxi
Customer B BOOKED taxi
Customer A BOOKED taxi
Customer A is currently USING taxi
Customer D BOOKED taxi
Customer D is currently USING taxi
Customer B is currently USING taxi
Customer C BOOKED taxi
Customer C is currently USING taxi
Customer C RELEASING taxi
Customer C RELEASED taxi
Customer D RELEASING taxi
Customer D RELEASED taxi
Customer A RELEASING taxi
Customer A RELEASED taxi
Customer B RELEASING taxi
Customer B RELEASED taxi
taxi used by customer D set id to D
taxi used by customer C set id to C
taxi used by customer A set id to A
taxi used by customer B set id to B

你可以看到每辆出租车的ID不同而不是相同。
请帮忙。

3 个答案:

答案 0 :(得分:1)

我认为,出租车类不一定是一个线程。通过在所有其他客户线程中将出租车类作为共享资源(使用同步方法单吨),我们可以在多线程中实现预期的同步。

答案 1 :(得分:1)

有关您的代码的一些要点:

  1. 您应该只创建一个Taxi类的实例,并从Customer类中删除taxi实例变量,并在服务器类中实例化Taxi。
  2. 将您的客户类更改为共享出租车。您可以在Customer类中创建参数化构造函数以初始化共享出租车。
  3. 应该在方法书中调用setId,以便出租车的Id只能由想要预订出租车的线程改变。
  4. 您可以在Taxi类中以这种方式使用wait / notify机制来实现同步:

    public class Taxi {
        Boolean BOOKED = false;
        String id;
    
        void book() throws InterruptedException {
            synchronized (this) {
                while (BOOKED) {
                    this.wait();
                }
                try {
                    setId(Thread.currentThread().getName());
                } catch (InterruptedException e) {
                    e.printStackTrace();
                }
                BOOKED = true;
                System.out.println("Customer " + Thread.currentThread().getName() + " BOOKED taxi");
                try {
                    Thread.sleep(1000);
                } catch (InterruptedException e) {
                    // TODO Auto-generated catch block
                    e.printStackTrace();
                }
            }
        }
    
        void release() throws InterruptedException {
            synchronized (this) {
                BOOKED = false;
                System.out.println("Customer " + Thread.currentThread().getName() + " RELEASED taxi");
                this.notifyAll();
            }
        }
    
        void setId(String id) throws InterruptedException {
            System.out.println("SETTING ID TO CUSTOMER " + Thread.currentThread().getName());
            this.id = id;
        }
    
        String getId() {
            return id;
        }
    }
    

    客户:

       public class Customer extends Thread {
        Taxi taxi;
    
        public Customer(Taxi taxi){
            this.taxi = taxi;
        }
    
        public  void run(){
            //System.out.println(t.hashCode());
    
            System.out.println("Customer "+Thread.currentThread().getName()+" trying to BOOK taxi");
            try {
                taxi.book();
            } catch (InterruptedException e) {
                e.printStackTrace();
            }
            System.out.println("Customer "+Thread.currentThread().getName()+" is currently USING taxi");
    
            try {
                Thread.sleep(2000);
            } catch (InterruptedException e) {
                // TODO Auto-generated catch block
                e.printStackTrace();
            }
            System.out.println("Customer "+Thread.currentThread().getName()+" RELEASING taxi");
            try {
                taxi.release();
            } catch (InterruptedException e) {
                e.printStackTrace();
            }
            try {
                Thread.sleep(3000);
            } catch (InterruptedException e) {
                // TODO Auto-generated catch block
                e.printStackTrace();
            }
        }
    }
    

答案 2 :(得分:1)

为什么每次在客户中设置新的出租车?问题是:taxi t=new taxi();。只需通过构造函数通过出租车或使其全局或类似的东西。这样每个客户都会使用同一辆出租车。此外,线程是危险的,所以你应该非常小心它们。您没有任何同步。我建议你不明白如何正确使用线程。我建议您阅读synchronizevolatilewaitnotifynotifyAll,并尝试并尝试一些基本示例。我在Head First Java中很好地描述了前两个。 Offtopic:在命名变量和方法时应遵循惯例。