优化snmp库以在iphone中搜索设备的IP地址

时间:2015-12-10 00:45:37

标签: ios iphone swift sockets search

我在iPhone应用中使用Mobile snmp ++库(https://github.com/Zchander/mobile-snmp-plusplus/tree/master/Mobile%20SNMP%2B%2B)来使用swift语言扫描设备。

Mobile Snmp ++库是用Objective-C编写的,带有Bridging标头我可以在我的swift项目中使用这个库,它可以很好地工作。

我需要扫描来自特定范围的ip地址的设备 170.23.45.0至170.23.45.255。为此,我使用XISMobile_SNMP_PP.mm中的getoid函数https://github.com/Zchander/mobile-snmp-plusplus/blob/master/Mobile%20SNMP%2B%2B/XISMobile_SNMP_PP.mm

要从单个IP地址获得响应,每个响应大约需要1-2秒。为了减少时间,我使用多线程,如下面链接所示(最多20个线程仅在我们的时间将在iphone中使用该应用程序)从0到255完成扫描需要20秒。我需要将此时间缩短到大约5秒。 optimized way to search a device ip address within a range in iphone

问题:每次搜索开始时,getoid funtion都会打开套接字并发送数据,然后获得响应并关闭套接字。 那么我们不能保持套接字打开,扫描所有的IP地址并让它重新启动并最后关闭套接字?我需要将搜索时间从20秒减少到5秒,这样我们如何才能在getoid功能中完成。

- (NSDictionary *)getOid:(NSString *)oid
                 address:(NSString *)hostAddress
             snmpVersion:(uint)version
              remotePort:(NSNumber *)aPort
           withCommunity:(NSString *)community
                   retry:(uint)retries
                 timeout:(uint)timeout
                   error:(NSError * __autoreleasing*)error
{
    int status;

    uint l_retries;
    uint l_timeout;
    NSNumber *localPort;

    snmp_version snmpVersion = version1;
    OctetStr snmpCommunity([community UTF8String]);

    if ( aPort == nil ) {
        localPort = [NSNumber numberWithInteger:161];
    } else localPort = aPort;

    if ( retries > 100 ) {
        l_retries = 100;
    } else l_retries = retries;

    if ( timeout < 100 ) {
        l_timeout = 100;
    } else if ( timeout > 500 ) {
        l_timeout = 500;
    } else l_timeout = timeout;

    switch ( version ) {
        case 1:
            snmpVersion = version1;
            break;
        case 2:
            snmpVersion = version2c;
            break;
        default:
            snmpVersion = version1;
            break;
    }

    // Generate a SNMP++ generic address
    UdpAddress udpAddress([hostAddress UTF8String]);

    // Check if it is a valid address, if we got an invalid address
    // we return a 'nil' dictionary and an error code
    if ( !udpAddress.valid() ) {
        *error = [self constructError:ERR_INVALID_DESTINATION];
#ifdef DEBUG
        NSLog(@"ERROR SNMPController (getOid:hostAddress:oid:snmpVersion:remotePort:withCommunity:retry:timeout:error:)");
        NSLog(@"ERROR SNMP++ Invalid host address or IP: %@", hostAddress);
        NSLog(@"ERROR ====================");
#endif
        return nil;
    }

    // Check if we got a valid Oid, otherwise use sysDescr
    Oid localOid([oid UTF8String]);
    if ( !localOid.valid() ) {
#ifdef DEBUG
        NSLog(@"ERROR SNMPController (getOid:hostAddress:oid:snmpVersion:remotePort:withCommunity:retry:timeout:error:)");
        NSLog(@"ERROR SNMP++ We got an invalid Oid (%@), we are using sysDescr for now (.1.3.6.1.2.1.1.1.0)", oid);
        NSLog(@"ERROR ====================");
#endif
        Oid localOid("1.3.6.1.2.1.1.1.0");
    }

    // Create the SNMP session
    Snmp snmp(status, 0, (udpAddress.get_ip_version() == Address::version_ipv6));

    if ( status != SNMP_CLASS_SUCCESS ) {
#ifdef DEBUG
        NSLog(@"ERROR SNMPController (getOid:hostAddress:oid:snmpVersion:remotePort:withCommunity:retry:timeout:error:)");
        NSLog(@"ERROR SNMP++ Could not create session: %s", snmp.error_msg(status));
        NSLog(@"ERROR ====================");
#endif
        *error = [self constructError:ERR_NO_SNMP_SESSION];
        return nil;
    }

    // We are ready to build the SNMP++ object we need
    Pdu pdu;                                    // construct a Pdu object
    Vb vb;                                      // construct a Vb object
    vb.set_oid(localOid);                       // set the Oid portion of the Vb
    pdu += vb;                                  // add the vb to the Pdu

    // Set the port
    udpAddress.set_port([localPort integerValue]);
    CTarget ctarget(udpAddress);                // Make a target using the address

    ctarget.set_version(snmpVersion);           // Set the SNMP version
    ctarget.set_retry(l_retries);               // Set the number of retries
    ctarget.set_timeout(l_timeout);             // Set the timeout for the request
    ctarget.set_readcommunity(snmpCommunity);   // Set the read community name

    // Issue the request, in blocked mode
#ifdef DEBUG
    NSLog(@"DEBUG SNMPController (getOid:hostAddress:oid:snmpVersion:remotePort:withCommunity:retry:timeout:error:)");
    NSLog(@"DEBUG SNMP++ GET to %@ (oid: %@) with version %d on Port: %d using community %@ with retries %d and timeout %d", hostAddress, oid, version, [aPort integerValue], community, retries, timeout);
    NSLog(@"DEBUG SNMP++ What is the community we are sending.... %s", snmpCommunity.get_printable());
    NSLog(@"DEBUG ====================");
#endif

    SnmpTarget *target;
    target = &ctarget;

    status = snmp.get(pdu, *target);

    NSMutableDictionary *resultsDict = [[NSMutableDictionary alloc] init];

    if ( status == SNMP_CLASS_SUCCESS ) {
        pdu.get_vb(vb, 0);

#ifdef DEBUG
        NSLog(@"DEBUG SNMPController (getOid:hostAddress:oid:snmpVersion:remotePort:withCommunity:retry:timeout:error:)");
        NSLog(@"DEBUG SNMP++ -- Oid: %s", vb.get_printable_oid());
        NSLog(@"DEBUG SNMP++ -- Value: %s", vb.get_printable_value());
#endif

        // Add the result(s) to the resultsDict
        [resultsDict setObject:[NSString stringWithUTF8String:vb.get_printable_value()] forKey:[NSString stringWithUTF8String:vb.get_printable_oid()]];

        if ( (vb.get_syntax() == sNMP_SYNTAX_ENDOFMIBVIEW) ||
             (vb.get_syntax() == sNMP_SYNTAX_NOSUCHINSTANCE) ||
             (vb.get_syntax() == sNMP_SYNTAX_NOSUCHOBJECT)) {

            NSLog(@"ERROR SNMP++ Exception found: %lu", vb.get_syntax());

        } else {

            NSLog(@"ERROR SNMP++ GET Error: %s (%d)", snmp.error_msg(status), status);

        }
#ifdef DEBUG
        NSLog(@"DEBUG ====================");
#endif
    }

    // Make sure error is nil!

    *error = nil;

    return ( resultsDict != nil ) ? [NSDictionary dictionaryWithDictionary:resultsDict] : nil;

}

2 个答案:

答案 0 :(得分:3)

您收到的基础C ++库支持在收到响应时使用回调。如果更新Objective-C包装器以使用此方法而不是线程阻塞getOid函数,那么您将看到更好的性能,并且您只需要使用1或2个线程。

我看看

int Snmp::get(Pdu &pdu, const SnmpTarget &target, const snmp_callback callback, const void * callback_data)

uxsnmp.cpp中的

。您甚至可以将其包装以使用Obj-C块。那就是你要从中获得表现的地方。

只要您使用asyncronous库挂钩,就可以实现这样的大量SNMP-over-UDP查询,我使用Ruby的EventMachine以相同的方式进行DNS查询,从而获得了很好的结果 - 我在3-5秒内完成了~1500次查询!!

答案 1 :(得分:2)

在iOS中尝试Concurrency Programming以增加并发工作的数量。