避免重复调用相同的方法

Question

我正在为我的Java入门课程开发一个项目。我提交了我的代码，审稿人说我需要重写以下内容：

public void move()
   {
   if (iCanWin() > -1)
   {
       moveOnColumn(iCanWin()); 
   }
   else if (theyCanWin(0, 0, false) > -1)
   {
        moveOnColumn(theyCanWin(0, 0, false)); 
    else
   {
        moveOnColumn(brilliantMove()); 
   }
 }



int nextMove = iCanWin();
if(nextMove > -1) {
 moveOnColumn(nextMove);
} else ...

不确定在其他之后会发生什么......审稿人说这样可以避免重复调用相同的方法。

Answer 1

通常在声明中if-ifelse-else

  if (check a condition is true?)
 {
   moveOnColumn(iCanWin()); //do something
 }
 else if (other condition is true?) 
 {
    moveOnColumn(theyCanWin(0, 0, false)); //do something
  else//otherwise
  {
    moveOnColumn(brilliantMove());  //if previous condition doesn't be true
  almost one of them this line go to be execute
 }

Answer 2

尽可能删除重复的电话，如@ajb所述

public void move(){
    int nextMove = iCanWin();
    if (nextMove <= -1){
        nextMove = theyCanWin(0, 0, false);
        if(nextMove <= -1){
            nextMove = brilliantMove();
        }
    }
    moveOnColumn(nextMove); 
}