Question

我在我的网站上使用此脚本来显示在数据库中设置的随机图像，其中包含新的设置游戏编号。 set.php是保存数据库设置的地方。

<?php
@include_once('set.php');
$gamenum = fetchinfo("value","info","name","current_game")-1;
    $rs = mysql_query("SELECT * FROM `game".$gamenum."` GROUP BY `userid`");
    $i = 0;
    $crd = "";
    while($row = mysql_fetch_array($rs)) {
        $crd .= 'avatar.push(\''.$row["avatar"].'\');';
        $i++;
    }
echo '<script src="js/jquery.easing.1.3.js"></script>
<script>
    $(".stop-game").addClass("hidden");
    function getRandomInt(min, max) {
        return Math.floor(Math.random() * (max - min + 1)) + min;
    }
    var avatar=[]; 
    '.$crd.' 
    $( ".hhdgfbd" ).after( "<div id=\"hjgfd\" style=\"width: 1000px;margin: auto;overflow: hidden\"><div id=\"rouletbox\" style=\"height: 140px; width: 100%;  margin: auto\"><div class=\"roulet\"><div class=\"weaponline\" style=\"  margin-left: 330px\"></div><div class=\"mainbox\"><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img1\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img2\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img3\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img4\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img5\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img6\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img7\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img8\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img9\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img10\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img11\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img12\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img13\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img14\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img15\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img16\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img17\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img18\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img19\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img20\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img21\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img22\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img23\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img24\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img25\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img26\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img27\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img28\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img29\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img30\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img31\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img32\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img33\"></center></div></div><div class=\"weaponbox\" style=\"margin: 5px\"><div class=\"weaponheader\"><center><img style=\"width: 125px; height: 125px\" id=\"img34\"></center></div></div></div></div></div></div>");
    for(var i=1; i <= 34; i++) {
        var rand = getRandomInt(0,(avatar.length-1));
        $(\'#img\'+i).attr("src",avatar[rand]); 
        //alert(avatar[rand]);
    }';

$winner = fetchinfo("userid","games","id",$gamenum);
$avatar = fetchinfo("avatar","users","steamid",$winner);
echo '$(\'#img30\').attr("src","'.$avatar.'");'; 
echo '$(\'.mainbox\').css("margin-left",getRandomInt(-425,-5)+"px");
    setTimeout(function() {
        $(".mainbox").animate({marginLeft: getRandomInt(-3715,-3590)+"px"}, 7000, "easeOutExpo");
        audioElement3.play();
    },50);
    setTimeout(function() {
        $("#hjgfd").remove();
        roulet = 0;
    },10000);
</script>';
?>

但是每次它都会显示游戏编号的图像。我尝试了不同的东西，但我找不到解决方案。

Answer 1

您可以简化很多提取/字符串构建代码。它完全是冗余的，也容易受到JS等同的SQL注入攻击。

$crd = array();
while($row = mysql_fetch_array($rs)) {
    $crd[] = $row['avatar'];
}
... blah blah blah
var avatar = <?php echo json_encode($crd); ?>;

现在你直接创建了一个数组的字符串表示，而没有浪费cpu周期，一次一个地使用push（）操作构建数组，你也消除了这些的可能性{ {1}}值导致JS语法错误，如果他们不是数字而不是其他东西。

PHP随机图像与数据库

1 个答案: