"糟糕的地址"在调用execlp()时

时间:2015-11-03 18:35:15

标签: c exec

这是一个简单的程序,只会执行3个孩子。每个都将创建一个锁,读取一个文本文件,并取消锁定链接。如果正确执行,子进程将退出,其进程ID转换为8位。如果无法创建/取消链接锁定,程序将尝试n_try次,并在其间休眠一段时间。我是C的新手,并使用exec(),所以我不确定我的程序出了什么问题。第一个孩子正确执行但后面的任何事情都会返回Bad address。我所做的只是复制确切的代码。一些帮助将不胜感激。这三个参数是文本文件的名称,创建/取消链接锁的尝试次数以及尝试之间的休眠时间。谢谢!

父:

#include <stdio.h> 
#include <stdlib.h> 
#include <fcntl.h> 
#include <errno.h> 
#include <sys/types.h> 
#include <sys/wait.h> 
#include <unistd.h> 

void main(int argc, char *argv[]) { 
    pid_t childpid1, childpid2, childpid3; 
    char* fname = "lock"; 
    int fd, ret_val, status; 
    pid_t  w; 
    printf("I AM %d\n", (int)getpid());
    if ((childpid1 = fork()) == 0) { // If child 0 
        execlp("./proj3b", "./proj3b", argv[1], argv[2], argv[3], "0", "lock"); 
    } 
    printf("I AM %d FORKED CHILD %d\n", (int)getpid(), (int)childpid1); 
    while ((w = waitpid(childpid1, &status, 0)) && w != - 1) { 
        if (w != - 1) 
            printf ("Wait on PID: %d return status of: %04X\n", w, status); 
    } 
    unlink(fname); // Unlink the lock to make sure nothing is left.
    // End of child 1 
    printf("\nEND OF CHILD 0 \n\n"); 
    if ((childpid2 = fork()) == 0) { // If child 1 
        execlp("./proj3b", "./proj3b", argv[1], argv[2], argv[3], "1", "lock");
        perror("Exec failure"); // Exec failed if this line is reached.
        exit(-1);
    } 
    printf("I AM %d FORKED CHILD %d\n", (int)getpid(), (int)childpid2);
    while ((w = waitpid(childpid2, &status, 0)) && w != - 1) { 
        if (w != - 1) 
            printf ("Wait on PID: %d return status of: %04X\n", w, status); 
    } 

    unlink(fname); 
    printf("\nEND OF CHILD 1 \n\n");
} 

子:

#include <stdio.h> 
#include <stdlib.h> 
#include <fcntl.h> 
#include <errno.h> 
#include <sys/types.h> 
#include <sys/wait.h> 
#include <unistd.h> 

void main(int argc, char *argv[]) {
    char *text; 
    char *fname;
    int n_try, sleeptime, fd, k, ret_val, count = 0, status;
    pid_t pid;
    text = argv[1]; 
    n_try = atoi(argv[2]); 
    sleeptime = atoi(argv[3]); 
    k = atoi(argv[4]);
    fname = argv[5];
    pid = getpid(); 
    ret_val = (int) (pid % 256); 
    srand((unsigned) pid); 
    while ((fd = creat(fname, 0)) == -1 && errno == EACCES) { 
        if (++count < n_try) 
            sleep(rand()%sleeptime); 
        else { 
            printf ("\n Unable to generate.\n"); 
            kill(pid,0); 
        } 
    } 
    if (!fork()) 
        execlp("/bin/cat", "cat", text, (char *) 0); // Reading text 
    while (wait(&status) >= 0); 
    while (unlink(fname)!=0) 
        if (++count < n_try) 
            sleep(sleeptime); 
        else { 
            printf ("\n Cannot release file\n"); 
            exit(-1); 
        } 
    exit(ret_val);  
}

1 个答案:

答案 0 :(得分:1)

您正确终止了孩子中execlp的参数列表,但未终止父母的参数列表。