我正在开发一个从API中提取数据(JSON)的项目。我遇到的问题是内存正在慢慢增长,直到我遇到可怕的致命错误:
致命错误:*字节的允许内存大小耗尽(尝试过 分配*字节)在C:...行*
我认为不应该有任何记忆增长。我尝试在循环结束时取消所有内容,但没有区别。所以我的问题是:我做错了吗?这是正常的吗?我该怎么做才能解决这个问题?
<?php
$start = microtime(true);
$time = microtime(true) - $start;
echo "Start: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "<br/>";
include ('start.php');
include ('connect.php');
set_time_limit(0);
$api_key = 'API-KEY';
$tier = 'Platinum';
$threads = 10; //number of urls called simultaneously
function multiRequest($urls, $start) {
$time = microtime(true) - $start;
echo " start function: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "<br>";
$nbrURLS = count($urls); // number of urls in array $urls
$ch = array(); // array of curl handles
$result = array(); // data to be returned
$mh = curl_multi_init(); // create a multi handle
$time = microtime(true) - $start;
echo " Creation multi handle: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "<br>";
// set URL and other appropriate options
for($i = 0; $i < $nbrURLS; $i++) {
$ch[$i]=curl_init();
curl_setopt($ch[$i], CURLOPT_URL, $urls[$i]);
curl_setopt($ch[$i], CURLOPT_RETURNTRANSFER, 1); // return data as string
curl_setopt($ch[$i], CURLOPT_SSL_VERIFYPEER, 0); // Doesn't verifies certificate
curl_multi_add_handle ($mh, $ch[$i]); // Add a normal cURL handle to a cURL multi handle
}
$time = microtime(true) - $start;
echo " For loop options: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "<br>";
// execute the handles
do {
$mrc = curl_multi_exec($mh, $active);
curl_multi_select($mh, 0.1); // without this, we will busy-loop here and use 100% CPU
} while ($active);
$time = microtime(true) - $start;
echo " Execution: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "<br>";
echo ' For loop2<br>';
// get content and remove handles
for($i = 0; $i < $nbrURLS; $i++) {
$error = curl_getinfo($ch[$i], CURLINFO_HTTP_CODE); // Last received HTTP code
echo " error: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "<br>";
//error handling if not 200 ok code
if($error != 200){
if($error == 429 || $error == 500 || $error == 503 || $error == 504){
echo "Again error: $error<br>";
$result['again'][] = $urls[$i];
} else {
echo "Error error: $error<br>";
$result['errors'][] = array("Url" => $urls[$i], "errornbr" => $error);
}
} else {
$result['json'][] = curl_multi_getcontent($ch[$i]);
echo " Content: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "<br>";
}
curl_multi_remove_handle($mh, $ch[$i]);
curl_close($ch[$i]);
}
$time = microtime(true) - $start;
echo " after loop2: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "<br>";
curl_multi_close($mh);
return $result;
}
$gamesId = mysqli_query($connect, "SELECT gameId FROM `games` WHERE `region` = 'EUW1' AND `tier` = '$tier ' LIMIT 20 ");
$urls = array();
while($result = mysqli_fetch_array($gamesId))
{
$urls[] = 'https://euw.api.pvp.net/api/lol/euw/v2.2/match/' . $result['gameId'] . '?includeTimeline=true&api_key=' . $api_key;
}
$time = microtime(true) - $start;
echo "After URL array: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "<br/>";
$x = 1; //number of loops
while($urls){
$chunk = array_splice($urls, 0, $threads); // take the first chunk ($threads) of all urls
$time = microtime(true) - $start;
echo "<br>After chunk: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "<br/>";
$result = multiRequest($chunk, $start); // Get json
unset($chunk);
$nbrComplete = count($result['json']); //number of retruned json strings
echo 'For loop: <br/>';
for($y = 0; $y < $nbrComplete; $y++){
// parse the json
$decoded = json_decode($result['json'][$y], true);
$time = microtime(true) - $start;
echo " Decode: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "<br/>";
}
unset($nbrComplete);
unset($decoded);
$time = microtime(true) - $start;
echo $x . ": ". memory_get_peak_usage(true) . " | " . $time . "<br>";
// reuse urls
if(isset($result['again'])){
$urls = array_merge($urls, $result['again']);
unset($result['again']);
}
unset($result);
unset($time);
sleep(15); // limit the request rate
$x++;
}
include ('end.php');
?>
PHP Version 5.3.9 - 100循环:
loop: memory | time (sec)
1: 5505024 | 0.98330211639404
3: 6291456 | 33.190237045288
65: 6553600 | 1032.1401019096
73: 6815744 | 1160.4345710278
75: 7077888 | 1192.6274609566
100: 7077888 | 1595.2397520542
编辑:
在Windows上使用PHP 5.6.14 xampp尝试之后:
loop: memory | time (sec)
1: 5505024 | 1.0365679264069
3: 6291456 | 33.604479074478
60: 6553600 | 945.90159296989
62: 6815744 | 977.82566595078
93: 7077888 | 1474.5941500664
94: 7340032 | 1490.6698410511
100: 7340032 | 1587.2434458733
EDIT2:我只看到json_decode
Start: 262144 | 135448
After URL array: 262144 | 151984
After chunk: 262144 | 152272
start function: 262144 | 152464
Creation multi handle: 262144 | 152816
For loop options: 262144 | 161424
Execution: 3145728 | 1943472
For loop2
error: 3145728 | 1943520
Content: 3145728 | 2095056
error: 3145728 | 1938952
Content: 3145728 | 2131992
error: 3145728 | 1938072
Content: 3145728 | 2135424
error: 3145728 | 1933288
Content: 3145728 | 2062312
error: 3145728 | 1928504
Content: 3145728 | 2124360
error: 3145728 | 1923720
Content: 3145728 | 2089768
error: 3145728 | 1918936
Content: 3145728 | 2100768
error: 3145728 | 1914152
Content: 3145728 | 2089272
error: 3145728 | 1909368
Content: 3145728 | 2067184
error: 3145728 | 1904616
Content: 3145728 | 2102976
after loop2: 3145728 | 1899824
For loop:
Decode: 3670016 | 2962208
Decode: 4980736 | 3241232
Decode: 5242880 | 3273808
Decode: 5242880 | 2802024
Decode: 5242880 | 3258152
Decode: 5242880 | 3057816
Decode: 5242880 | 3169160
Decode: 5242880 | 3122360
Decode: 5242880 | 3004216
Decode: 5242880 | 3277304
答案 0 :(得分:4)
你的方法很长,所以我不相信垃圾收集在函数结束之前不会被触发,这意味着你未使用的变量可能会累积。如果它们不再被使用,那么垃圾收集将为您解决这个问题。
您可能会考虑将此代码重构为较小的方法以利用此功能,并考虑使用较小的方法所带来的所有其他好东西,但与此同时,您可以尝试将gc_collect_cycles();
放在最后你的循环,看看你是否可以释放一些记忆:
if(isset($result['again'])){
$urls = array_merge($urls, $result['again']);
unset($result['again']);
}
unset($result);
unset($time);
gc_collect_cycles();//add this line here
sleep(15); // limit the request rate
编辑:我更新的片段实际上并不属于大函数,但是我怀疑$result
的大小可能会使事情结束,并且在循环终止之前它不会被清除,可能。不过,这是值得一试的。
答案 1 :(得分:3)
所以我的问题是:我做错了吗?这是正常的吗?什么可以 我是为了解决这个问题吗?
是的,当你全部使用它时,内存不足是正常的。您正在请求10个同时发出的HTTP请求,并将JSON响应反序列化到PHP内存中。在不限制响应大小的情况下,您将始终面临内存不足的危险。
你还能做什么?
$threads
降低为1即可对此进行测试。如果C扩展中存在内存泄漏,则调用gc_collect_cycles()
将不释放任何内存,这只会影响Zend引擎中分配的内存,该内存不再可用。答案 2 :(得分:1)
所以我的问题是:我做错了吗?这是正常的吗?我该怎么做才能解决这个问题?
您的代码没有任何问题,因为这是正常行为,您从外部源请求数据,而外部源又被加载到内存中。
当然,解决问题的方法可以简单:
ini_set('memory_limit', -1);
允许使用所有内存。
当我使用虚拟内容时,请求之间的内存使用量保持不变。
这是在Windows上的XAMPP中使用PHP 5.5.19。
版本5.5.4中修复了cURL memory leak related bug
答案 3 :(得分:1)
我在10个URL上测试了你的脚本。我删除了所有注释,除了脚本末尾的一个注释和使用json_decode时问题循环中的一个注释。我还打开了一个你用API编码的页面,看起来非常大的数组,我认为你是对的,你在json_decode中有问题。
结果和修复。
结果没有变化:
代码:
for($y = 0; $y < $nbrComplete; $y++){
$decoded = json_decode($result['json'][$y], true);
$time = microtime(true) - $start;
echo "Decode: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "\n";
}
结果:
Decode: 3407872 | 2947584
Decode: 3932160 | 2183872
Decode: 3932160 | 2491440
Decode: 4980736 | 3291288
Decode: 6291456 | 3835848
Decode: 6291456 | 2676760
Decode: 6291456 | 4249376
Decode: 6291456 | 2832080
Decode: 6291456 | 4081888
Decode: 6291456 | 3214112
Decode: 6291456 | 244400
unset($decode)
的结果:
代码:
for($y = 0; $y < $nbrComplete; $y++){
$decoded = json_decode($result['json'][$y], true);
unset($decoded);
$time = microtime(true) - $start;
echo "Decode: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "\n";
}
结果:
Decode: 3407872 | 1573296
Decode: 3407872 | 1573296
Decode: 3407872 | 1573296
Decode: 3932160 | 1573296
Decode: 4456448 | 1573296
Decode: 4456448 | 1573296
Decode: 4980736 | 1573296
Decode: 4980736 | 1573296
Decode: 4980736 | 1573296
Decode: 4980736 | 1573296
Decode: 4980736 | 244448
您还可以添加gc_collect_cycles:
代码:
for($y = 0; $y < $nbrComplete; $y++){
$decoded = json_decode($result['json'][$y], true);
unset($decoded);
gc_collect_cycles();
$time = microtime(true) - $start;
echo "Decode: ". memory_get_peak_usage(true) . " | " . memory_get_usage() . "\n";
}
在某些情况下,它可以为您提供帮助,但在结果中可能会导致性能下降。
如果您在更改后遇到相同的问题,可以尝试使用unset
和unset+gc
重新启动脚本并在之前写一下。
另外我没看到你在哪里使用$decoded
变量,如果代码中有错误,你可以删除json_decode:)