CancellationToken.ThrowIfCancellationRequested not throw

时间:2015-09-12 21:04:48

标签: c# task cancellationtokensource cancellation-token

我编写了一个非常简单的应用程序来实现一些基于任务的异步操作。

客户端代码调用返回Task的方法。我将CancellationToken传递给该方法,但即使我在此过程中调用CancellationToken.ThrowIfCancellationRequested方法,取消也不会抛出OperationCancelledException。

如果您想自己测试,可以在此处下载整个解决方案: https://github.com/stevehemond/asynctap-example

以下是代码:

using System;
using System.Threading;
using System.Threading.Tasks;
using System.Windows.Forms;

namespace AsyncTapExample
{
    public partial class MainForm : Form
    {
        private const int totalSeconds = 5;

        private bool isStarted;

        public MainForm()
        {
            this.InitializeComponent();
        }

        private async void processingButton_Click(object sender, EventArgs e)
        {
            var cts = new CancellationTokenSource();

            if (!this.isStarted)
            {
                this.processingButton.Text = "Cancel";

                this.isStarted = true;

                var progressIndicator = new Progress<int>(this.ReportProgress);

                try
                {
                    await this.ProcessLongRunningOperationAsync(progressIndicator, cts.Token);

                    MessageBox.Show("Completed!");
                }
                catch (OperationCanceledException)
                {
                    MessageBox.Show("Cancelled!");
                }

                this.ResetUI();
            }
            else
            {
                cts.Cancel();
                this.processingButton.Text = "Start";
                this.isStarted = false;
            }
        }

        private void ResetUI()
        {
            this.progressBar.Value = 0;
            this.processingButton.Enabled = true;
            this.progressMessageLabel.Text = string.Empty;
            this.isStarted = false;
            this.processingButton.Text = "Start";
        }

        private Task ProcessLongRunningOperationAsync(IProgress<int> progress, CancellationToken ct)
        {
            return Task.Run(
                () =>
                    {
                        for (var i = 0; i <= totalSeconds; i++)
                        {
                            ct.ThrowIfCancellationRequested();

                            Thread.Sleep(1000);
                            progress?.Report((i * 100) / totalSeconds);
                        }
                    },
                ct);
        }

        private void ReportProgress(int progressPercentage)
        {
            this.progressBar.Value = progressPercentage;
            this.progressMessageLabel.Text = $"{progressPercentage}%";
        }
    }
}

对于将CancellationToken传递给任务,必定会有一些我不明白的事情......我无法弄清楚是什么。

1 个答案:

答案 0 :(得分:1)

您每次拨打CancellationTokenSource时都会创建processingButton_Click。结果,您从用于创建任务的内容中取消了不同的CancellationTokenSource。您应该只在创建新任务时创建新的CancellationTokenSource,并且应该保存CancellationTokenSource,以便取消它:

private CancellationTokenSource cts; //MainForm instance field

private async void processingButton_Click(object sender, EventArgs e)
{
    if (!this.isStarted)
    {
        this.cts = new CancellationTokenSource();

        this.processingButton.Text = "Cancel";

        this.isStarted = true;

        var progressIndicator = new Progress<int>(this.ReportProgress);

        try
        {
            await this.ProcessLongRunningOperationAsync(progressIndicator, this.cts.Token);

            MessageBox.Show("Completed!");
        }
        catch (OperationCanceledException)
        {
            MessageBox.Show("Cancelled!");
        }

        this.ResetUI();
    }
    else
    {
        this.cts.Cancel();
        this.processingButton.Text = "Start";
        this.isStarted = false;
    }
}