即使应用sqlite_close,sqlite3_finalize,我在sqlite3_open上也会出现内存泄漏,请指导我出错的地方。项目在非ARC。
-(BOOL)saveMedia:(NSDictionary *)details Download:(NSInteger)completed
{
//NSLog(@"media savemedia %@",[details objectForKey:@"type"]);
BOOL saved = FALSE;
NSInteger exists = [self findMedia:[details objectForKey:@"media_id"] playlist_id:[details objectForKey:@"playlist_id"] type:[details objectForKey:@"type"]];
sqlite3_stmt *statement;
self.databasePath = [self getDBPath];
const char *dbpath = [databasePath UTF8String];
if (sqlite3_open(dbpath, &wazzupco) == SQLITE_OK)
{
const char *query_stmt;
if (exists == 0)
{
query_stmt = "INSERT INTO media (media_id, title, description, file, views, thumbnail, version, playlist, playlist_id, author, created_at, type, playlist_created, timeout, playlist_order, media_order, playlist_promo_text, playlist_promo_url, playlist_promo_img,video_promo_text, video_promo_url, video_promo_img, dev_id, device_id, downloaded,slide_timeout) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)";
}
else if([[details objectForKey:@"version"] integerValue] > exists)
{
NSString *querySQL = [NSString stringWithFormat:@"UPDATE %@ SET media_id=?, title=?, description=?, file=?, views=?, thumbnail=?, version=?, playlist=?, playlist_id=?, author=?, created_at=?, type=?, playlist_created=?, timeout=?, playlist_order=?, media_order=?, playlist_promo_text=?, playlist_promo_url=?, playlist_promo_img=?,video_promo_text=?, video_promo_url=?, video_promo_img=?, dev_id=?, device_id=?, downloaded=?, slide_timeout=? WHERE media_id='%@' AND playlist_id='%@' AND type='%@'", TABLE_MEDIA, [details objectForKey:@"media_id"], [details objectForKey:@"playlist_id"], [details objectForKey:@"type"]];
query_stmt = [querySQL UTF8String];
}
else
{
//to make sure we won't update the database entry unless its a newer version
return FALSE;
}
sqlite3_prepare_v2(wazzupco, query_stmt, -1, &statement, NULL);
sqlite3_bind_text(statement, 1, [[details objectForKey:@"media_id"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 2, [[details objectForKey:@"title"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 3, [[details objectForKey:@"description"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 4, [[details objectForKey:@"file"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 5, [[details objectForKey:@"views"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 6, [[details objectForKey:@"thumbnail"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 7, [[details objectForKey:@"version"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 8, [[details objectForKey:@"playlist"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 9, [[details objectForKey:@"playlist_id"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 10, [[details objectForKey:@"author"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 11, [[details objectForKey:@"created_at"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 12, [[details objectForKey:@"type"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 13, [[details objectForKey:@"playlist_created"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 14, [[details objectForKey:@"timeout"] UTF8String], -1, NULL);
sqlite3_bind_int(statement, 15, [[details objectForKey:@"playlist_order"] intValue]);
sqlite3_bind_int(statement, 16, [[details objectForKey:@"media_order"] intValue]);
sqlite3_bind_text(statement, 17, [[details objectForKey:@"playlist_promo_text"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 18, [[details objectForKey:@"playlist_promo_url"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 19, [[details objectForKey:@"playlist_promo_img"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 20, [[details objectForKey:@"video_promo_text"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 21, [[details objectForKey:@"video_promo_url"] UTF8String], -1, NULL);
sqlite3_bind_text(statement, 22, [[details objectForKey:@"video_promo_img"] UTF8String], -1, NULL);
sqlite3_bind_int(statement, 23, [[details objectForKey:@"dev_id"] intValue]);
sqlite3_bind_text(statement, 24, [[details objectForKey:@"device_id"] UTF8String], -1, NULL);
sqlite3_bind_int(statement, 25, (int)completed);
sqlite3_bind_text(statement, 26, [[details objectForKey:@"slide_timeout"] UTF8String], -1, NULL);
if (sqlite3_step(statement) == SQLITE_DONE)
{
NSLog(@"media added. type:%@",[details objectForKey:@"type"]);
saved = TRUE;
}
sqlite3_finalize(statement);
//sqlite3_free(statement);
//sqlite3_reset(statement);
}
sqlite3_close(wazzupco);
if (completed != 0 && saved)
{
[self updateMediaStatus:[details objectForKey:@"file"] Download:1];
}
return saved;
}
在上面的代码中,我通过考虑数据是否已经存在,将数据从NSdictionary插入或更新到sqlite表。该方法执行正常,但它会产生严重的内存泄漏(该方法从循环中多次调用),当在Instrument中检查时,它显示泄漏位于if(sqlite3_open(dbpath,& wazzupco)== SQLITE_OK)。 / p>
来自仪器
泄露的对象:Malloc 64Bytes
地址 大小:1.12KB 责任图书馆:libsqlite3.dylib 负责框架:0x34bdce30
答案 0 :(得分:2)
当执行“else”情况时,似乎上述代码中的内存泄漏。
if (sqlite3_open(dbpath, &wazzupco) == SQLITE_OK)
{
const char *query_stmt;
if (exists == 0)
{
query_stmt = "INSERT INTO media (media_id, title, description, file, views, thumbnail, version, playlist, playlist_id, author, created_at, type, playlist_created, timeout, playlist_order, media_order, playlist_promo_text, playlist_promo_url, playlist_promo_img,video_promo_text, video_promo_url, video_promo_img, dev_id, device_id, downloaded,slide_timeout) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)";
}
else if([[details objectForKey:@"version"] integerValue] > exists)
{
NSString *querySQL = [NSString stringWithFormat:@"UPDATE %@ SET media_id=?, title=?, description=?, file=?, views=?, thumbnail=?, version=?, playlist=?, playlist_id=?, author=?, created_at=?, type=?, playlist_created=?, timeout=?, playlist_order=?, media_order=?, playlist_promo_text=?, playlist_promo_url=?, playlist_promo_img=?,video_promo_text=?, video_promo_url=?, video_promo_img=?, dev_id=?, device_id=?, downloaded=?, slide_timeout=? WHERE media_id='%@' AND playlist_id='%@' AND type='%@'", TABLE_MEDIA, [details objectForKey:@"media_id"], [details objectForKey:@"playlist_id"], [details objectForKey:@"type"]];
query_stmt = [querySQL UTF8String];
}
else
{
//to make sure we won't update the database entry unless its a newer version
return FALSE;
}
当触发else情况时,未到达sqlite3_close()并导致sqlite3_open内存泄漏
答案 1 :(得分:1)
抱歉,我不熟悉这些SQL Lite和非ARC项目经过一些谷歌搜索我找到了这个解决方案。我应该考虑将项目转换为ARC。 ARC将为您处理内存管理。打开ARC时,编译器将插入适当的内存管理语句,例如retain和release消息。最好使用ARC,因为编译器可以更好地了解对象的生命周期,并且不易出现人为错误
将非ARC项目转换为启用ARC的项目。本网站可能会帮助您Enable ARC