无法更新多线程代码中的属性

时间:2015-08-04 15:31:41

标签: java multithreading unit-testing thread-safety

我尝试编写此单元测试

@Test
public void setUserNamePropertyFromMultiThreadsUpdatesCorrectly() throws Exception {
    boolean oldVal = UsersConfig.s.NO_DB_MODE;
        final List<String> lastName = new ArrayList<String>();
        UsersConfig.s.NO_DB_MODE = true;

        String user1 = testUtils.generateUserName();
        final Long createdId = testUtils.createUserWithProperties(ImmutableMap.of("username", user1, "A", "A1",
                "isStaff", "true"));

        List<Callable<Void>> callables = new ArrayList<Callable<Void>>();
        for (int i = 0; i < 20; i++) {
            callables.add(new Callable<Void>() {
                @Override
                public Void call() throws Exception {
                    String user2 = testUtils.generateUserName();
                    boolean isSuccess = usersServerAccess.setProperties(createdId,
                            ImmutableMap.of("isStaff", "dont_know", "username", user2),
                            1, "test set", someTimeOut);
                    assertTrue(isSuccess);

                    synchronized (lastName) {
                        lastName.add(user2);
                    }
                    return null;
                }
            });

        ExecutorService executorService = Executors.newFixedThreadPool(10);
        try {
            executorService.invokeAll(callables);
            executorService.shutdown();
            executorService.awaitTermination(1, TimeUnit.MINUTES);
        } catch (InterruptedException e) {
            e.printStackTrace();
            throw new RuntimeException(e);
        }

        User returnedUser = usersServerAccess.getUser(createdId, "get test", someTimeOut);
        assertThat(returnedUser.getProperty("username"), equalTo(lastName.get(0)));
        assertThat(returnedUser.getProperty("A"), equalTo("A1"));
        assertThat(returnedUser.getProperty("isStaff"), equalTo("dont_know"));
}

然而我的测试失败了。

用户名不会更改。 你会加入&#34; sleep&#34; ?别的什么?

1 个答案:

答案 0 :(得分:0)

可能考虑采用不同的测试方法。您似乎正在尝试测试您的usersServerAccess类 - 专注于此类的单个单元测试(可能使用模拟框架,如Mockito)。通过此单元测试,您可以确保该类中的代码按预期工作。

你在这里尝试做的事情看起来像是一个多线程集成测试,这在最好的时候很棘手(@see Unit testing a multithreaded application?)。这段代码如何适合您的应用程序框架?也许考虑一下端到端测试框架,如JBehaveCucumber