在我的Rails应用中,我使用Rubocop
来检查问题。今天它给了我一个这样的错误:Assignment Branch Condition size for show is too high
。这是我的代码:
def show
@category = Category.friendly.find(params[:id])
@categories = Category.all
@search = @category.products.approved.order(updated_at: :desc).ransack(params[:q])
@products = @search.result.page(params[:page]).per(50)
rate
end
这是什么意思,我该如何解决?
答案 0 :(得分:85)
分配分支条件(ABC)大小是方法大小的度量。它主要取决于计算 A ssignments, B 大片和 C 条件语句的数量。 (more detail..)
要减少ABC大小,您可以将其中一些分配移动到before_action调用中:
before_action :fetch_current_category, only: [:show,:edit,:update]
before_action :fetch_categories, only: [:show,:edit,:update]
before_action :fetch_search_results, only: [:show,:edit,:update] #or whatever
def show
rate
end
private
def fetch_current_category
@category = Category.friendly.find(params[:id])
end
def fetch_categories
@categories = Category.all
end
def fetch_search_results
@search = category.products.approved.order(updated_at: :desc).ransack(params[:q])
@products = @search.result.page(params[:page]).per(50)
end