如何检查带有数组值列表的数组?

时间:2015-05-26 03:36:47

标签: python arrays python-2.7 tic-tac-toe

我正在尝试解决基于Rock Paper Scissors的编程挑战。我的目标是给出一系列游戏动作,确定游戏获胜的举动。我的问题是检查游戏是否赢了。我有一个获胜组合列表,例如游戏网格是:

1, 2, 3,
4, 5, 6,
6, 7, 8,

然后获胜组合将是例如:4, 5, 6,因为它是连续3个。

我的问题是我不知道如何有效地检查所有这些获胜组合。我试图制作一个获胜组合列表,然后运行游戏板来检查获胜者,这将是太棒了,只是它不起作用,我不知道如何合理地接近它。

这是我的代码:

def is_winner(grid):
    player1_wins = ['X','X','X']
    player2_wins = ['O','O','O']
    player_win = [player1_wins, player2_wins]

    win1 = [0,3,6] #[1,4,7]
    win2 = [1,4,7] #[2,5,8]
    win3 = [2,5,8] #[3,6,9]
    win4 = [0,4,8] #[1,5,9]
    win5 = [6,7,8] #[7,8,9]
    win6 = [3,4,5] #[4,5,6]
    win7 = [0,1,2] #[1,2,3]
    win8 = [6,7,8] #[7,8,9]
    winning_grids = [win1, win2, win3, win4, win5, win6, win7, win8]

    if any(grid[winning_grids]) == any(player_win): # !!!! Broken code here !!!!
        return True # Game won
    else:
        return False

def tic_tac_toe(games):
    for game in range(games):
        grid = ['1','2','3',
                '4','5','6',
                '7','8','9']
        moves = [int(x) for x in raw_input().split()]

        turn = 1
        for move in moves:
            if turn % 2 != 0:
                grid[move-1] = 'X'
            elif turn % 2 == 0:
                grid[move-1] = 'O'
            if is_winner(grid):
                print("Game over on turn %d" % turn)

        print(grid)
tic_tac_toe(input())

示例输入如下所示:

3
7 5 4 1 9 2 8 3 6
5 1 3 7 6 4 2 9 8
5 1 2 8 6 4 7 3 9

如果是3场比赛,则球员1排在第一位,球员2排在每位球的下一位数。

答案是:第1场比赛 - 第7场比赛 - 第2场比赛 - 第6场比赛,第3场比赛 - 比赛。 (尚未实施)

我可以做些什么来检查获胜的举动/有没有人对如何修复我的代码有任何建议?

2 个答案:

答案 0 :(得分:3)

我认为你需要的是使用一个班级。我本可以尝试修复你的代码,但我认为你需要完全重新考虑它。

从逻辑上讲,你可以把它分解成一个游戏对象,跟踪单个游戏的动作。您可以简单地移动,然后在每次移动后检查以确定游戏是否已赢得。

我不确定你是否熟悉课程,但我认为一个tic tac toe游戏更好地实现为一个对象。您还可以在许多其他场景中重用游戏类。不只是为了确定每场比赛的胜利。在复杂的程序中,您甚至可以将游戏对象传递给其他对象,以便它们可以以自己的方式与其进行交互。这超出了这个答案的范围,但希望你明白我的观点。

尝试下面的代码,我故意对它进行了大量评论,并使其(希望)易于理解。它很长,但它打破了每项任务,因此很容易理解正在发生的事情。 (至少对我而言)

您可以使用此代码中的概念来修复您的实现。要么使用我的代码中的一些部分来修复你的代码,要么只是使用我的版本。

使用此代码,游戏对象会跟踪它的转向,每个玩家所做的移动,游戏是否已赢,游戏是否结束,获胜玩家是谁,以及移动次数。

另外,我故意编写代码,以便它可以在Python 2.7和3.4上运行。通常,我尝试只为Python 3x编写,但这是我的偏好。

class TicTacToeGame:
    """
    A class that implements a tic tac toe game
    """

    # This is a class variable that contains
    # a list of all the winning combos
    winningCombos = [
        [1, 2, 3],
        [4, 5, 6],
        [7, 8, 9],
        [1, 4, 7],
        [2, 5, 8],
        [3, 6, 9],
        [1, 5, 9],
        [3, 5, 7]
    ]

    def __init__(self):
        """
        Init method. This gets called when you create a new game object
        We simply use this method to initialize all our instance variables
        """

        # The current player. Either X or O
        self.currentPlayer = 'X'

        # List of player x moves
        self.playerXMoves = []

        # List of player o moves
        self.playerOMoves = []

        # Whether or not the game has been won
        self.isWon = False

        # Whether or not the game is over
        self.isOver = False

        # The winning player
        self.winningPlayer = None

        # The number of moves played
        self.numberOfMovesPlayed = 0

    def doMakeAMoveAtPos(self, pos):
        """
        Makes a move in the game at the specified position
        1 is the first position, 5 is the center position, etc

        @param pos: The position (1 through 9)
        @type pos: int
        @rtype: None
        """

        # If the game has already been won
        if self.isWon:
            raise ValueError('The game has been won')

        # If the game is over, nobody won
        if self.isOver:
            raise ValueError('The game is a tie')

        # Make sure that the position is within range
        if pos < 1 or pos > 9:
            raise ValueError('Invalid position. Should be between 1 and 9')

        # Make sure the position isn't already taken
        if pos in self.playerXMoves or pos in self.playerOMoves:
            raise ValueError('The position: ' + str(pos) + ' is already taken')

        # Get the current player
        currentPlayer = self.currentPlayer

        # If the current player is X
        if currentPlayer == 'X':

            # Add the move and switch to player O
            currentPlayerMoves = self.playerXMoves
            currentPlayerMoves.append(pos)
            self.currentPlayer = 'O'

        # Otherwise, the current player is O
        else:

            # Add the move and switch to player X
            currentPlayerMoves = self.playerOMoves
            currentPlayerMoves.append(pos)
            self.currentPlayer = 'X'

        # Increment the number of plays.. You could just check the length of
        # playerXMoves and playerOMoves to get the total number of moves, but
        # we are going to keep track to avoid more code later
        self.numberOfMovesPlayed += 1

        # If the number of plays is 9, the game is over
        if self.numberOfMovesPlayed == 9:
            self.isOver = True

        # See if the game has been won

        # If there hasn't been enough moves to win yet, no winner
        if len(currentPlayerMoves) < 3:
            return

        # Iterate through each winning combo
        for winningCombo in self.winningCombos:

            # If each number is in the player's moves, the game has been won
            if set(winningCombo) <= set(currentPlayerMoves):

                self.isWon = True
                self.winningPlayer = currentPlayer
                return



# OK... Our Class has been defined.
# Now it's time to play tic tac toe.

# Define an input string. How you get this is up to you
# Change this to different numbers to see what you get.
inputString = '3 7 5 4 1 9 2 8 3 6 5 1 3 7 6 4 2 9 8 5 1 2 8 6 4 7 3 9'

# Parse the input string into a list of integers
moves = [int(move) for move in inputString.split()]

# Create the initial game
game = TicTacToeGame()

# Set the number of games to 1 (This is the first game after all)
numberOfGames = 1

# Go through all the moves 1 by 1
for pos in moves:

    # Try to make a move in the current game
    try:
        game.doMakeAMoveAtPos(pos)

    # But, since the input is unpredictable, we need to catch errors
    # What's to stop the input from being '1 1 1 1 1 1 1 1 1', etc
    # You can't keep playing position number 1 over and over
    except ValueError as exc:

        # Do what you want with the exception.
        # For this example, I'm just gonna print it
        # and move on the the next move
        print(exc)
        continue

    # If the game has been won
    if game.isWon:
        print('Game ' + str(numberOfGames) + ' Won On Move: ' + str(game.numberOfMovesPlayed) + ' Winning Player: ' + str(game.winningPlayer))

        # Since the game was won, create a new game
        game = TicTacToeGame()

        # And increment the game number
        numberOfGames += 1

    # If the game is a tie
    elif game.isOver:
        print('Game ' + str(numberOfGames) + ' Tie')

        # Since the game was a tie, create a new game
        game = TicTacToeGame()

        # And increment the game number
        numberOfGames += 1

# If there is an unfinished game, we can report this as well
if game.numberOfMovesPlayed > 0:
    print('Game ' + str(numberOfGames) + ' was not finished')

可以做很多改进,但是你明白了(我希望)当我运行这段代码时,我得到以下输出:

Game 1 Won On Move: 7 Winning Player: X
The position: 3 is already taken
Game 2 Won On Move: 6 Winning Player: O
The position: 2 is already taken
The position: 8 is already taken
The position: 6 is already taken
The position: 4 is already taken
Game 3 Won On Move: 9 Winning Player: X
Game 4 was not finished

答案 1 :(得分:2)

@RayPerea做出了很好的回答。但是如果您不能按照您的要求使用课程或者根本不想使用课程,我会采用不同的方法。

这篇文章背后的想法是展示python的功能方面。 “功能”编程的一个主要概念是您无法访问函数的外部范围。我通过将player_oneplayer_two添加到全局命名空间来欺骗。但它很容易转化为100%功能代码。这是一个good tutorial

这个代码可以在python 2和3上运行。

唯一要做的就是将保存的输入更改为实际输入。

player_one = 'X'
player_two = 'O'

# You can add "HAZ THE MOVEZ" joke here:
def has_the_moves(player, moves):
    if len(moves) <= 2:
        return None

    win1 = (0,3,6) #[1,4,7]
    win2 = (1,4,7) #[2,5,8]
    win3 = (2,5,8) #[3,6,9]
    win4 = (0,4,8) #[1,5,9]
    win5 = (6,7,8) #[7,8,9]
    win6 = (3,4,5) #[4,5,6]
    win7 = (0,1,2) #[1,2,3]
    win8 = (6,7,8) #[7,8,9]
    winning_grids = [win1, win2, win3, win4, win5, win6, win7, win8]

    # We will return a player name (not bool) if he is a winner.
    # This name will be used later.
    tried = [set(posibility) <= set(moves) for posibility in winning_grids]
    return player if any(tried) else None

def is_winner(grid):

    player_one_moves = [i for i, x in enumerate(grid) if x == player_one]
    player_two_moves = [i for i, x in enumerate(grid) if x == player_two]

    player_one_won = has_the_moves(player_one, player_one_moves)
    player_two_won = has_the_moves(player_two, player_two_moves)

    # If we a have a winner:
    if player_one_won or player_two_won:
        return player_one_won if player_one_won else player_two_won

    return None

def end_game(winner=None, last_turn=False):
    """ This function can be used when you find a winner,
    or when the end of the game is reached. 
    """
    if last_turn:
        print('Game ended in a draw.')
    if winner:
        print('Player {} won.'.format(winner))

def tic_tac_toe(games):

    # For testing purposes let's save user's input:
    saved_moves = ['7 5 4 1 9 2 8 3 6', '5 1 3 7 6 4 2 9 8', '5 1 2 8 6 4 7 3 9']

    for game in range(games):
        grid = [str(x) for x in range(1, 10)] # one-liner
        moves = [int(x) for x in saved_moves[game].split()] # TODO: make sure to change saved_moves[game]

        for turn, move in enumerate(moves):
            grid[move - 1] = player_one if turn % 2 == 0 else player_two

            # Stop the game?
            winner = is_winner(grid)
            if winner:
                print('Game over on turn {}.'.format(turn + 1))
                end_game(winner=winner)
                break; # no more iterations required.
            if turn == len(moves) - 1:
                end_game(last_turn=True)

if __name__ == '__main__':
    # We running 3 games:
    saved_games_number = 3
    tic_tac_toe(saved_games_number)

结果是:

Game over on turn 7.
Player X won.
Game over on turn 6.
Player O won.
Game ended in a draw.