如何避免冗余和冗长的if-else结构?

时间:2015-05-25 17:48:58

标签: python

编写此代码是否有更简单,更有效的方法?这是一个计算吸烟成本的计算器。

必须有一种方法可以跳过所有ifelif标记,并将其转换为循环并节省几分钟的代码输入,甚至可能存在“标准”如何输入我错过的代码。

how_many = int(input('How many ciggaretes do you smoke each day?\n'))

per_package = int(input('How much does your package cost?\n'))

contain = int(input('How many ciggaretes does the package contain?\n'))

cost_st = per_package / contain

choice = input('Do you want to calculate the cost per "Day (D)" / "Week (W)" / "Year (Y)" / "Decade (DE)"?\n')

if choice == 'D':
    cost_day = cost_st * how_many
    print("It will cost", cost_day ,"kr per day.")

elif choice == 'W':
    cost_week = (cost_st * how_many) * 7
    print('It will cost', cost_week,'kr per week.') 

elif choice == 'Y':
    cost_year = (cost_st * how_many) * 365
    print('It will cost' ,cost_year, 'kr per year.')

elif choice == 'DE':
    cost_DE = ((cost_st * how_many) * 365) * 10
    print('It will cost' ,cost_DE, 'kr per decade.')

else:
    print('Something went wrong! Try again please.') 

1 个答案:

答案 0 :(得分:7)

您可以使用字典和预定义函数:

mappings = {'D': 1, 'W': 7, 'Y': 365, 'DE': 3650}

def calculate_cigarettes(arg):
    cost = cost_st * how_many * mappings[arg]
    print('It will cost', cost, 'kr total.')