我正在尝试与ABAddressBook进行交互,但在分析Xcode中的代码时,我有一些内存泄漏警告,我无法解决。我收到警告“物体的潜在泄漏”和“存储在'allContacts'中的物体的潜在泄漏”
+ (void)addNewContact:(BusinessCard *)contact {
ABAddressBookRef addressBookRef = ABAddressBookCreateWithOptions(NULL, nil);
ABRecordRef newContact = ABPersonCreate();
if (contact.firstName) ABRecordSetValue(newContact, kABPersonFirstNameProperty, (__bridge CFStringRef)contact.firstName, nil);
if (contact.familyName) ABRecordSetValue(newContact, kABPersonLastNameProperty, (__bridge CFStringRef)contact.familyName, nil);
if (contact.company) ABRecordSetValue(newContact, kABPersonOrganizationProperty, (__bridge CFStringRef)contact.company, nil);
if (contact.jobTitle) ABRecordSetValue(newContact, kABPersonJobTitleProperty, (__bridge CFStringRef)contact.jobTitle, nil);
if (contact.emailAddress) {
ABMutableMultiValueRef multiEmail = ABMultiValueCreateMutable(kABMultiStringPropertyType);
ABMultiValueAddValueAndLabel(multiEmail, (__bridge CFTypeRef)(contact.emailAddress), kABWorkLabel, NULL);
ABRecordSetValue(newContact, kABPersonEmailProperty, multiEmail, NULL);
CFRelease(multiEmail);
}
if (contact.details) ABRecordSetValue(newContact, kABPersonNoteProperty, (__bridge CFStringRef)contact.details, nil);
if (contact.phone) {
ABMutableMultiValueRef phoneNumbers = ABMultiValueCreateMutable(kABMultiStringPropertyType);
ABMultiValueAddValueAndLabel(phoneNumbers, (__bridge CFStringRef)contact.phone, kABPersonPhoneMainLabel, NULL);
ABRecordSetValue(newContact, kABPersonPhoneProperty, phoneNumbers, nil);
CFRelease(phoneNumbers);
}
ABAddressBookAddRecord(addressBookRef, newContact, nil);
CFRelease(newContact);
NSArray *allContacts = (__bridge NSArray *)ABAddressBookCopyArrayOfAllPeople(addressBookRef);
for (id record in allContacts){
ABRecordRef thisContact = (__bridge ABRecordRef)record;
if (CFStringCompare(ABRecordCopyCompositeName(thisContact), ABRecordCopyCompositeName(newContact), 0) == kCFCompareEqualTo){
[[[UIAlertView alloc] initWithTitle:NSLocalizedString(@"Existing contact", @"Title for alert view when adding an existing contact") message:NSLocalizedString(@"A contact already exists with the same name. Do you want to add the new contact?", @"Message for alert view when adding an existing contact")
cancelButtonItem:[RIButtonItem itemWithLabel:NSLocalizedString(@"No", @"No")]
otherButtonItems:[RIButtonItem itemWithLabel:NSLocalizedString(@"Yes", @"Yes") action:^{
[self saveInAddressBook:addressBookRef];
}], nil] show]; //Potential leak of an object
NSLog(@"Contact exists");
return;
}
}
[self saveInAddressBook:addressBookRef]; //Potential leak of an object stored into 'allContacts'
CFRelease(addressBookRef);
NSLog(@"Contact created");
}
+ (void)saveInAddressBook:(ABAddressBookRef)addressBookRef {
ABAddressBookSave(addressBookRef, nil);
[[[UIAlertView alloc] initWithTitle:NSLocalizedString(@"Contact added", @"Title for alert view when contact is successfully added to address book") message:nil delegate:nil cancelButtonTitle:NSLocalizedString(@"OK", @"OK") otherButtonTitles:nil] show];
}
有谁知道如何解决这些问题?
答案 0 :(得分:2)
你忘记了
CFRelease((__bridge CFTypeRef) allContacts);
我认为你可以这样说:
for (id record in allContacts){
...
}
CFRelease((__bridge CFTypeRef) allContacts);
[self saveInAddressBook:addressBookRef]; //Potential leak of an object stored into 'allContacts'
CFRelease(addressBookRef);
NSLog(@"Contact created");
答案 1 :(得分:0)
你可以继续使用APAddressBook,这是一个非常好的Addressbook框架。
或者通常帮我修复与Addressbook相关的崩溃的流程是遵循XCode建议的优化
在XCode goto产品中 - >分析
完成后你必须看到几个问题。