Question

I have written the following function in my C program. The program loads a text file (Les Miserables Vol. I) as well as another text file of 20 of the characters names. The purpose of this function is to scan the entire file, line by line, and count the number of times any of the 20 names appear.

NumOfNames = 20.

Names is an array of the 20 names stored from Names[1] - Names[20].

MaxName is a global integer variable which I would like to store the total number of name appearances throughout the file (It should be in the hundreds or even thousands).

EDIT: After the function is executed, the value of MaxName is 4. I am completely lost as to where I have made a mistake, but it appears that I have made several mistakes throughout the function. One seems to be that it only executed the first iteration of the for loop i.e. it only searches for Name[1], however the first name appears 196 times in the file, so it still isnt even working correctly for just the first name.

void MaxNameAppearances()
{
    char LineOfText[85];
    char *TempName;
    FILE *fpn = fopen(LesMisFilePath, "r+");

    for(i = 1; i<=NumOfNames; i++)
    {
        while(fgets(LineOfText, sizeof(LineOfText), fpn))
        {
            TempName = strstr(LineOfText, Names[i]);

            if(TempName != NULL)
            {
                MaxName++;
            }
        }
    }

    fclose(fpn);
}

Answer 1

I guess that one problem of the code is that it would have to read the file upon every iteration of i. Try to re-order the loops like this:

while(fgets(LineOfText, sizeof(LineOfText), fpn))
{
    for(i = 1; i<=NumOfNames; i++)
    {
        TempName = strstr(LineOfText, Names[i]);
        if(TempName != NULL)
        {
            MaxName++;
        }
    }
}

This reads a line, checks the occurrances of all names in that line and then goes on to the next line.

If you do it your way, you will be at the end of file for i == 1 already.

Where am I going wrong in getting this function to do what I would like?

1 个答案: