JSLint:如何不在循环中创建THIS函数

时间:2015-04-12 08:38:07

标签: javascript jslint

在我的角度应用程序中,我使用循环在对象中找到与给定数字最接近的值并返回其键。

例如,我希望最接近的值为0.5:

for (var j in nums) {
      if (0.5 > nums[j]) var prev = nums[j];
      else if (0.5 <= nums[j]) {
        // If the current number is equal to 0.5, or immediately higher, stores that number
        // and stops the for each() loop
        var next = nums[j];
        // Get the value
        var percentage = (Math.abs(0.5 - prev) < Math.abs(next - 0.5)) ? prev : next;
        // Get the key from the value
        $scope.seventyfive = parseInt('0' + Object.keys(nums).filter(function(key) {return nums[key] === percentage;})[0], 10);
        break;
      }
    }

JSLint指出我不应该在循环中创建函数,所以我试图避免使用:

filterPct = function (nums, pct) {
      return function () {
        return nums[key] === pct;
      };
    }

for (var j in nums) {
      if (0.5 > nums[j]) var prev = nums[j];
      else if (0.5 <= nums[j]) {
        // If the current number is equal to 0.5, or immediately higher, stores that number
        // and stops the for each() loop
        var next = nums[j];
        // Get the value
        var percentage = (Math.abs(0.5 - prev) < Math.abs(next - 0.5)) ? prev : next;
        // Get the key from the value
        $scope.seventyfive = parseInt('0' + Object.keys(nums).filter(filterPct(nums, percentage))[0], 10);
        break;
      }
    }

但这是返回0而不是正确的值。我很肯定我错过了一些明显的东西,但我显然需要另外一双眼睛......

更新:感谢我收到的支持,这是上述代码的防错版本:

filterPct = function (nums, pct) {
      return function (key) {
        return nums[key] === pct;
      };
    };

    // Store the value with 50% Confidence
    for (i in nums) {
      if (nums.hasOwnProperty(i)) {
        if (0.5 > nums[i]) {
          prev = nums[i];
        } else if (0.5 <= nums[i]) {
          // If the current number is equal to 0.5, or immediately higher, stores that number
          // and stops the for each() loop
          next = nums[i];
          // Get the value
          percentage = (Math.abs(0.5 - prev) < Math.abs(next - 0.5)) ? prev : next;
          // Get the key from the value
          $scope.fifty = parseInt('0' + Object.keys(nums).filter(filterPct(nums, percentage))[0], 10);
          break;
        }
      }
    }

1 个答案:

答案 0 :(得分:1)

filterPct = function (nums, pct) {
    return function () {
        return nums[key] === pct;
    };
}

你忘了定义key(它应该是内部函数的第一个参数)。