我有问题,我必须缩短我的代码。 代码:
IF @result_var = @expected_value
BEGIN
INSERT INTO reports.consistencycheckhistory VALUES
(
Getdate(),
@rule_guid,
'Ok',
@result_var
)
IF CONVERT(DATE,@check_time) <> CONVERT(DATE, Sysdatetime())
BEGIN
UPDATE reports.consistencycheckrules
SET ok_days_count =@ok_days_count + 1 ,
last_check_time=@check_time
where rule_guid=@rule_guid
END
END
ELSE
BEGIN
INSERT INTO reports.consistencycheckhistory VALUES
(
Getdate(),
@rule_guid,
'Error',
@result_var
)
UPDATE reports.consistencycheckrules
SET ok_days_count=0,
last_check_time=@check_time
WHERE rule_guid=@rule_guid
END
我的老板说的只有1次插入和1次更新,但我不知道是否有可能。
答案 0 :(得分:1)
IF @result_var = @expected_value
BEGIN
SET @Status = 'Ok'
END
ELSE
BEGIN
SET @Status = 'Error'
END
IF CONVERT(DATE,@check_time) <> CONVERT(DATE, Sysdatetime())
BEGIN
SET @ok_days_count = @ok_days_count + 1;
END
ELSE
BEGIN
SET @ok_days_count = 0;
END
INSERT INTO reports.consistencycheckhistory VALUES
(
Getdate(),
@rule_guid,
@Status,
@result_var
)
UPDATE reports.consistencycheckrules
SET ok_days_count = @ok_days_count ,
last_check_time=@check_time
where rule_guid=@rule_guid
答案 1 :(得分:0)
您可以在insert和update中使用case语句。并不是说它会让你更容易理解,而是会让你的老板满意。愿望。
答案 2 :(得分:0)
试试这个(可能需要一些调整):
INSERT INTO reports.consistencycheckhistory
VALUES
(
Getdate(),
@rule_guid,
CASE
WHEN @result_var = @expected_value
then 'Ok'
ELSE 'Error"
END,
@result_var
)
UPDATE reports.consistencycheckrules
SET
ok_days_count =@ok_days_count +
CASE
WHEN CONVERT(DATE,@check_time) <> CONVERT(DATE,Sysdatetime())
then 1
ELSE
0
END,
last_check_time=@check_time
where rule_guid=@rule_guid
答案 3 :(得分:0)
在查询中,您可以不必更新列,即@result_var = @expected_value和CONVERT(DATE,@ check_time)= CONVERT(DATE,Sysdatetime())
DECLARE @Should_Update bit
SET @Should_Update=0
IF @result_var = @expected_value
BEGIN
SET @Status = 'Ok'
END
ELSE
BEGIN
SET @Status = 'Error'
END
IF(@result_var = @expected_value)
BEGIN
IF CONVERT(DATE,@check_time) <> CONVERT(DATE, Sysdatetime())
BEGIN
SET @Should_Update=1
SET @ok_days_count = @ok_days_count + 1;
END
END
ELSE
BEGIN
SET @Should_Update=1
SET @ok_days_count = 0;
END
INSERT INTO reports.consistencycheckhistory VALUES
(
Getdate(),
@rule_guid,
@Status,
@result_var
)
UPDATE reports.consistencycheckrules
SET ok_days_count = @ok_days_count ,
last_check_time=@check_time
where rule_guid=@rule_guid AND @Should_Update=1
答案 4 :(得分:0)
IF @result_var = @expected_value
BEGIN
SET @Status = 'Ok'
END
ELSE
BEGIN
SET @Status = 'Error'
END
IF @Status = 'Ok'
BEGIN
IF CONVERT(DATE, @check_time) <> CONVERT(DATE, Sysdatetime())
BEGIN
SET @ok_days_count = @ok_days_count + 1;
END
ELSE
BEGIN
@ok_days_count=@ok_days_count
END
end
ELSE
BEGIN
SET @ok_days_count = 0;
end
INSERT INTO reports.consistencycheckhistory VALUES
(
Getdate(),
@rule_guid,
@Status,
@result_var
)
UPDATE reports.consistencycheckrules
SET ok_days_count = @ok_days_count,
last_check_time = @check_time
WHERE rule_guid = @rule_guid
这似乎是正确答案