我有这个代码运行超过5倍的crossvalidaiton,代码在每个折叠上做同样的事情,但问题是;它消耗每个折叠的内存可交换,它似乎不释放内存,你能指出我的问题所在吗? 我得到的错误是:
在抛出'std :: bad_alloc'实例后终止调用 what():std :: bad_alloc ./run.sh:line 3:12014 aborted
(核心倾销)./my-boost
代码是:
#include <iostream>
#include <boost/dynamic_bitset.hpp>
#include <vector>
#include <fstream>
using namespace::std;
struct point {
float fpr;
float tpr;
point(float x, float y)
{
fpr = x;
tpr = y;
}
};
float** combine_crisp(boost::dynamic_bitset<unsigned char> label, boost::dynamic_bitset<unsigned char> r_1, boost::dynamic_bitset<unsigned char> r_2, vector<int> fun)
{
int k = 0;
boost::dynamic_bitset<unsigned char> r_12;
const int LENGTH = (int) fun.size();
float **FprTpr;
FprTpr = new float*[LENGTH];
int P = (int) label.count();
int N = (int) (~label).count();
boost::dynamic_bitset<unsigned char> notlabel(~label);
for(vector<int>::iterator it = fun.begin(); it != fun.end(); ++it)
{
FprTpr[k] = new float[2];
if (*it == 1) //----------------> 'A AND B'
{
r_12 = r_1 & r_2;
}
else if(*it == 2) //---------------> 'NOT A AND B'
{
r_12 = ~r_1 & r_2;
}
else if(*it == 3) //----------------> 'A AND NOT B'
{
r_12 = r_1 & ~r_2;
}
else if(*it == 4) //----------------> 'A NAND B'
{
r_12 = ~(r_1 & r_2);
}
else if(*it == 5) //----------------> 'A OR B'
{
r_12 = r_1 | r_2;
}
else if(*it == 6) //----------------> 'NOT A OR B'; 'A IMP B'
{
r_12 = ~r_1 | r_2;
}
else if(*it == 7) //----------------> 'A OR NOT B' ;'B IMP A'
{
r_12 = r_1 | ~r_2;
}
else if(*it == 8) //----------------> 'A NOR B'
{
r_12 = ~(r_1 | r_2);
}
else if(*it == 9) //----------------> 'A XOR B'
{
r_12 = r_1 ^ r_2;
}
else if(*it == 10) //----------------> 'A EQV B'
{
r_12 = ~(r_1 ^ r_2);
}
FprTpr[k][0] = (r_12 & notlabel).count() / (float)N;
FprTpr[k][1] = (r_12 & label).count() / (float)P;
k++;
}
return FprTpr;
}
int main(int argc, char* argv[])
{
std::string inputFile;
std::string outputFile;
int first_classifier = 0;
for (int fo = 1; fo <= 5; fo++)
{
inputFile = "./vectors.txt";
outputFile += "./bccpoints.txt";
std::ifstream infileFirst(inputFile);
boost::dynamic_bitset<unsigned char> label;
std::vector<boost::dynamic_bitset<unsigned char> > classifiers;
std::string line;
int numberOfClassifiers = -1;
int lenOfClassifiers = -1;
while (std::getline(infileFirst, line))
{
if (numberOfClassifiers == -1)
{
lenOfClassifiers = (int)std::string(line).length();
label = boost::dynamic_bitset<unsigned char> (line);
}
else
{
classifiers.push_back(boost::dynamic_bitset<unsigned char> (line));
}
numberOfClassifiers++;
}
static const int arr[] = {1,2,3,4, 5,6,7,8,9,10};
vector<int> fun (arr, arr + sizeof(arr) / sizeof(arr[0]) );
static const int BOOLEANSIZE = fun.size();
int NUMBER = numberOfClassifiers;
float **rs_tmp;
vector<point> current_points;
for (int i = first_classifier; i < NUMBER; i++)
{
for (int j = 0; j < NUMBER; j++)
{
rs_tmp = combine_crisp(label, classifiers[i], classifiers[j], fun);
for (int kk = 0; kk < BOOLEANSIZE; kk++) //creating row
{
current_points.push_back( point(rs_tmp[kk][0], rs_tmp[kk][1] ) );
// current_points.push_back ({rs_tmp[kk][0], rs_tmp[kk][1]});
}
}
}
delete[] rs_tmp;
ofstream files;
files.open (outputFile);
files.write(reinterpret_cast<char*>(current_points.data()), current_points.size() * sizeof(point));
std::vector<boost::dynamic_bitset<unsigned char> >().swap(classifiers);
std::vector<point>().swap(current_points);
}
}
答案 0 :(得分:2)
请在以下代码中找到删除电话,
for (int i = first_classifier; i < NUMBER; i++)
{
for (int j = 0; j < NUMBER; j++)
{
rs_tmp = combine_crisp(label, classifiers[i], classifiers[j], fun);
for (int kk = 0; kk < BOOLEANSIZE; kk++) //creating row
{
current_points.push_back( point(rs_tmp[kk][0], rs_tmp[kk][1] ) );
// current_points.push_back ({rs_tmp[kk][0], rs_tmp[kk][1]});
}
int size = fun.size();
for(int i = 0; i < size; ++i) // Iterate over each item in the array
{
delete[] rs_tmp[i]; // free the float array of size 2 you created in the other function
}
delete[] rs_tmp; // finally delete the float* array of size - fun.size()
}
}
答案 1 :(得分:1)
delete[] rs_tmp
仅删除指向float
变量指针的指针,而不是指向float
的指针。你的很多记忆都被分配了,最后扔了std::bad_alloc
。因此,您需要正确释放已分配的内存。