如何修复这些JSLint错误?

时间:2015-02-21 18:45:48

标签: javascript jslint

我正在尝试根据JSLint修复一些错误,并且有些错误我无法摆脱:

line 46 character 13  
Missing 'new'.  
     SortPosts(categories[categoryNumber].textContent);

line 65 character 16  
Unexpected '('.
    if (typeof (Storage) !== "undefined") {

line 65 character 9Unexpected 'typeof'. Use '===' to compare directly with undefined.
    if (typeof (Storage) !== "undefined") {

这是我的代码:

window.onload = function () {
    "use strict";
    var categories,
        value,
        i,
        j,
        article,
        li,
        postsAvailable = false;
    function removeElementsByClass() {
        var elements = document.getElementsByClassName("forumPost");
        while (elements.length > 0) {
            elements[0].parentNode.removeChild(elements[0]);
        }
    }
    function addRow(input) {
        article = document.createElement('article');
        article.className = 'forumPost';
        article.innerHTML = "<div id='imageDiv'><img src='" + input.avatar + "' alt='Avatar'id='imageHTML'/><div id='personDiv'> " + input.firstName + " " + input.lastName + " (" + input.age + ") </div><div id='workDiv'>" + input.work + " </div></div><div id='headerDiv'>" + input.firstName + " schreef om <div id='dateDiv'>" + input.date + "</div></div></br><div id='postDiv'>" + input.post + "</div></article>";
        document.getElementById('content').appendChild(article);
    }
    function SortPosts(category) {
        if (localStorage.getItem(category) === "") {
            alert("No posts found!");
        } else {
            removeElementsByClass();
            if (category !== "Algemeen") {
                value = JSON.parse(localStorage.getItem(category));
                for (i = 0; i < value.length; ++i) {
                    addRow(value[i]);
                }
            } else {
                for (i = 0; i < localStorage.length; ++i) {
                    if (localStorage.getItem(localStorage.key(i)) !== "") {
                        value = JSON.parse(localStorage.getItem(localStorage.key(i)));
                        for (j = 0; j < value.length; ++j) {
                            addRow(value[j]);
                        }
                    }
                }
            }
        }
    }
    function getPostSorter(categoryNumber) {
        return function () {
            SortPosts(categories[categoryNumber].textContent);
        };
    }
    document.getElementById("newCategoryButton").onclick = function () {
        var input = document.getElementById("newCategoryInput").value;
        if (input !== "") {
            if (localStorage.getItem(input) !== null) {
                alert("Categorie bestaat al!");
            } else {
                li = document.createElement('li');
                li.innerHTML = "<a href='#'>" + input + "</a></li>";
                localStorage.setItem(input, "");
                document.getElementById("categories").appendChild(li);
            }
        } else {
            alert("Uw invoer mag niet leeg zijn!");
        }
        document.getElementById("newCategoryInput").value = "";
    };
    if (typeof (Storage) !== "undefined") {
        for (i = 0; i < localStorage.length; ++i) {
            if (localStorage.getItem(localStorage.key(i)) !== "") {
                postsAvailable = true;
                break;
            }
        }
        if (postsAvailable === false) {
            article = document.createElement('article');
            article.className = 'infobox';
            article.innerHTML = "<header><h2>Geen posts gevonden!</h2></header><section><p>Ga naar het forum toe om een onderwerp toe te voegen</p></section></article>";
            document.getElementById('content').appendChild(article);
        } else {
            for (i = 0; i < localStorage.length; ++i) {
                if (localStorage.getItem(localStorage.key(i)) !== "") {
                    value = JSON.parse(localStorage.getItem(localStorage.key(i)));
                    for (j = 0; j < value.length; ++j) {
                        addRow(value[j]);
                    }
                }
            }
        }
        for (i = 0; i < localStorage.length; ++i) {
            li = document.createElement('li');
            li.className = "category";
            li.innerHTML = "<a href='#'>" + localStorage.key(i) + "</a></li>";
            document.getElementById("categories").appendChild(li);
        }
        categories = document.getElementsByClassName("category");
        for (i = 0; i < categories.length; ++i) {
            categories[i].addEventListener("click", getPostSorter(i));
        }
    } else {
        alert("Uw browser ondersteunt geen localStorage. Gebruik alstublieft een nieuwere browser zoals Google Chrome, Mozilla Firefox of > Internet Explorer 7");
    }
};

有谁可以告诉我为什么这些是错的,我应该怎么做才能修复它们?我已经搜索了更多信息,但我实际上找不到任何有用的信息。我尝试在SortPosts中添加“new”,但之后它给了我Do not use 'new' for side effects.

的消息

2 个答案:

答案 0 :(得分:1)

  

缺少'新'         SortPosts(类别[categoryNumber] .textContent);

按照惯例,名称以大写字母开头的函数是构造函数。你的不是。将该函数重命名为sortPosts

  

意外'('。        if(typeof(Storage)!==“undefined”){

typeof是一个运算符,而不是一个函数。

使用typeof Storage而非typeof (Storage)

  

第65行字符9意外'typeof'。使用'==='直接与undefined进行比较。

请勿使用typeof。使用Storage !== undefined

注意:JSLint是一个非常自以为是的短信。 undefined可能会被覆盖。我更喜欢typeof方法。

答案 1 :(得分:-1)

要解决这些问题,请将第45行更改为:

        newSortPosts(categories[categoryNumber].textContent);

在您的代码中将SortPosts重命名为newSortPosts。

在第65行,您不需要比较typeof,而只是看看Storage是否未定义:

if (Storage !== undefined) {

请注意,在使用typeof时,您不需要括号,因为typeof是运营商:https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/typeof