removeFromSuperview导致崩溃(非ARC)

时间:2015-02-08 20:50:43

标签: ios objective-c memory-management

我在UIViews和手动内存管理方面遇到了一个奇怪的问题。

我有一个视图( contentView ),它是视图控制器的主视图。

长按 contentView 后,另一个视图应该淡入(在它上面)。

当手势结束时,附加视图会淡出。

问题是:

contentView 收到长按时,我会创建辅助视图,将其添加到 contentView ,然后将其释放,这是常见做法在ARC之前的日子里。

它在iPhone上运行正常,但它在iPad上崩溃了!

崩溃的行是:

[ZPNowPlayingItemInfoView dealloc]

...当我从 contentView 中删除辅助视图时会触发。

有关为何会发生这种情况的任何线索?

如果我注释掉发布行(请参阅我在代码中的评论),它可以在两台设备上完美运行,但感觉不好

以下是代码:

-(void)longPressDetected:(UILongPressGestureRecognizer*)longPressGR
{
   //Content view of the view controller I'm in
   UIView *contentView = MSHookIvar<UIView*>(self, "_contentView");

   if (longPressGR.state == UIGestureRecognizerStateBegan) {

     id item = MSHookIvar<MPAVItem*>(self, "_item");

     ZPNowPlayingItemInfoView *infoView = 
        [[ZPNowPlayingItemInfoView alloc] initWithFrame:
            CGRectMake(0,0,contentView.frame.size.width,contentView.frame.size.height) 
                item:item];

     //infoView retain count: 1

     [infoView setAlpha:0.f];
     [contentView addSubview:infoView];

     //infoView retain count: 3 (???)

     //iPad goes berserk on this line
     //Commented - Works both on iPhone and iPad
     //Uncommented - Works only on iPhone
     //[infoView release];

     //infoView retain count: 2 (if release is uncommented)

     [UIView animateWithDuration:0.35f animations:^{

         [infoView setAlpha:1.0f];

     } completion:^(BOOL finished) {

         //infoView retain count: 3

     }];

  } else if (longPressGR.state == UIGestureRecognizerStateEnded) {

     ZPNowPlayingItemInfoView* infoView = nil;

    for (UIView *subview in contentView.subviews) {

        if ([subview isKindOfClass:[ZPNowPlayingItemInfoView class]]) {

            infoView = (ZPNowPlayingItemInfoView*)subview;
            break;

        }

    }

    [UIView animateWithDuration:0.35f animations:^{

        [infoView setAlpha:0.f];

    } completion: ^(BOOL finished){

        [infoView removeFromSuperview];

    }];

 }

P.S。我需要使用手动内存管理。这是对越狱设备的调整。

堆栈跟踪:

Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0       libobjc.A.dylib                 0x195287bdc 0x19526c000 + 0x1bbdc   // objc_msgSend + 0x1c
1     + Musix.dylib                     0x10015b19c 0x100154000 + 0x719c    // -[ZPNowPlayingItemInfoView dealloc] + 0x48
2       libsystem_blocks.dylib          0x19590d90c 0x19590c000 + 0x190c    // _Block_release + 0xfc
3       UIKit                           0x188ef8590 0x188eb0000 + 0x48590   // -[UIViewAnimationBlockDelegate dealloc] + 0x44
4       CoreFoundation                  0x1845f1374 0x1845ec000 + 0x5374    // CFRelease + 0x208
5       CoreFoundation                  0x184601004 0x1845ec000 + 0x15004   // -[__NSDictionaryI dealloc] + 0x8c
6       libobjc.A.dylib                 0x19528d720 0x19526c000 + 0x21720   // (anonymous namespace)::AutoreleasePoolPage::pop(void*) + 0x230
7       CoreFoundation                  0x1845f4f90 0x1845ec000 + 0x8f90    // _CFAutoreleasePoolPop + 0x18
8       CoreFoundation                  0x1846c774c 0x1845ec000 + 0xdb74c   // __CFRunLoopRun + 0x5d8
9       CoreFoundation                  0x1845f51f0 0x1845ec000 + 0x91f0    // CFRunLoopRunSpecific + 0x188
10      GraphicsServices                0x18d7575a0 0x18d74c000 + 0xb5a0    // GSEventRunModal + 0xa4
11      UIKit                           0x188f26780 0x188eb0000 + 0x76780   // UIApplicationMain + 0x5cc
12      Music (*)                       0x10006ee28 0x100064000 + 0xae28    // 0x0000adac + 0x7c
13      libdyld.dylib                   0x1958e2a04 0x1958e0000 + 0x2a04    // start + 0x0

ZPNowPlayingItemInfoView:

@interface ZPNowPlayingItemInfoView()

@property (nonatomic, retain) MPAVItem* item;

@property (nonatomic, retain) MPUSlantedTextPlaceholderArtworkView *artworkView;
@property (nonatomic, retain) UILabel *artistLabel;
@property (nonatomic, retain) UILabel *albumLabel;
@property (nonatomic, retain) UILabel *songLabel;

@end

ZPNowPlayingItemInfoView dealloc:

-(void)dealloc
{
    [super dealloc];

    [self.item release];

    [self.artworkView release];
    [self.artistLabel release];
    [self.songLabel release];
}

2 个答案:

答案 0 :(得分:2)

ZPNowPlayingItemInfoView课程中存在一些问题。出现这个问题?仅在对象被取消分配时。当您对[infoView release]发表评论时,您的对象永远不会被释放,并且问题不会出现 - 但您会遇到内存泄漏。

检查ZPNowPlayingItemInfoView的作用,尤其是dealloc方法。你确定你正确构建它吗? item始终是有效对象吗?

在看到ZPNowPlayingItemInfoView dealloc方法后,问题非常明显 - [super dealloc]必须始终是最后一次调用,而不是第一次调用。取消分配对象后,访问其属性是未定义的操作。

答案 1 :(得分:0)

当评论出release是一种有效的解决方法时,这表明您经常发布一次。它可能是你注释掉的那个版本。

removeFromSuperview确实将保留计数减少了1.

我建议重新访问视图对象的整个生命周期。但这可能很棘手。每个保留需要具有恰好一个相应的释放或自动释放。使用其getter(self.myView = subview)将视图分配给属性会保留该属性并将其他视图重新分配给属性(self.myView = someOhterview)版本subview。 相反,直接访问iVar(myView = subview)不会保持释放/保留周期。 还有更多。添加视图并将其从数组,集合或字典中删除将相应地更改保留计数。

所以去深入了解一下。使用仪器观察保留计数。