Question

我正在通过Ethan Brown的书＃34;使用Node和Express进行Web开发＆＃34;它一直进展顺利，直到我在照片上传中启用csrf multipart / form-data上传。我从Github下载了完整的图书代码，https://github.com/EthanRBrown/web-development-with-node-and-express并且做同样的事情，直到启用了csrf然后它出错了：

错误：csrf令牌无效

以下是我认为相关的代码，/ meadowlark.js从第100行开始

app.use(require('cookie-parser')(credentials.cookieSecret));
app.use(require('express-session')({ store: sessionStore,
             secret: credentials.cookieSecret,
             name: credentials.cookieName,
             saveUninitialized: true,
             resave: true }));
app.use(express.static(__dirname + '/public'));
app.use(require('body-parser')());

// cross-site request forgery protection
app.use(require('csurf')());
app.use(function(req, res, next){
    res.locals._csrfToken = req.csrfToken();
    next();
});

// database configuration
var mongoose = require('mongoose');
var options = {
    server: {
       socketOptions: { keepAlive: 1 } 
    }
};

然后在/handlers/contest.js

var path = require('path'),
    fs = require('fs'),
    formidable = require('formidable');

// make sure data directory exists
var dataDir = path.normalize(path.join(__dirname, '..', 'data'));
var vacationPhotoDir = path.join(dataDir, 'vacation-photo');
fs.existsSync(dataDir) || fs.mkdirSync(dataDir); 
fs.existsSync(vacationPhotoDir) || fs.mkdirSync(vacationPhotoDir);

exports.vacationPhoto = function(req, res){
    var now = new Date();
    res.render('contest/vacation-photo', { year: now.getFullYear(), month: now.getMonth() });
};

function saveContestEntry(contestName, email, year, month, photoPath){
    // TODO...this will come later
}

exports.vacationPhotoProcessPost = function(req, res){
    var form = new formidable.IncomingForm();
    form.parse(req, function(err, fields, files){
        if(err) return res.redirect(303, '/error');
        if(err) {
            res.session.flash = {
                type: 'danger',
                intro: 'Oops!',
                message: 'There was an error processing your submission. ' +
                    'Pelase try again.',
            };
            return res.redirect(303, '/contest/vacation-photo');
        }
        var photo = files.photo;
        var dir = vacationPhotoDir + '/' + Date.now();
        var path = dir + '/' + photo.name;
        fs.mkdirSync(dir);
        fs.renameSync(photo.path, dir + '/' + photo.name);
        saveContestEntry('vacation-photo', fields.email,
            req.params.year, req.params.month, path);
        req.session.flash = {
            type: 'success',
            intro: 'Good luck!',
            message: 'You have been entered into the contest.',
        };
        return res.redirect(303, '/contest/vacation-photo/entries');
    });
};

exports.vacationPhotoEntries = function(req, res){
    res.render('contest/vacation-photo/entries');
};

和views / contest / vacation-photo.handlebars

<form class="form-horizontal" role="form" 
        enctype="multipart/form-data" method="POST"
        action="/contest/vacation-photo/{{year}}/{{month}}">
    <input type="hidden" name="_csrf" value="{{_csrfToken}}">
    <div class="form-group">
        <label for="fieldName" class="col-sm-2 control-label">Name</label>
        <div class="col-sm-4">
            <input type="text" class="form-control" 
            id="fieldName" name="name">
        </div>
    </div>
    <div class="form-group">
        <label for="fieldEmail" class="col-sm-2 control-label">Email</label>
        <div class="col-sm-4">
            <input type="email" class="form-control" required 
                id="fieldName" name="email">
        </div>
    </div>
    <div class="form-group">
        <label for="fieldPhoto" class="col-sm-2 control-label">Vacation photo</label>
        <div class="col-sm-4">
            <input type="file" class="form-control" required accept="image/*"
                id="fieldPhoto" data-url="/upload" name="photo">
        </div>
    </div>
    <div class="form-group">
        <div class="col-sm-offset-2 col-sm-4">
            <button type="submit" class="btn btn-primary">Submit</button>
        </div>
    </div>
</form>

使csrf正常工作的正确方法是什么？

谢谢，

Answer 1

在度假照片GET请求中，您应该发送如下的csrf令牌。

exports.vacationPhotoEntries = function(req, res){
    res.render('contest/vacation-photo/entries', { _csrfToken: req.csrfToken()});
};

您还可以在默认错误处理程序中捕获 csrf 令牌错误，如下所示。

// error handler
app.use(function (err, req, res, next) {
    if (err.code !== 'EBADCSRFTOKEN') return next(err)

// handle CSRF token errors here
res.status(403)
res.send('session has expired or form tampered with')
})

有关详细信息，请查看this link。

Answer 2

将csrf标记作为查询字符串附加到操作Url .. 它有效！

<form class="form-horizontal" role="form" enctype="multipart/form-data" method="POST" 
action="/contest/vacation-photo/{{year}}/{{month}}?_csrf={{_csrfToken}}">
</form>

Express4和Formidable文件上传有效，直到我启用csrf

2 个答案: