Hartl的Rails教程(rails-4-0)第10.3.2节未找到参数

时间:2014-10-31 18:04:31

标签: ruby ruby-on-rails-4 rspec rspec-rails railstutorial.org

我一直在努力解决这个问题,现在无法弄清楚发生了什么。我正在通过迈克尔哈特尔的Rails教程工作,并且我的一些测试遇到了问题。这些是失败的测试结果:

Failures:

  1) User pages signup with invalid information should not create a user
     Failure/Error: expect { click_button submit }.not_to change(User, :count)
     ActionController::ParameterMissing:
       param not found: user
     # ./app/controllers/users_controller.rb:61:in `user_params'
     # ./app/controllers/users_controller.rb:21:in `create'
     # ./spec/requests/user_pages_spec.rb:89:in `block (5 levels) in <top (required)>'
     # ./spec/requests/user_pages_spec.rb:89:in `block (4 levels) in <top (required)>'

  2) User pages signup with invalid information after submission 
     Failure/Error: before { click_button submit }
     ActionController::ParameterMissing:
       param not found: user
     # ./app/controllers/users_controller.rb:61:in `user_params'
     # ./app/controllers/users_controller.rb:21:in `create'
     # ./spec/requests/user_pages_spec.rb:93:in `block (5 levels) in <top (required)>'

  3) User pages signup with invalid information after submission 
     Failure/Error: before { click_button submit }
     ActionController::ParameterMissing:
       param not found: user
     # ./app/controllers/users_controller.rb:61:in `user_params'
     # ./app/controllers/users_controller.rb:21:in `create'
     # ./spec/requests/user_pages_spec.rb:93:in `block (5 levels) in <top (required)>'

  4) User pages signup with valid information should create a user
     Failure/Error: before { valid_signup(user) }
     Capybara::ElementNotFound:
       Unable to find field "Name"
     # ./spec/support/utilities.rb:10:in `valid_signup'
     # ./spec/requests/user_pages_spec.rb:102:in `block (4 levels) in <top (required)>'

  5) User pages signup with valid information after saving the user 
     Failure/Error: before { valid_signup(user) }
     Capybara::ElementNotFound:
       Unable to find field "Name"
     # ./spec/support/utilities.rb:10:in `valid_signup'
     # ./spec/requests/user_pages_spec.rb:102:in `block (4 levels) in <top (required)>'

  6) User pages signup with valid information after saving the user 
     Failure/Error: before { valid_signup(user) }
     Capybara::ElementNotFound:
       Unable to find field "Name"
     # ./spec/support/utilities.rb:10:in `valid_signup'
     # ./spec/requests/user_pages_spec.rb:102:in `block (4 levels) in <top (required)>'

  7) User pages signup with valid information after saving the user 
     Failure/Error: before { valid_signup(user) }
     Capybara::ElementNotFound:
       Unable to find field "Name"
     # ./spec/support/utilities.rb:10:in `valid_signup'
     # ./spec/requests/user_pages_spec.rb:102:in `block (4 levels) in <top (required)>'

Finished in 9.1 seconds
119 examples, 7 failures

Failed examples:

rspec ./spec/requests/user_pages_spec.rb:88 # User pages signup with invalid information should not create a user
rspec ./spec/requests/user_pages_spec.rb:95 # User pages signup with invalid information after submission 
rspec ./spec/requests/user_pages_spec.rb:96 # User pages signup with invalid information after submission 
rspec ./spec/requests/user_pages_spec.rb:104 # User pages signup with valid information should create a user
rspec ./spec/requests/user_pages_spec.rb:113 # User pages signup with valid information after saving the user 
rspec ./spec/requests/user_pages_spec.rb:115 # User pages signup with valid information after saving the user 
rspec ./spec/requests/user_pages_spec.rb:116 # User pages signup with valid information after saving the user 

所以这是我的user_pages_spec.rb:

require 'spec_helper'

describe "User pages" do

  subject { page }

  describe "index" do

    let(:user) { FactoryGirl.create(:user) }

    before do
      sign_in user
      visit users_path
    end

    it { should have_title('All users') }
    it { should have_content('All users') }

    describe "pagination" do

      before(:all) { 30.times { FactoryGirl.create(:user) } }
      after(:all) { User.delete_all }

      it { should have_selector('div.pagination') }

      it "should list each user" do
        #User.all.each do |user|
        User.paginate(page: 1).each do |user|
          expect(page).to have_selector('li', text: user.name)
        end
      end
    end

    describe "delete links" do

      it { should_not have_link('delete') }

      describe "as an admin user" do
        let(:admin) { FactoryGirl.create(:admin) }
        before do
          sign_in admin
          visit users_path
        end

        it { should have_link('delete', href: user_path(User.first)) }
        it "should be able to delete another user" do
          expect do
            click_link('delete', match: :first)
          end.to change(User, :count).by(-1)
        end
        it { should_not have_link('delete', href: user_path(admin)) }

      end
    end
  end

  describe "profile page" do
    let(:user) { FactoryGirl.create(:user) }
    let!(:m1) { FactoryGirl.create(:micropost, user: user, content: "Foo") }
    let!(:m2) { FactoryGirl.create(:micropost, user: user, content: "Bar") }

    before { visit user_path(user) }

    it { should have_content(user.name) }
    it { should have_title(user.name) }

    describe "microposts" do
      it { should have_content(m1.content) }
      it { should have_content(m2.content) }
      it { should have_content(user.microposts.count) }
    end
  end

  describe "signup page" do
    before { visit signup_path }

    it { should have_content('Sign up') }
    it { should have_title(full_title('Sign up')) }
  end

  describe "signup" do

    before { visit signup_path }

    let(:submit) { "Create my account" }

    describe "with invalid information" do
      it "should not create a user" do
        expect { click_button submit }.not_to change(User, :count)
      end

      describe "after submission" do
        before { click_button submit }

        it { should have_title('Sign up') }
        it { should have_content('error') }
      end
    end

    describe "with valid information" do
      let(:user) {FactoryGirl.build(:user)}
      before { valid_signup(user) }

      it "should create a user" do
        expect { click_button submit }.to change(User, :count).by(1)
      end

      describe "after saving the user" do
        before { click_button submit }

        #let(:user) { User.find_by(email: 'user@example.com') }

        it { should have_title(user.name) }
        #it { should have_selector('title', text: user.name) }
        it { should have_selector('div.alert.alert-success', text: 'Welcome') }
        it { should have_link('Sign out') }
      end
    end
  end

  describe "edit" do
    let(:user) { FactoryGirl.create(:user) }
    before do
      sign_in user
      visit edit_user_path(user)
    end

    describe "page" do
      it { should have_content("Update your profile") }
      it { should have_title("Edit user") }
      it { should have_link('Change', href: 'http://gravatar.com/emails') }
    end

    describe "with invalid information" do
      before { click_button "Save changes" }

      it { should have_content('error') }
    end

    describe "with valid information" do
      let(:new_name) { "New Name" }
      let(:new_email) { "new@example.com" }
      before do
        fill_in "Name", with: new_name
        fill_in "Email", with: new_email
        fill_in "Password", with: user.password
        fill_in "Confirm Password", with: user.password
        click_button "Save changes"
      end

      it { should have_title(new_name) }
      it { should have_selector('div.alert.alert-success') }
      it { should have_link('Sign out', href: signout_path) }
      specify { expect(user.reload.name).to eq new_name }
      specify { expect(user.reload.email).to eq new_email }
    end

    describe "forbidden attributes" do
      let(:params) do
        { user: {admin: true, password: user.password, password_confirmation: user.password } }
      end
      before do
        sign_in user, no_capybara: true
        patch user_path(user), params
      end
      specify { expect(user.reload).not_to be_admin }
    end
  end
end

users_controller.rb:

class UsersController < ApplicationController
  before_action :signed_in_user, only: [:index, :edit, :update, :destroy]
  before_action :correct_user, only: [:edit, :update]
  before_action :admin_user, only: :destroy
  before_filter :signed_in_user_filter, only: [:new, :create]

 def index
    @users = User.paginate(page: params[:page])
  end

  def show
   @user = User.find(params[:id])
    @microposts = @user.microposts.paginate(page: params[:page])
 end

  def new
   @user = User.new
  end

  def create
   @user = User.new(user_params)
   if @user.save
      sign_in @user
      flash[:success] = "Welcome to the Sample App!"
     redirect_to @user
   else
     render 'new'
   end
  end

  def destroy
    @user = User.find(params[:id])
    if current_user == @user
      flash[:error] = "You must not delete yourself."
      #redirect_to users_path
    else
      @user.destroy
      flash[:success] = "User deleted."
      #redirect_to users_url
    end
    redirect_to users_path
  end

  def edit
    #@user = User.find(params[:id])
  end

  def update
    #@user = User.find(params[:id])
    if @user.update_attributes(user_params)
      flash[:success] = "Profile updated"
      redirect_to @user
    else
      render 'edit'
    end
  end

  private

   def user_params
     params.require(:user).permit(:name, :email, :password, :password_confirmation)
   end

    #Before filters

    def signed_in_user
      unless signed_in?
        store_location
        redirect_to signin_url, notice: "Please sign in." 
      end
    end

    def signed_in_user_filter 
      redirect_to root_path, notice: "Already logged in" if signed_in?
    end

    def correct_user
      @user = User.find(params[:id])
      redirect_to(root_url) unless current_user?(@user)
    end

    def admin_user
      redirect_to(root_url) unless current_user.admin?
    end

end

我不确定还有什么可以解决,但这里是app / views / users / new.html.erb:

<% provide(:title, 'Sign up') %>
<h1>Sign up</h1>

<div class="row">
  <div class="span6 offset3">
    <%= form_for(@user) do |f| %>
      <%= render 'shared/error_messages', object: f.object %>
      <%= f.submit "Create my account", class: "btn btn-large btn-primary" %>
    <% end %>
  </div>
</div>

说实话,我不是百分百确定在哪里寻找这个问题。它恰好发生在我在本章中做出的这些最新变化。我尝试做所有的练习,所以有时候我应该编辑的内容有所不同,所以我不知道我是不是搞砸了什么,或者只是做了些蠢事。当我从浏览器访问应用程序,然后单击“注册我”链接注册一个新用户时,我得到了red rails错误页面,其中显示了在UsersController中创建的ActionController :: ParameterMissing #infate但我不知道究竟是什么意思。我真的不认为我改变了任何会影响它的代码,但是我已经尝试了一些东西来尝试完成之前的练习,所以也许这就是发生的事情。

感谢您的帮助!这是我的第一篇SO帖子,所以希望我在礼仪/格式化方面没有犯错误。我像往常一样搜索有类似问题的人,却找不到任何东西。

编辑:我想补充一点,我一直在使用本教程的上一版本,因为我在新版本发布时没有完成。您可以在此处找到它:http://rails-4-0.railstutorial.org/book/user_microposts

1 个答案:

答案 0 :(得分:2)

我认为答案非常简单。当您只想要添加错误呈现组件时,您似乎删除了表单中的所有字段。您的注册表格应该是:

<% provide(:title, 'Sign up') %>
<h1>Sign up</h1>    
<div class="row">
  <div class="span6 offset3">
    <%= form_for(@user) do |f| %>
     <%= render 'shared/error_messages', object: f.object %>

      <%= f.label :name %>
      <%= f.text_field :name %>

      <%= f.label :email %>
      <%= f.text_field :email %>

      <%= f.label :password %>
      <%= f.password_field :password %>

      <%= f.label :password_confirmation, "Confirmation" %>
      <%= f.password_field :password_confirmation %>

      <%= f.submit "Create my account", class: "btn btn-large btn-primary" %>
    <% end %>
  </div>
</div>