使用Parallel.ForEach的Azure TableQuery线程安全性

时间:2014-10-05 06:37:19

标签: c# azure azure-table-storage parallel-extensions

我有一些基本的Azure表,我一直在连续查询:

var query = new TableQuery<DynamicTableEntity>()
  .Where(TableQuery.GenerateFilterCondition("PartitionKey",
    QueryComparisons.Equal, myPartitionKey));

foreach (DynamicTableEntity entity in myTable.ExecuteQuery(query)) {
  // Process entity here.
}

为了加快速度,我将其并行化:

Parallel.ForEach(myTable.ExecuteQuery(query), (entity, loopState) => {
  // Process entity here in a thread-safe manner.

  // Edited to add: Details of the loop body below:

  // This is the essence of the fixed loop body:
  lock (myLock) {
    DataRow myRow = myDataTable.NewRow();
    // [Add entity data to myRow.]
    myDataTable.Rows.Add(myRow);
  }

  // Old code (apparently not thread-safe, though NewRow() is supposed to create
  // a DataRow based on the table's schema without changing the table state):
  /*
    DataRow myRow = myDataTable.NewRow();
    lock (myLock) {
      // [Add entity data to myRow.]
      myDataTable.Rows.Add(myRow);
    }
  */
});

这会产生显着的加速,但结果往往在运行之间略有不同(即,有些实体偶尔会有所不同,尽管返回的实体数量完全相同)。

从这个和一些网络搜索,我得出结论,上面的枚举器并不总是线程安全的。该文档似乎表明,只有当表对象是公共静态时才保证线程安全,但这对我没有任何影响。

有人可以建议如何解决此问题吗?是否存在用于并行化Azure表查询的标准模式?

1 个答案:

答案 0 :(得分:4)

您的评论是正确的:DataTable不适合涉及变异的并发操作,并且是重复条目的来源。锁定DataTable对象以进行行修改操作将解决此问题:

 lock (myTable)
 {
    DataRow myRow = myTable.NewRow();
    myRow.SetField<int>("c1", (int)value);
    myTable.Rows.Add(myRow);
 }

将NewRow()置于锁定之外将间歇性地导致表格中的重复行条目或&#34;未处理的类型&#39; System.ArgumentException&#39;发生在System.Data.dll&#34; NewRow()行的例外情况。有关并发DataTable使用的其他详细信息和替代方法,请参阅Thread safety for DataTable

要重现错误条件,请使用此代码。一些运行将是干净的,一些将包含重复的条目,一些将遇到异常。

   class Program
   {
      static DataTable myTable = GetTable();
      static ManualResetEvent waitHandle = new ManualResetEvent(false);

      static void Main(string[] args)
      {
         const int threadCount = 10;
         List<Thread> threads = new List<System.Threading.Thread>();
         for (int i = 0; i < threadCount; ++i) 
         {
            threads.Add(new Thread(new ParameterizedThreadStart(AddRowThread)));
            threads[i].Start(i);
         }
         waitHandle.Set(); // Release all the threads at once
         for (int i = 0; i < threadCount; ++i) 
         {
            threads[i].Join();
         }

         // Print results once threads return
         for (int i = 0; i < myTable.Rows.Count; ++i)
         {
            Console.WriteLine(myTable.Rows[i].Field<int>(0));
         }
         Console.WriteLine("---Processing Complete---");
         Console.ReadKey();
      }

      static void AddRowThread(object value)
      {
         waitHandle.WaitOne();
         DataRow myRow = myTable.NewRow(); // THIS RESULTS IN INTERMITTENT ERRORS
         lock (myTable)
         {
            //DataRow myRow = myTable.NewRow(); // MOVE NewRow() CALL HERE TO RESOLVE ISSUE
            myRow.SetField<int>("c1", (int)value);
            myTable.Rows.Add(myRow);
         }
      }

      static DataTable GetTable()
      {
         // Here we create a DataTable with four columns.
         DataTable table = new DataTable();
         table.Columns.Add("c1", typeof(int));       
         return table;
      }
   }