如何将char *转换为2d char数组

时间:2014-09-25 00:21:24

标签: c multidimensional-array

我正在尝试使用char *代表单个单词并从函数中获取char *,然后将其放入2d数组中,而只是重复每个字母的第一个字母这几个字。输出看起来像这样

ttttttttttttttttttttttttttttttttvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvoooooooooooooooooooooooooo

我的输入文件是

three
versions
of
simple
with
spell
check
checking
program
we
will
write

我不确定如何正确地将char *转换为2d数组 这是我正在使用的所有功能

#include <stdio.h>
#include <stdlib.h>
#include <stdbool.h>
#include <ctype.h>
#include "dict.h"



bool is_valid_entry( int strLength, char entry[] ){

    if( entry[0] != '"' && !isalpha(entry[0]) && entry[0] != '\''  ){
        return false;
    }

    strLength--; /* to allow for the zero index of the array*/

    for ( int i=1; i < strLength; i++ )
        if ( !isalpha( entry[i] ) ){

            return false;
        }

    if (!isalpha( entry[strLength] ) && !ispunct( entry[strLength] ) && entry[strLength] != '"' && entry[strLength] != '\'' ){

        return false;
    }
return true;/* if the entry passes all of the tests the function will return true meaning the the word is valid*/ 

}/* ends is_valid_entry( int strlength, char entry[] )*/



char * normalize( int strLength, char entry[], char output[] ){

    strLength--;/* to allow for the zero index of an array*/
    int j = 0;

    for( int i = 0;i < strLength; i++){/* converts all of the elements in the entry[] to lower case*/
        if (isupper( entry[i] ) ){
            entry[i] = tolower( entry[i] );
        }
    }

    if( ( entry[0] == '"' && entry[strLength] == '"' ) || (entry[0] == '\'' && entry[strLength] == '\'' ) ) {
        for(int i=1 ; i < strLength ; i++,j++ ){ 
            output[j] = entry[i];
        }
        output[j] = '\0';/* removes the last character which is either a '"' ir a '\''*/
        return output;/* returns the noramlized word*/

        }else if( entry[0] == '"' || entry[0] == '\'' ){
            for(int i = 1; j < strLength; i++, j++ ){/*i=1 in order to skip the first element in the entry arrary*/
                output[j] = entry[i];
            }
            output[j] = '\0';
            return output;/* returns the noramlized word*/

        } else if( entry[strLength] == '"' || ispunct( entry[strLength] ) || entry[strLength] == '\''){
                for(int i = 0;j < strLength; i++,j++ ){
                    output[j] = entry[i];
                }
                output[j] = '\0';
                return output;/* returns the noramlized word*/
            }


return entry;/* returns the original array since it does not need to be normalized*/

}/* ends normalize( int strlength, char entry[], char output[] )*/
    void load_dict(char *fileName, char dictionary[30000][31]) {

    FILE *fdict;
    fdict = fopen( fileName, "r" );/* file pointer for the dictionary file*/
    char *normDictWord;
    char normDict [33]; 

    int strLength,i,j,ch;    
    if ( fdict == NULL ){
        fprintf(stderr,"Could not open file: %s\n", fileName );/*checks to make sure the dictionary file can be opened*/
        exit(1);
    }

    for (i = 0; (ch = fgetc( fdict ) ) != EOF; i++ ) {          

        char word[33] = "";/* resets the array*/


        for (strLength = 0; !isspace( ch ) ; strLength++ ){
            word[strLength] = ch;
            ch = fgetc( fdict );            
                }

        if (is_valid_entry( strLength , word ) ){
            normDictWord = normalize( strLength , word , normDict );/*normalize then do the linear search then print the word if it is not found in the dictionary*/

            for(j = 0; j <= 31;j++){
                dictionary[i][j] = * normDictWord ;
                printf("%c",dictionary[i][j]);
            }

        }


    }
    fclose( fdict ); 
}

2 个答案:

答案 0 :(得分:1)

我无法完全理解您的代码,修复格式,并添加一些缺少的部分(否则我无法对其进行测试)。但是:

dictionary[i][j] = * normDictWord;

应该是这样的:

dictionary[i][j] = * (normDictWord + j);

或等效地:

dictionary[i][j] = normDictWord[j] ;

答案 1 :(得分:1)

关键问题(@pez)

  for (j = 0; j <= 31; j++) {
    // dictionary[i][j] = *normDictWord;
    dictionary[i][j] = normDictWord[j];
    printf("%c", dictionary[i][j]);
  }

其他一些问题:

如果EOF条件发生在空格之前,原始代码将无休止地循环。 isspace(EOF)是假的。此循环也不会阻止溢出。

char word[33] = "";

// for (strLength = 0; !isspace(ch); strLength++) {
for (strLength = 0; !isspace(ch) && ch != EOF && strLength < sizeof word; strLength++) {
  word[strLength] = ch;
  ch = fgetc(fdict);
}

以下内容并未“将条目[]中的所有元素转换为小写”,只有元素[0 ]... [original_string_length-2]。在循环之后,代码应该strLength--;

strLength--;/* to allow for the zero index of an array*/
...
for (int i = 0; i < strLength; i++) {/* */
  ...