Question

我希望有一个Mercurial钩子在提交事务之前运行，如果提交的二进制文件大于1兆字节，该事务将中止事务。我找到了以下代码，除了一个问题，它工作正常。如果我的变更集涉及删除文件，则此挂钩将抛出异常。

钩子（我正在使用pretxncommit = python:checksize.newbinsize）：

from mercurial import context, util
from mercurial.i18n import _
import mercurial.node as dpynode

'''hooks to forbid adding binary file over a given size

Ensure the PYTHONPATH is pointing where hg_checksize.py is and setup your
repo .hg/hgrc like this:

[hooks]
pretxncommit = python:checksize.newbinsize
pretxnchangegroup = python:checksize.newbinsize
preoutgoing = python:checksize.nopull

[limits]
maxnewbinsize = 10240
'''

def newbinsize(ui, repo, node=None, **kwargs):
    '''forbid to add binary files over a given size'''
    forbid = False
    # default limit is 10 MB
    limit = int(ui.config('limits', 'maxnewbinsize', 10000000))
    tip = context.changectx(repo, 'tip').rev()
    ctx = context.changectx(repo, node)
    for rev in range(ctx.rev(), tip+1):
        ctx = context.changectx(repo, rev)
        print ctx.files()
        for f in ctx.files():
            fctx = ctx.filectx(f)
            filecontent = fctx.data()
            # check only for new files
            if not fctx.parents():
                if len(filecontent) > limit and util.binary(filecontent):
                    msg = 'new binary file %s of %s is too large: %ld > %ld\n'
                    hname = dpynode.short(ctx.node())
                    ui.write(_(msg) % (f, hname, len(filecontent), limit))
                    forbid = True
    return forbid

例外：

$  hg commit -m 'commit message'
error: pretxncommit hook raised an exception: apps/helpers/templatetags/include_extends.py@bced6272d8f4: not found in manifest
transaction abort!
rollback completed
abort: apps/helpers/templatetags/include_extends.py@bced6272d8f4: not found in manifest!

我不熟悉编写Mercurial钩子，所以我对发生的事情感到很困惑。如果hg已经知道它，为什么钩子会关心文件被删除了？有没有办法修复这个钩子，以便它一直有效？

更新（已解决）： 我修改了钩子来过滤掉在变更集中删除的文件。

def newbinsize(ui, repo, node=None, **kwargs):
    '''forbid to add binary files over a given size'''
    forbid = False
    # default limit is 10 MB
    limit = int(ui.config('limits', 'maxnewbinsize', 10000000))
    ctx = repo[node]
    for rev in xrange(ctx.rev(), len(repo)):
        ctx = context.changectx(repo, rev)

        # do not check the size of files that have been removed
        # files that have been removed do not have filecontexts
        # to test for whether a file was removed, test for the existence of a filecontext
        filecontexts = list(ctx)
        def file_was_removed(f):
            """Returns True if the file was removed"""
            if f not in filecontexts:
                return True
            else:
                return False

        for f in itertools.ifilterfalse(file_was_removed, ctx.files()):
            fctx = ctx.filectx(f)
            filecontent = fctx.data()
            # check only for new files
            if not fctx.parents():
                if len(filecontent) > limit and util.binary(filecontent):
                    msg = 'new binary file %s of %s is too large: %ld > %ld\n'
                    hname = dpynode.short(ctx.node())
                    ui.write(_(msg) % (f, hname, len(filecontent), limit))
                    forbid = True
    return forbid

Answer 1

在最近的Mercurial中，在shell钩子中这很容易做到：

if hg locate -r tip "set:(added() or modified()) and binary() and size('>100k')"; then
  echo "bad files!"
  exit 1
else
  exit 0
fi

这里发生了什么？首先，我们有一个文件集来查找有问题的所有已更改文件（请参阅hg 1.9中的'hg help filesets'）。 'locate'命令就像状态一样，只是它只列出文件并在找到任何内容时返回0。我们指定'-r tip'来查看挂起的提交。

Answer 2

for f in ctx.files()将包含已删除的文件，您需要将其过滤掉。

（您可以for rev in range(ctx.rev(), tip+1):替换for rev in xrange(ctx.rev(), len(repo)):，然后移除tip = ...）

如果您使用的是现代hg，则不会ctx = context.changectx(repo, node)而是ctx = repo[node]。

Mercurial钩子禁止提交大型二进制文件

2 个答案: