为什么drawRect会留下图像的一部分?

时间:2014-08-25 02:38:17

标签: ios objective-c caching uiview drawrect

这是我的理由:

我有一个包含餐馆列表的表格,每个条目都显示了使用drawRect绘制的分数栏上随时间检查的结果。

当用户向下滚动桌子然后向上滚动时,会显示带有黄色和红色方块的分数栏,之前的分数栏会拾取这些方块。日期也被吸引到以前的成绩栏中。

我的问题在于摆脱旧广场。每次调用drawRect时都不应该删除它们吗?

我已经在下面放了三张图片,希望能解释一下我的意思。

我不认为这是表行缓存自定义单元格的问题吗? 这里,一旦UITableCell建立单元出列,就绘制出分数栏;单元格中的所有其他视图都是正确的,这让我觉得问题是drawRect无法清除图形上下文。

- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath {
  if (indexPath.row < self.establishments.count) {
      return [self establishmentCellForIndexPath:indexPath];
  } else if (self._noResultsFound) {
      return [self noResultsCell];
  } else {
      return [self loadingCell];
  }
}

- (UITableViewCell *)establishmentCellForIndexPath:(NSIndexPath *)indexPath {

  static NSString *CellIdentifier = @"EstablishmentCell";

  DSFEstablishment *establishment = [self.establishments objectAtIndex:[indexPath row]];

  DSFEstablishmentCell *cell = [self.tableView dequeueReusableCellWithIdentifier:CellIdentifier];

  [cell setEstablishment:establishment];
  [cell updateCellContent];

  return cell;
}

在updateCellContent期间,我们尝试清除旧的scorebarviews(如果存在),但代码永远不会找到DSFScorebarView类的其他子视图。最后,创建scorebarView并将其添加到视图的子视图中。

- (void)updateCellContent {
NSLog(@"updateCellContent: %@", self.establishment.latestName);

self.name.text = self.establishment.latestName;
self.address.text = self.establishment.address;
self.type.text = self.establishment.latestType;
if (self.establishment.distance) {
    self.distance.text = [NSString stringWithFormat:@"%.2f km", self.establishment.distance];
} else {
    self.distance.text = @"";
}

// Clear out old scorebarView if exists
for (UIView *view in self.subviews) {
    if ([view isKindOfClass:[DSFScorebarView class]]) {
        NSLog(@">>>removeFromSuperview");
        [view removeFromSuperview];
    }
}

DSFScorebarView *scorebarView = [[DSFScorebarView alloc] initWithInspections:self.establishment.inspections];
[self addSubview:scorebarView];

}

在initWithInspections中使用drawRect绘制得分栏视图,并确保得分栏长度不超过17个方格(最近一次检查)。每次检查给出一个绿色的正方形=低|黄色=中等|红色=高,并且年份在正方形下方绘制。

我设置了self.clearsContextBeforeDrawing = YES,但它没有解决问题。

// Custom init method
- (id)initWithInspections:(NSArray *)inspections {
CGRect scorebarFrame = CGRectMake(20, 38, 273, 22);
if ((self = [super initWithFrame:scorebarFrame])) {
    self.inspections = inspections;

    self.clearsContextBeforeDrawing = YES;

    [self setBackgroundColor:[UIColor clearColor]];
}
return self;
}

- (void)drawRect:(CGRect)rect {
CGContextRef ctx = UIGraphicsGetCurrentContext();

float xOffset = 0; // Keep track of position of next box -- start at 1
float yOffset = 0; // Fixed Y offset. Adjust to match shadows
NSString *previousYear = nil;
UIFont *yearFont = [UIFont fontWithName:@"PFTempestaFiveCompressed" size:8.0];

// take subset/slice of inspections. only the last 17, so it will fit on screen.
int inspections_count = (int)[self.inspections count];

int startIndex = inspections_count > 17 ? inspections_count - 17 - 1 : 0;
int subarrayLength = inspections_count > 17 ? 17 : inspections_count;
NSArray *inspectionsSlice = [self.inspections subarrayWithRange:NSMakeRange(startIndex, subarrayLength)];

for (id inspection in inspectionsSlice) {

    // Top of box
    NSMutableArray *pos0RGBA = [inspection colorForStatusAtPositionRGBA:0];
    CGFloat topColor[] = ...
    CGContextSetFillColor(ctx, topColor);
    CGRect box_top = CGRectMake(xOffset, yOffset, kScoreBoxWidth, kScoreBoxHeight / 2);
    CGContextAddRect(ctx, box_top);
    CGContextFillPath(ctx);

    // Bottom of box
    NSMutableArray *pos1RGBA = [inspection colorForStatusAtPositionRGBA:1];
    CGFloat bottomColor[] = ...
    CGContextSetFillColor(ctx, bottomColor);
    CGRect box_bottom = CGRectMake(xOffset, kScoreBoxHeight / 2 + yOffset, kScoreBoxWidth, kScoreBoxHeight / 2);
    CGContextAddRect(ctx, box_bottom);
    CGContextFillPath(ctx);

    // Year Text
    NSString *theYear = [inspection dateYear];
    if (![theYear isEqualToString:previousYear]) {
        CGFloat *yearColor = ...
        CGContextSetFillColor(ctx, yearColor);
        // +/- 1/2 adjustments are positioning tweaks
        CGRect yearRect = CGRectMake(xOffset+1, yOffset+kScoreBoxHeight-2, kScoreBoxWidth+50, kScoreBoxHeight);
        [theYear drawInRect:yearRect withFont:yearFont];
        previousYear = theYear;
    }

    xOffset += kScoreBoxWidth + kScoreBoxGap;
}
  • 表格加载,绘制4行

Starting position

  • 用户向下滚动;再绘制8行

enter image description here

  • 用户滚动回到顶部; Grace Market / Maple Pizza(第2行)的分数栏已经改变。

enter image description here

在下面实施@HRIR的解决方案之后,在点击一个表格行后,我在灰色背景下得到一个白色条纹。在将额外的宽度添加到白色&#39;之后,它非常难看。年线。

- (void)drawRect:(CGRect)rect {
  ...
  CGFloat backgroundColour[] = {1.0, 1.0, 1.0, 1.0};
  CGContextSetFillColor(ctx, backgroundColour);
  CGRect fullBox = CGRectMake(xOffset, yOffset, kScoreBoxWidth * 17, 2 * (kScoreBoxHeight-2));
  CGContextAddRect(ctx, fullBox);
  CGContextFillPath(ctx);

  for (id inspection in inspectionsSlice) {
  ...

grey tablerow with scorebar graph and white strip

1 个答案:

答案 0 :(得分:1)

你已经接管了DrawRect,所以它只会做你在dra中手动做的事情

使用背景颜色填充整个条形区域,然后在其上方绘制任何内容。

您正在重复使用单元格,例如,您可以在Grace Market / Maple Plaza的第二个版本下方显示Turf Hotel Restaurant图表。

CGContextSetFillColor(ctx, yourBackgroundColor);
CGRect fullBox = CGRectMake(xOffset, yOffset, kScoreBoxWidth * 17, kScoreBoxHeight);
CGContextAddRect(ctx, fullBox);
CGContextFillPath(ctx);

如果您只是清除单元格中的背景而不是背景颜色。然后:

CGContextClearRect(context, rect);
在DrawRect开始时

可能更合适。

REVISION:

更仔细地查看您的问题,根本问题是您没有找到并删除旧的DSFScoreboardView。也许您应该尝试通过子视图进行递归搜索。喜欢:

- (void)logViewHierarchy {
    NSLog(@"%@", self);
    for (UIView *subview in self.subviews) {
        //look right here for your DSFScorebarView's
        [subview logViewHierarchy];
    }
}
@end

// In your implementation
[myView logViewHierarchy];

(摘自https://stackoverflow.com/a/2746508/793607