在我开始之前,我只想澄清一下,我知道这个错误意味着什么,我只是不知道它为什么会发生。这不仅来自着名的书籍,而且我不确定为什么指针=指针在这里是非法的。无论如何,这里是来自K& R的代码,对声明和内容的顺序稍作修改,但大多数都是完整的:
#include <stdio.h>
#include <string.h>
#define MAXLINES 5000 /* max #lines to be sorted */
#define MAXLEN 1000 /* max length of any input line */
extern char *alloc(int);
int igetline(char *, int);
char *lineptr[MAXLINES]; /* pointers to text lines */
int readlines(char *lineptr[], int nlines);
void writelines(char *lineptr[], int nlines);
void qsort(char *lineptr[], int left, int right);
/* sort input lines */
int main(void)
{
int nlines; /* number of input lines read */
if ((nlines = readlines(lineptr, MAXLINES)) >= 0) {
qsort(lineptr, 0, nlines-1);
writelines(lineptr, nlines);
return 0;
} else {
printf("error: input too big to sort\n");
return 1;
}
}
/* readlines: read input lines */
int readlines(char *lineptr[], int maxlines)
{
int len, nlines;
char *p, line[MAXLEN];
nlines = 0;
while ((len = igetline(line, MAXLEN)) > 0)
if (nlines >= maxlines || p = alloc(len) == NULL)
return -1;
else {
line[len-1] = '\0'; /* delete newline */
strcpy(p, line);
lineptr[nlines++] = p;
}
return nlines;
}
/* writelines: write output lines */
void writelines(char *lineptr[], int nlines)
{
int i;
for (i = 0; i < nlines; i++)
printf("%s\n", lineptr[i]);
}
/* igetline: read a line into s, return length */
int igetline(char s[], int lim)
{
int c, i;
for (i=0; i < lim-1 && (c=getchar())!=EOF && c!='\n'; ++i)
s[i] = c;
if (c == '\n') {
s[i] = c;
++i;
}
s[i] = '\0';
return i;
}
/* qsort: sort v[left]...v[right] into increasing order */
void qsort(char *v[], int left, int right)
{
int i, last;
void swap(char *v[], int i, int j);
if (left >= right) /* do nothing if array contains */
return; /* fewer than two elements */
swap(v, left, (left + right)/2);
last = left;
for (i = left+1; i <= right; i++)
if (strcmp(v[i], v[left]) < 0)
swap(v, ++last, i);
swap(v, left, last);
qsort(v, left, last-1);
qsort(v, last+1, right);
}
/* swap: interchange v[i] and v[j] */
void swap(char *v[], int i, int j)
{
char *temp;
temp = v[j];
v[i] = v[j];
v[j] = temp;
}
请注意,alloc()位于另一个文件中。我不认为它与此有任何关系,但无论如何都是代码:
#define ALLOCSIZE 10000 /* size of available space */
static char allocbuf[ALLOCSIZE]; /* storage for alloc */
static char *allocp = allocbuf; /* next free position */
char *alloc(int n) /* return pointer to n characters */
{
if (allocbuf + ALLOCSIZE - allocp >= n) {
allocp += n;
return allocp - n;
} else
return 0;
}
void afree(char *p) /* free storage pointed to by p */
{
if (p >= allocbuf && p < allocbuf + ALLOCSIZE)
allocp = p;
}
当我尝试编译上面的代码时,它给了我这个错误:
cc sample5.6.c alloc.c
sample5.6.c:37:31: error: expression is not assignable
if (nlines >= maxlines || p = alloc(len) == NULL)
~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.
答案 0 :(得分:4)
if (nlines >= maxlines || p = alloc(len) == NULL)
简要介绍一下语言语法,很明显if ()
语句中的内容是赋值表达式。换句话说,它被解析为:
if ( (nlines >= maxlines || p) = (alloc(len) == NULL) )
你可能想要的是:
if (nlines >= maxlines || (p = alloc(len)) == NULL)
与我的 K&amp; R2 副本中的代码相同。
以下内容摘自n1570的语言句法部分(当前C标准的最终公开草案),第467页和第472页(严重缩写)。 K&amp; R2 (Kernighan和Ritchie的“C编程语言,第二版”)中详述的语法相同。
selection-statement: if ( expression ) statement expression: assignment-expression assignment-expression: conditional-expression unary-expression assignment-operator assignment-expression conditional-expression: logical-OR-expression logical-OR-expression: logical-OR-expression || logical-AND-expression
答案 1 :(得分:0)
试试这个
if ((nlines >= maxlines) || (p = alloc(len)) == NULL)
分组在这里也很重要!