我正在制作模拟电视

时间:2010-03-23 04:11:13

标签: python class properties

我需要制作一台向用户显示频道和音量的电视,并显示电视是否开启。我有大部分代码,但由于某种原因,频道不会切换。我对属性的工作方式还不太熟悉,我认为这就是我的问题所在。请帮助。

class Television(object):

    def __init__(self, __channel=1, volume=1, is_on=0):
        self.__channel=__channel
        self.volume=volume
        self.is_on=is_on

    def __str__(self):
        if self.is_on==1:
            print "The tv is on"
            print self.__channel
            print self.volume
        else:
            print "The television is off."

    def toggle_power(self):
        if self.is_on==1:
            self.is_on=0
            return self.is_on
        if self.is_on==0:
            self.is_on=1
            return self.is_on

    def get_channel(self):
        return channel

    def set_channel(self, choice):
        if self.is_on==1:
            if choice>=0 and choice<=499:
                channel=self.__channel
            else:
                print "Invalid channel!"
        else:
            print "The television isn't on!"

    channel=property(get_channel, set_channel)

    def raise_volume(self, up=1):
        if self.is_on==1:
            self.volume+=up
            if self.volume>=10:
                self.volume=10
                print "Max volume!"
        else:
            print "The television isn't on!"

    def lower_volume(self, down=1):
        if self.is_on==1:
            self.volume-=down
            if self.volume<=0:
                self.volume=0
                print "Muted!"
        else:
            print "The television isn't on!"

def main():

    tv=Television()
    choice=None
    while choice!="0":
        print \
        """
        Television

        0 - Exit
        1 - Toggle Power
        2 - Change Channel
        3 - Raise Volume
        4 - Lower Volume
        """

        choice=raw_input("Choice: ")
        print

        if choice=="0":
            print "Good-bye."

        elif choice=="1":
            tv.toggle_power()
            tv.__str__()

        elif choice=="2":
            change=raw_input("What would you like to change the channel to?")
            tv.set_channel(change)
            tv.__str__()

        elif choice=="3":
            tv.raise_volume()
            tv.__str__()

        elif choice=="4":
            tv.lower_volume()
            tv.__str__()

        else:
            print "\nSorry, but", choice, "isn't a valid choice."

main()

raw_input("Press enter to exit.")

2 个答案:

答案 0 :(得分:5)

  1. 频道号是整数,但raw_input返回字符串。应该是:

    change = int(raw_input("What would you like to change the channel to?"))
    
  2. 你的set_channel函数也有:

    channel=self.__channel
    

    应该是:

    self.__channel = choice
    
  3. 这两项变化使其有效。

答案 1 :(得分:3)

额外提示:

将此信息发布为社区维基,以便每个人都可以提供想法和提示。

  • 不要以两个下划线开头命名属性。 意味着私密。如果您想要一些私人名称,请使用单个下划线。
  • 您并未真正使用自己创建的channel媒体资源。
  • is_on
  • 使用True和False代替1和0
  • __str__方法应返回一个字符串,而不是打印一个字符串。然后你不直接调用它,只需打印实例,它就会被python调用(通常你不会调用以你自己的两个下划线开头和结尾的方法)。

使用上述提示的代码:

class Television(object):
    def __init__(self, channel=1, volume=1, is_on=False):
        self._channel= channel
        self.volume = volume
        self.is_on = is_on

    def __str__(self):
        volume = self.volume
        if not volume:
            volume = 'muted'
        elif volume == 10:
            volume = 'max'
        if self.is_on:
            return "The TV is on, channel {0}, volume {1}".format(self.channel, volume)
        else:
            return "The TV is off."

    def toggle_power(self):
        self.is_on = not self.is_on
        return self.is_on

    def get_channel(self):
        return self._channel

    def set_channel(self, choice):
        self._check_on()
        if 0 <= choice <= 499:
            self._channel = choice
        else:
            raise ValueError('Invalid channel')

    channel = property(get_channel, set_channel)

    def _check_on(self):
        if not self.is_on:
            raise ValueError("The television isn't on")

    def raise_volume(self, up=1):
        self._check_on()
        self.volume += up
        if self.volume >= 10:
            self.volume = 10

    def lower_volume(self, down=1):
        self._check_on()
        self.volume -= down
        if self.volume <= 0:
            self.volume = 0

def main():
    tv = Television()
    while True:
        print 'Status:', tv
        print \
        """
        Television

        0 - Exit
        1 - Toggle Power
        2 - Change Channel
        3 - Raise Volume
        4 - Lower Volume
        """
        choice=raw_input("Choice: ")

        try:
            if choice=="0":
                break
            elif choice=="1":
                tv.toggle_power()
            elif choice=="2":
                change=int(raw_input("What would you like to change the channel to? "))
                tv.set_channel(change)
            elif choice=="3":
                tv.raise_volume()
            elif choice=="4":
                tv.lower_volume()
            else:
                raise ValueError("Sorry, but {0} isn't a valid choice.".format(choice))
        except ValueError as e:
            print '\n\n *** ERROR: {0}\n'.format(e)

main()
raw_input("Press enter to exit.")