Question

我创建了一个列表迭代器但是当尝试向后遍历列表时，循环无限运行。我做错了什么？

    function List() {
    this.listSize=0;
    this.pos=0;
    this.dataStore =[];
    this.append = append;
    this.currPos = currPos;
    this.end = end; 
    this.front = front;
    this.length = length;
    this.moveTo = moveTo;
    this.next = next;
    this.prev = prev;
    }

    function append(element) {this.dataStore[this.listSize++]=element;}
    function currPos() {return this.pos;}
    function end() {this.pos = this.listSize-1;}
    function front() {this.pos =0;}
    function length() {return this.listSize;}
    function moveTo(position) {this.pos = position;}
    function prev() {if(this.pos > 0) --this.pos;}
    function next() {if(this.pos < this.listSize) ++this.pos;}


    var names = new List();
    names.append("A"); names.append("B"); names.append("C");
    for(names.end(); names.currPos() >= 0; names.prev()) {console.log(names.getElement());}

Answer 1

您的循环仅在当前列表位置小于零时终止，但您的.prev()函数将不允许这种情况发生。

修复它？嗯，这是一个意见问题，但如果您遇到实现列表类的麻烦，您也可以创建一个本地.forEach函数：

function forEach(callback) {
  for (var i = 0; i < this.listSize; ++i)
    callback(this.dataStore[i], i);
}

然后你可以这样做：

names.forEach(function(name) { console.log(name); });

Answer 2

在尝试从“数据结构和算法”一书中实现列表ADT时遇到了类似的问题，并且发现作者在以后的版本中重写了该部分看起来像这样：

module.exports = List;

function List() {
    this.listSize = 0;
    this.pos = 0;
    this.dataStore = [];
    this.clear = clear;
    this.find = find;
    this.toString = toString;
    this.insert = insert;
    this.append = append;
    this.remove = remove;
    this.front = front;
    this.end = end;
    this.prev = prev;
    this.next = next;
    this.length = length;
    this.currPos = currPos;
    this.moveTo = moveTo;
    this.getElement = getElement;
    this.length = length;
    this.contains = contains;
    this.hasNext = hasNext;
    this.hasPrevious = hasPrevious;
    this.insertIf = insertIf;
}

function append(element) {
    this.dataStore[this.listSize++] = element;
}

function find(element) {
    for (var i = 0; i < this.dataStore.length; ++i) {
        if (this.dataStore[i] === element) {
            return i;
        }
    }
    return -1;
}

function remove(element) {
    var foundAt = this.find(element);
    if (foundAt > -1) {
        this.dataStore.splice(foundAt, 1);
        --this.listSize;
        return true;
    }
    return false;
}

function length() {
    return this.listSize;
}

function toString() {
    return this.dataStore;
}

function insert(element, after){
    var insertPos = this.find(after);
    if(insertPos > -1){
        this.dataStore.splice(insertPos+1, 0, element);
        ++this.listSize;
        return true;
    }
    return false;
}

function clear() {
    delete this.dataStore;
    this.dataStore = [];
    this.listSize = this.pos = 0;
}

function contains(element) {
    for (var i = 0; i < this.dataStore.length; ++i) {
        if(this.dataStore[i] === element) {
            return true;
        }
    }
    return false;
}

function front() {
    this.pos = 0;
}

function end() {
    this.pos = this.listSize-1;
}

function prev() {
    return this.dataStore[--this.pos];
}

function next(){
    return this.dataStore[this.pos++];
}

function hasNext(){
    if (this.pos > this.listSize -1) {
        return false;
    } else {
        return true;
    }
}

function hasPrevious() {
    if(this.pos <= 0) {
        return false;
    } else {
        return true;
    }
}

function currPos() {
    return this.pos;
}

function moveTo(position) {
    this.pos = position;
}

function getElement() {
    return this.dataStore[this.pos];
}

function insertIf(element) {
    var greaterThan = true;
    for(this.front(); this.hasNext(); ){
        if(this.next() > element) {
            greaterThan = false;
            break;
        }
    }
    console.log(element);
    if(greaterThan){
        this.append(element);
        return true;
    } else {
        return false;
    }
}

你的循环将如下所示：

for (list.front(); list.hasNext();) {
    var listItem = list.next();
    if(listItem instanceof Customer) {
        console.log(listItem.name + ", " + listItem.movie);
    } else {
        console.log(listItem);
    }
}

这已被证明是一种更可靠的实现，因此您可能需要考虑切换到此。

Answer 3

您需要将for循环更改为：

for(names.end(); names.currPos() > 0; names.prev())

列表迭代器中的无限循环

3 个答案: