Question

我在C中创建了一个小程序，用于计算用户输入的数字能力，直到用户输入负数。它使用线程来做到这一点。

我在跑步时遇到分段错误，所以我做错了，但我不知道到底是什么。

这是我的代码：

/* 
 * File:   main.c
 * Author: thomasvanhelden
 *
 * Created on June 15, 2014, 3:17 AM
 */

#include <stdio.h>
#include <stdlib.h>
#include <pthread.h>

/**
 * Calculates faculty of given number
 *      Can run as a thread
 * @param param The given number
 * @return Doesn't return anything
 */
void *fac(void *param) {
    int* number = (int*) param;
    int faculty = 1;
    int i; // counter

    printf("De faculteit van %i is: ", number);

    for (i = 2; i <= number; i++) {
        faculty *= i;
    }

    printf("%i\n", faculty);
}

/*
 * 
 */
int main(int argc, char** argv) {
    pthread_t **threads; 
    int getal, numThreads = 0, counter, stop = 0;

    // ask for numbers until user enters negative number
    while (stop == 0) {
        scanf("%i", getal);

        if (getal >= 0) {
            numThreads++;
            threads = realloc(threads, sizeof(pthread_t*) * (numThreads+1));
            threads[numThreads - 1] = malloc(sizeof(pthread_t));

            // Create the thread
            if (pthread_create(&threads[numThreads - 1], NULL, fac, &getal)) {
                // something went wrong
                printf("Error creating thread %i!\n", numThreads);
                return 1;
            }

        } else {
            // User entered negative number and wants to stop
            stop = 1;
        }
    }

    // join all the threads
    for (counter = 0; counter < numThreads; counter++) {
        if (pthread_join(threads[counter], NULL)) {
            printf("Something went wrong joining thread %i\n", counter + 1);
        }
    }


    return (EXIT_SUCCESS);
}

Answer 1

我认为你的意思是“阶乘”？无论如何，您的代码存在多个问题。即使没有启用严格标志，我也会收到以下警告：

fac.c:23:40: warning: format specifies type 'int' but the argument has type 'int *' [-Wformat]
    printf("De faculteit van %i is: ", number);
                             ~~        ^~~~~~
fac.c:25:19: warning: ordered comparison between pointer and integer ('int' and 'int *')
    for (i = 2; i <= number; i++) {
                ~ ^  ~~~~~~
fac.c:30:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
fac.c:41:21: warning: format specifies type 'int *' but the argument has type 'int' [-Wformat]
        scanf("%i", getal);
               ~~   ^~~~~
fac.c:49:32: warning: incompatible pointer types passing 'pthread_t **' (aka 'struct _opaque_pthread_t ***') to
      parameter of type 'pthread_t *' (aka 'struct _opaque_pthread_t **'); remove &
      [-Wincompatible-pointer-types]
            if (pthread_create(&threads[numThreads - 1], NULL, fac, &getal)) {
                               ^~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/pthread.h:310:42: note: passing argument to parameter here
int pthread_create(pthread_t * __restrict, const pthread_attr_t * __restrict,
                                         ^
fac.c:63:26: warning: incompatible pointer types passing 'pthread_t *' (aka 'struct _opaque_pthread_t **') to
      parameter of type 'pthread_t' (aka 'struct _opaque_pthread_t *'); dereference with *
      [-Wincompatible-pointer-types]
        if (pthread_join(threads[counter], NULL)) {
                         ^~~~~~~~~~~~~~~~
                         *
/usr/include/pthread.h:333:28: note: passing argument to parameter here
int pthread_join(pthread_t , void **) __DARWIN_ALIAS_C(pthread_join);
                           ^
6 warnings generated.

实际上，如果您在gdb下运行该程序，则在输入数字后会崩溃：

...
4

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000000
0x00007fff92c1401a in __svfscanf_l ()
(gdb) bt
#0  0x00007fff92c1401a in __svfscanf_l ()
#1  0x00007fff92c0c0eb in scanf ()
#2  0x0000000100000d72 in main (argc=1, argv=0x7fff5fbffa18) at fac.c:41

使用bt查看堆栈跟踪，我们立即看到它在第41行崩溃，您调用scanf()。如果你回顾编译器警告，它会告诉你它需要一个int*，但你只传递int。这是因为scanf需要一个指针才能用用户输入修改变量。

如果您修复了所有剩余的警告，则代码可以正常运行。

当您需要number函数时，需要取消引用fac
您需要将threads初始化为NULL，以便realloc可以正常工作（否则未定义，可能非零，因此缓冲区永远不会（重新）分配
pthread_create和pthread_join调用需要更新，因此值/指针与预期的签名匹配

完成上述更改后，我可以按预期运行：

$ ./fac_fixed
3
De faculteit van 3 is: 6
4
De faculteit van 4 is: 24
5
De faculteit van 5 is: 120
6
De faculteit van 6 is: 720
7
De faculteit van 7 is: 5040
8
De faculteit van 8 is: 40320
9
De faculteit van 9 is: 362880
12
De faculteit van 12 is: 479001600
-1

关于代码的结构，我不明白你为什么要创建一个线程数组，因为你只是按顺序计算一个。您最多只需要一个工作线程，但由于main除了阻塞连接之外什么都不做，所以它实际上并不需要在一个线程中。但至少它不会崩溃！

Answer 2

第一次调用realloc()时，应将threads设置为NULL。实际上，您传递的是一个未经初始化的指针，它是未定义的行为。

1）将其初始化为0：

pthread_t **threads = 0;

2）你也在打印指针，而不是他们在这里指出的内容：

printf("De faculteit van %i is: ", *number);

3）scanf（）需要&，因为int *需要%d。

scanf("%i", &getal);

在C中动态分配线程

2 个答案: