在BattleShip游戏C ++中返回指向船只的指针

时间:2014-05-26 23:35:35

标签: c++ pointers boolean member

我正在尝试自学C ++所以我正在做一个战舰计划。我有一个船舶和船级。

此版本相当标准。玩家输入一个单元格的坐标以试图击中一艘船。程序说明船是否被击中。如果船舶占用的所有单元都被击中,程序将打印一条消息,指出该船已沉没。每次尝试后,程序都会通过向董事会显示分别由"*""x"标记的所有成功尝试来打印当前状态。

我无法在我的Board类中实现Ship *shipAt(int x, int y)函数以保持对该船的帐户,实际上此函数返回指向该船的指针。否则返回空指针。

我有战舰的董事会

   a b c d e f g h i j
  +-------------------+
 0|                   |
 1|                   |
 2|                   |
 3|                   |
 4|                   |
 5|                   |
 6|                   |
 7|                   |
 8|                   |
 9|                   |
  +-------------------+

这是我的船级中的bool Ship::includes(int x, int y)函数,我试图实现它以完成我的shipAt函数。我为了简洁而将其剪下来:

#include "Ship.h"
#include <iostream>
#include <stdexcept>

using namespace std;

//Would have been more member functions but I cut it down for brevity 

bool Ship::includes(int x, int y)
{
    bool include= false;

    if(x == x1)
    {
        if ((y>= y1) && (y<=y2))
        {
            include = true;
        }
        if ((y>= y2) && (y<=y1))
        {
            include = true;
        }
    }
    else if (y == y1)
    {
        if ((x>= x1) && (x<=x2))
            {
                include = true;
            }
        if ((x>= x2) && (x<=x1))
        {
            include = true;
        }
    }


    return include; 
}





    }

这是我的董事会成员。我在使用Ship *shipAt(int x, int y)功能时遇到问题 对于此函数,如果船舶占据单元格(x,y),则此函数返回指向该船舶的指针。否则返回空指针。

#include "Board.h"
#include "Ship.h"
#include <iostream>
using namespace std;
#include <vector>
#include <string.h>
#include <stdexcept>


//member function definitions

Board::Board(void)
{
     char score[10][10] = {};
}

void Board::addShip(char type, int x1, int y1, int x2, int y2) 
{
    if(shipList.size()<10)
        {
            shipList.push_back(Ship::makeShip(type,x1,y1,x2,y2));
        }
}

void Board::print(void){

 cout<< "   a b c d e f g h i j"<< endl;
    cout <<"  +-------------------+"<< endl;

    for (int i = 0; i < 10; i++) {
        // print the first character as part of the opener.
        cout << " " << i << "|" << score[i][0];
        for (int j = 1; j < 10; j++) {
           // only add spaces for subsequent characters.
           cout << " " << score[i][j];
        }
        cout << "          |" << endl;
    }
    cout <<"  +-------------------+"<< endl;

}

void Board::hit(char c, int i){

    if (c<'a' || c>'j' || i > 9 || i<0){
        throw invalid_argument("invalid input");
    }

    Ship* ship = shipAt(i, c-'a');


    if (ship) {
        score[i][c-'a']= '*';
    }
    else{
        score[i][c-'a']= 'x';
    }
}

Ship* Board::shipAt(int x, int y){
    Ship* ship = Ship::includes(x,y);

    if (ship){
            return ship;   
        }
    else{
        return NULL;
         }
}

int Board::level(void)
{
    int lev = 0;
    std::vector<Ship *>::iterator iter = shipList.begin();
    std::vector<Ship *>::iterator end = shipList.end();
    for ( ; iter != end; ++iter )
    {
       lev += (*iter)->level();
    }

    return lev;

}

基本上我试图使用Ship类中的bool Ship::includes(int x, int y)函数。我试图这样做,如果函数返回true,那么atShip函数也会返回true,因为includes函数是一个布尔值。

但是,该实现不起作用,我接收到非静态成员函数的调用,没有对象参数错误。

编辑:有关其他情况(可能不必要,所以除非您需要,否则不要点击),

这是我的Ship.cpp:http://pastebin.com/cYDt0f8W

这是我的Ship标头文件:http://pastebin.com/W6vwKJRz

这是我的Board头文件:http://pastebin.com/r36YjHjt

1 个答案:

答案 0 :(得分:1)

Ship* ship = Ship::includes(x,y);

  1. Ship::includes()返回bool而不是Ship*

  2. Ship::includes()不是static

  3. 你需要查看你的船只清单,并且对于每一个船只,它都是“at”(x,y)。一旦找到了这艘船,你就可以退货了。

    像(伪代码):

    foreach ship in shipList
        if (ship->includes(x, y))
            return ship
    return NULL;