前缀计算器 - 在某些情况下不会起作用 - C ++

时间:2014-05-01 19:04:54

标签: c++ calculator prefix

我正在创建一个Prefix计算器,用户输入前缀表达式,程序会对其进行评估。它适用于某些情况,例如" + 43"输出7应该是,但" / - 421"输出" 2",何时输出" 1"和" / + 421"输出" 6"而不是" 3",这样的事情。有任何修复建议吗?我稍后会添加例外,因此暂时将其注释掉。

PrefixCalculator.cpp

#pragma once

#include <sstream>

using namespace std;

template<class T>
class PrefixCalculator {
public:
PrefixCalculator(void){
    numOperator = 0;
    numOperand = 0;
};
~PrefixCalculator(void){};

T eval(istringstream&);

int getNumOperator() {
    return numOperator;
};

int getNumOperand() {
    return numOperand;
};

private:
//if you feel you need private helper functions and/or helper data
int numOperator;
int numOperand;
};

template<class T>
T PrefixCalculator<T>::eval(istringstream& input) { 
 //this function needs to throw an exception if there's a problem with the expression or operators
char nextChar = input.peek();

//this while loop skips over the spaces in the expression, if there are any
while(nextChar == ' ') {
    input.get();    //move past this space
    nextChar = input.peek(); //check the next character
}

if(nextChar == '+') {
    input.get();    //moves past the +
    numOperator++;
    return eval(input) + eval(input);   //recursively calculates the first expression, and adds it to the second expression, returning the result
}

/***** more operators here ******/
if(nextChar == '-') {
    input.get();
    numOperator++;
    return eval(input) - eval(input);
}

if(nextChar == '*') {
    input.get();
    numOperator++;
    return eval(input) * eval(input);
}

if(nextChar == '/') {
    input.get();
    numOperator++;
    return eval(input) / eval(input);
} 

/******  BASE CASE HERE *******/
//it's not an operator, and it's not a space, so you must be reading an actual value (like '3' in "+ 3 6".  Use the >> operator of istringstream to pull in a T value!
input>>nextChar;
T digit = nextChar - '0';
numOperand++;
return digit;
//OR...there's bad input, in which case the reading would fail and you should throw an exception

}

driver.cpp

#include <sstream>
#include <string>
#include <iostream>
#include "PrefixCalculator.h"

using namespace std;

int main(int argc, char** argv) {
PrefixCalculator<int> calc;

string expression;
cout << "Give a prefix expression to evaluate, or q to quit." << endl;
getline(cin,expression);

while(expression[0] != 'q') {
    //try {
        int result = calc.eval(istringstream(expression));
        cout << result << endl;
    //}
    //catch { //will not compile, you have to finish this!
    //  
    //}

    cout << "Give a prefix expression to evaluate or q to quit." << endl;
    getline(cin,expression);
}

return 0;
 }

1 个答案:

答案 0 :(得分:2)

我很困惑。根据您提供的输出,您的程序运行正常,但您的期望不正确。

让我们评估表达式&#34; / - 421&#34;:
1.检测到操作员,&#39; /&#39;,推入堆栈:

+----+
| /  |
+====+

检测到操作员,&#39; - &#39;,推入堆栈:

+---+  
| - |  
+---+  
| / |  
+===+  

检测到数字,因为上一个操作员需要2个参数,所以推入堆栈。

+---+
| 4 |
+---+
| - |
+---+
| / |
+===+

检测到数字,两个操作员中的第二个。
将剩余的操作数弹出堆栈,4 使用参数评估从堆栈中弹出操作:

result = 4 - 2 --> 1

将结果推送到堆栈。

+---+
| 2 |
+---+
| / |
+===+

检测到数字,除法运算符的第2个参数为2 弹出堆栈中的数字,这将成为除法运算的第一个参数 从堆栈弹出操作并使用参数进行评估:

result = 2 / 1 --> 2

将结果推到堆栈上。

+---+
| 2 |
+===+

达到结束表达式,弹出结果并打印:

2

修改1:

您可以在分析下一个令牌之前打印堆栈(每行一个项目)来确认您的程序操作。