我已经开始上课了,但是它很快就用尽了堆空间?

时间:2014-04-22 03:32:07

标签: java linked-list heap nodes

这是我在大学的第二个学期,我们已经了解了LinkedLists(Nodes)。我有一个想法,在java中做一些有趣的事情,这是一个Room类,有4个指针指向其他Room对象:north,south,west,east,每个Room对象也包含一个char对象,所以我可以跟踪它

我的主要功能是要求扫描仪输入w / a / s / d,然后创建/指向相应的房间,并用字符填充每个房间。

但是,出于某种原因,它很快就会耗尽堆空间(比如当字符到达'?')时。

这是我的代码:

import java.util.*;

public class Room {
    // instance variables
    private Room north, west, east, south;
    private char object;
    private static char counter = ' ';

    // constructors
    public Room() {
    }

    public Room(char object) {
        this.object = object;
    }

    // methods
    public Room newRoomNorth() {
        north = new Room();
        north.south = this;
        return north;
    }

    public Room newRoomWest() {
        west = new Room();
        west.east = this;
        return west;
    }

    public Room newRoomEast() {
        east = new Room();
        east.west = this;
        return east;
    }

    public Room newRoomSouth() {
        south = new Room();
        south.north = this;
        return south;
    }

    public Room linkRoomNorth(Room linkedRoom) { // link a given room to given direction of this room, returns what room was overwritten (if any)
        Room overwritten = north;
        north = linkedRoom;
        north.south = this;
        return overwritten;
    }

    public Room linkRoomWest(Room linkedRoom) {
        Room overwritten = west;
        west = linkedRoom;
        west.east = this;
        return overwritten;
    }

    public Room linkRoomEast(Room linkedRoom) {
        Room overwritten = east;
        east = linkedRoom;
        east.west = this;
        return overwritten;
    }

    public Room linkRoomSouth(Room linkedRoom) {
        Room overwritten = south;
        south = linkedRoom;
        south.north = this;
        return overwritten;
    }

    public Room getRoomNorth() {
        return this.north;
    }

    public Room getRoomWest() {
        return this.west;
    }

    public Room getRoomEast() {
        return this.east;
    }

    public Room getRoomSouth() {
        return this.south;
    }

    public char getObject() {
        return this.object;
    }

    public void setObject(char object) {
        this.object = object;
    }

    public void fill() { // puts a character as object
        this.setObject(counter);
        counter = (char) (counter + 1);
    }

    // main
    public static void main(String[] args) {
        Scanner scan = new Scanner(System.in);
        String input = "";
        Room currentRoom = new Room('™');
        while (!input.equalsIgnoreCase("exit")) {
            System.out.println("This room's treasure is: " + currentRoom.getObject());
            System.out.println("Which way? (w/a/s/d)");
            input = scan.next();
            switch (input.charAt(0)) {
                case 'w':
                    if (currentRoom.getRoomNorth() == null) {
                        currentRoom = currentRoom.newRoomNorth();
                        currentRoom.fill();
                    } else {
                        currentRoom = currentRoom.getRoomNorth();
                    }
                    break;
                case 'a':
                    if (currentRoom.getRoomWest() == null) {
                        currentRoom = currentRoom.newRoomWest();
                        currentRoom.fill();
                    } else {
                        currentRoom = currentRoom.getRoomWest();
                    }
                    break;
                case 'd':
                    if (currentRoom.getRoomEast() == null) {
                        currentRoom = currentRoom.newRoomEast();
                        currentRoom.fill();
                    } else {
                        currentRoom = currentRoom.getRoomEast();
                    }
                    break;
                case 's':
                    if (currentRoom.getRoomSouth() == null) {
                        currentRoom = currentRoom.newRoomSouth();
                        currentRoom.fill();
                    } else {
                        currentRoom = currentRoom.getRoomSouth();
                    }
                    break;
            }
        }
    }
} 

1 个答案:

答案 0 :(得分:0)

我没有遇到任何堆空间问题,但在到达'?'之后,所有新房间仍然有'?',很可能因为(char) ('?' + 1)将继续返回'?' 。也许这是您的Java版本的错误。您的操作系统和JDK版本是什么?