选择行和删除不会删除行

Question

我编写了一些简单的代码，将一个工作表中的单元格与另一个工作表中的单元格匹配，然后在单元格相等的情况下删除整行。

代码正确选择行，但由于某种原因拒绝实际删除工作表中的行。编辑：删除一些行。其他人不会，即使他们具有与删除完全相同的值。如果有人能提供帮助，那将非常感激。

Sub delFunds()
Dim fCell As Range 'Fund cell
Dim fRng As Range 'Fund range
Dim wCell As Range 'Working sheet cell
Dim wRng As Range 'Working sheet range
Dim n As Long

Set fRng = Worksheets("Funds").Range("C2:C117")
Set wRng = Worksheets("Working sheet").Range("I3:I7483")

For Each fCell In fRng.Cells 'Loop through all funds
    For Each wCell In wRng.Cells 'Loop through all working cells
        If StrComp(wCell.Value, fCell.Value, vbTextCompare) = 0 Then 'If equal then delete
            n = wCell.Row
            Rows(n & ":" & n).Select
            Selection.Delete Shift:=xlUp
        End If
    Next wCell
Next fCell 'Go to next fund

End Sub

Answer 1

我会在没有嵌套循环的情况下使用此代码：

Sub delFunds()
    Dim rngToDel As Range 
    Dim fRng As Range 'Fund range
    Dim wCell As Range 'Working sheet cell
    Dim wRng As Range 'Working sheet range

    Set fRng = Worksheets("Funds").Range("C2:C117")
    Set wRng = Worksheets("Working sheet").Range("I3:I7483")

    For Each wCell In wRng 'Loop through all working cells
        ' if wCell found in Fund range then delete row
        If Not IsError(Application.Match(Trim(wCell.Value), fRng, 0)) Then
            If rngToDel Is Nothing Then
                Set rngToDel = wCell
            Else
                Set rngToDel = Union(rngToDel, wCell)
            End If
        End If
    Next wCell

    If Not rngToDel Is Nothing Then rngToDel.EntireRow.Delete
End Sub

Answer 2

我知道@ simoco的答案已经有效并且已经被接受了，但是我喜欢一个很好的问题所以我想用autofilter来解决一个解决方案，立刻杀掉大片的工作表。我认为你的设计看起来像这样：

从那里，您可以遍历简明的基金清单并过滤每个基金的工作表：

Option Explicit
Sub EliminateWorkingDuplicates()

Dim WorkingSheet As Worksheet, FundSheet As Worksheet
Dim FundRange As Range, WorkingRange As Range, _
    Fund As Range
Dim LastRow As Long, LastCol As Long, _
    WorkingFundCol As Long

'assign sheets and ranges for easy reference
Set WorkingSheet = ThisWorkbook.Worksheets("Working sheet")
Set FundSheet = ThisWorkbook.Worksheets("Funds")
Set FundRange = FundSheet.Range("C2:C117")
WorkingFundCol = 9 'column I on working sheet

'determine the bounds of the data block on the working sheet
LastRow = WorkingSheet.Cells.Find("*", SearchOrder:=xlByRows, SearchDirection:=xlPrevious).Row
LastCol = WorkingSheet.Cells.Find("*", SearchOrder:=xlByColumns, SearchDirection:=xlPrevious).Column
Set WorkingRange = Range(WorkingSheet.Cells(2, 1), WorkingSheet.Cells(LastRow, LastCol))

'start working through the funds and calling the autofilter function
For Each Fund In FundRange
    Call FilterAndDeleteData(WorkingRange, WorkingFundCol, Fund.Value)
    Call ClearAllFilters(WorkingSheet)
Next Fund

End Sub

'**********
'blow away rows
Sub FilterAndDeleteData(DataBlock As Range, TargetColumn As Long, Criteria As String)

'make sure some joker didn't pass in an empty range
If DataBlock Is Nothing Then Exit Sub

'execute the autofilter with the supplied column and criteria
With DataBlock
    .AutoFilter Field:=TargetColumn, Criteria1:=Criteria
    .Offset(1, 0).SpecialCells(xlCellTypeVisible).EntireRow.Delete
End With

End Sub

'**********
'safely clear filters
Sub ClearAllFilters(TargetSheet As Worksheet)

With TargetSheet
    .AutoFilterMode = False
    If .FilterMode = True Then
        .ShowAllData
    End If
End With

End Sub