在构造函数中使用自定义比较器

时间:2014-03-31 17:03:02

标签: java sorting comparator

我在构造函数中使用比较器时遇到了困难。当我尝试以下代码时:

InsertionSorter is = new InsertionSorter(bookList.toArray(new Comparable[bookList.size()]), new GenreComparator(), SortType.ASC);

我收到此错误:

no suitable constructor found for InsertionSorter(java.lang.Comparable[],sort.GenreComparator,sort.SortType)
constructor sort.InsertionSorter.InsertionSorter(java.lang.Comparable[],java.util.Comparator<java.lang.Object>,sort.SortType) is not applicable
  (actual argument sort.GenreComparator cannot be converted to java.util.Comparator<java.lang.Object> by method invocation conversion)
constructor sort.InsertionSorter.InsertionSorter(java.lang.Comparable[],sort.SortType) is not applicable
  (actual and formal argument lists differ in length)

以下是有用的代码段:

AbstractSorter.java:

abstract class AbstractSorter {
    protected Comparable[] values;
    protected Comparator<Object> cmp;
    protected SortType st;

    protected abstract void doSort();
    protected AbstractSorter(Comparable[] init, SortType type) {
        values = new Comparable[init.length];
        System.arraycopy(init, 0, values, 0, init.length);
        cmp = null;
        st = type;
    }
    protected AbstractSorter(Comparable[] init, Comparator<Object> comp, SortType type) {
        values = new Comparable[init.length];
        System.arraycopy(init, 0, values, 0, init.length);
        cmp = comp;
        st = type;
    }

    public Comparable[] getValues() {
        return values;
    }
}

class InsertionSorter extends AbstractSorter {

    public InsertionSorter(Comparable[] init, SortType type) {
        super(init, type);
    }

    public InsertionSorter(Comparable[] init, Comparator<Object> comp, SortType type) {
        super(init, comp, type);
    }

    @Override
    public void doSort() {
        // sorts values
    }
}

enum SortType {ASC, DSC};

Book.java:

public class Book implements Cloneable, Comparable<Book> {
    private Person author; // implementation details of Person don't matter here
    private String title, isbn;
    private int year;
    private BookGenre genre;

    public Book(Person authorInit, String titleInit, String isbnInit, 
            int yearInit, BookGenre genreInit) {
        author = authorInit;
        title = titleInit;
        isbn = isbnInit;
        year = yearInit;
        genre = genreInit;
    }

    @Override
    public String toString() {
        return author.toString() + " " + title + " " + isbn + " " + year 
                + " " + genre;
    }

    @Override
    public Object clone() throws CloneNotSupportedException {
        return super.clone();
    }

    @Override
    public int compareTo(Book other) {
        return author.compareTo(other.author);
    }

    public Person getAuthor() {
        return author;
    }

    public String getTitle() {
        return title;
    }

    public String getIsbn() {
        return isbn;
    }

    public int getYear() {
        return year;
    }

    public BookGenre getGenre() {
        return genre;
    }
}

class TitleComparator implements Comparator<Book> {
    @Override
    public int compare(Book a, Book b) {
        return a.getTitle().compareToIgnoreCase(b.getTitle());
    }
}

class GenreComparator implements Comparator<Book> {
    @Override
    public int compare(Book a, Book b) {
        return a.getGenre().compareTo(b.getGenre());
    }
}

enum BookGenre { COMIC, MYSTERY, SCIENCE, TRAVEL };

编辑感谢Rohit解决此问题,但现在我遇到了相关问题。在方法doSort()中,我有代码段

cmp.compare(values[j-1], values[j])

(别担心,我已经做好检查,以确保在cmp == null时不会调用此内容。这会产生以下错误:

method compare in interface java.util.Comparator<T> cannot be applied to given types;
  required: capture#1 of ? extends java.lang.Object,capture#1 of ? extends java.lang.Object
  found: java.lang.Comparable,java.lang.Comparable
  reason: actual argument java.lang.Comparable cannot be converted to capture#1 of ? extends java.lang.Object by method invocation conversion

请注意,我已将AbstractSort.java中的上述内容更改为将Comparable<Object>替换为Comparable<? extends Object>

1 个答案:

答案 0 :(得分:4)

GenreComparator类实现Comparator<Book>。因此,您无法传递需要Comparator<Object>的该类的实例。两者都不兼容。

然而,您可以在构造函数中将Comparator<Object>更改为Comparator<? extends Object>,并在cmp类中将字段AbstractSorter更改为<。<}