C:Valgring警告“无效的写入/读取大小8”&关闭系统调用

时间:2014-03-09 21:28:25

标签: c memory-leaks valgrind

我正在用valgrind测试我的二进制文件,并且我得到了许多类似这样的警告:

Invalid write of size 8
==7414==    at 0x402AAE: list_create_node (simple_list.c:53)
==7414==    by 0x40267E: list_add_elem_at_back (simple_list2.c:21)
==7414==    by 0x401C8A: parse (is_valid2.c:31)
==7414==    by 0x40246C: ko_parse (main.c:53)
==7414==    by 0x40255B: ko (main.c:74)
==7414==    by 0x4025E1: main (main.c:96)
==7414==  Address 0x6fe52d8 is 0 bytes after a block of size 8 alloc'd
==7414==    at 0x4C277AB: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==7414==    by 0x402A75: list_create_node (simple_list.c:50)
==7414==    by 0x40267E: list_add_elem_at_back (simple_list2.c:21)
==7414==    by 0x401C8A: parse (is_valid2.c:31)
==7414==    by 0x40246C: ko_parse (main.c:53)
==7414==    by 0x40255B: ko (main.c:74)
==7414==    by 0x4025E1: main (main.c:96)

我看到有很多关于此的帖子,但我无法找到代码中的问题:

t_node          *list_create_node(char *element)
{
  t_node        *node;

  if ((node = malloc(sizeof(t_node *))) == NULL)
    return (NULL);
  if ((node->value = strdup(element)))
    node->next = NULL; //// line 53 from simple_list.c
  return (node);
}

我做错了吗?

Valgrind也警告说阅读......那就是:

==7415== Warning: invalid file descriptor 1024 in syscall close()

我的代码中有一个close(),但即使我发表评论,该消息仍会显示。那是为什么?

1 个答案:

答案 0 :(得分:3)

您希望malloc指针指向的大小,而不是指针本身的大小。即:改变

(node = malloc(sizeof(t_node *)))

(node = malloc(sizeof(t_node)))

或更好:

(node = malloc(sizeof *node))

如果您决定更改malloc的类型,则无需更改node - 来电。