被释放的指针没有被分配,但看起来像是

时间:2014-03-03 02:53:52

标签: c++ destructor dynamic-memory-allocation

我在这段代码中遇到了类的析构函数问题。这是说从来没有分配,但应该是,我自己永远不会删除它。以下是代码片段:

#ifdef UNIT_TESTING_CONSTRUCTORS
//Test Constructors
cout << "Test constructors \nConctructor 1:\n";
Doctor testDoc1;
testDoc1.displayPatientArray();
cout << "\nConstructor 2:\n";
Doctor testDoc2(2);
testDoc2.displayPatientArray();
cout << "\nConstructor 3:\n";
//Implement more test cases below:
Doctor testDoc3("Wesley Cates");
testDoc3.displayPatientArray();
cout << "\nConstructor 4:\n";
Doctor testDoc4("Baylor Bishop", 3);
testDoc4.displayPatientArray();
#endif


Doctor::Doctor() : doctorName("need a name."), patientArraySize(100), numOfPatient(0) {
//Create a dynamic array for patients below:
//stringPtr_t* pArray;
stringPtr_t* patientArray;
patientArray = new stringPtr_t[patientArraySize];

上课:

typedef unsigned short ushort_t;
typedef string* stringPtr_t;
class Doctor {
private:
string doctorName;
stringPtr_t patientArray;
ushort_t patientArraySize;
ushort_t numOfPatient;
public:
Doctor();
Doctor(ushort_t patientArrayCapacity);
Doctor(string docName);
Doctor(string docName, ushort_t patientArrayCapacity);
bool addPatient(string patientName);

void displayPatientArray();
void resizePatientArray(ushort_t newArraySize);

string getDoctorName() const {return doctorName;}
ushort_t getNumOfPatient() const {return numOfPatient;}
ushort_t getArraySize() const {return patientArraySize;}

void setDoctorName(string docName) {doctorName.assign(docName);};
void emptyPatientArray() {numOfPatient = 0;}

Doctor& operator =(const Doctor& docSource);
~Doctor() {delete [] patientArray;}
};

2 个答案:

答案 0 :(得分:2)

您在构造函数Doctor::Doctor()中初始化的数组是一个名为“patientArray”的 local 变量,而不是您在析构函数中删除的类变量。

要解决此问题,请将构造函数更改为:

Doctor::Doctor() : doctorName("need a name."), patientArraySize(100), numOfPatient(0) { // Create a dynamic array for patients below: // stringPtr_t* pArray; // Delete local variable declaration that was here: stringPtr_t* patientArray; // patientArray = new string[patientArraySize];

答案 1 :(得分:0)

您正在使用typedef string* stringPtr_t;。所以stringPtr_t变量已经是指针。

因此无需使用stringPtr_t* patientArray;您只需使用stringPtr_t patientArray;

即可

如果您使用stringPtr_t* patientArray; patientArray 字符串 **,您只需要 string *