数组元素的算术方程不起作用

时间:2014-01-23 17:14:56

标签: java math for-loop methods random

这是一个旨在使用Buffons针模拟来估计pi值的程序。 我在这里遇到的问题是在方法calcPi中,pi数组的元素在for循环内的算术方程之后继续显示为0。我已经检查过了hitCounter和试用版都在运行..帮助?

import java.util.Scanner;
public class Darts
{
    public static int trials() //User Inputs number of trials
    {
        int input;
        Scanner in = new Scanner(System.in);

        System.out.print("How many darts/trials? ");
        input = in.nextInt();

        return input;
    }

    public static double [] randomX(int trial) // Randomly generates numbers for the x coordinate on the amounts of trials

    {
        double [] randNumArrayX = new double[trial];
        for(int i = 0; i < trial; i++)
        {
            randNumArrayX[i] = Math.random();
        }
        return randNumArrayX;
    }

    public static double [] randomY(int trial) // Randomly generates numbers forthe y coordinate on the amounts of trials
    {
        double [] randNumArrayY = new double[trial];
        for(int i = 0; i < trial; i++)
        {
            randNumArrayY[i] = Math.random();
        }
        return randNumArrayY;
    }

    public static int [] dartBoard(double [] randx, double [] randy) // determines whether the dark hit the board or not
    {
        int [] hitMiss = new int[randx.length];
        int [] trials = new int[randx.length];

        for(int i = 0; i < randx.length; i++)
        {
            if( Math.pow(randx[i] , 2) + Math.pow(randy[i] , 2) <= 1)
            {
                hitMiss[i] = 1;
            }
            else
            {
                hitMiss[i] = 0;
            }
        }
        return hitMiss;
    }

    public static double [] calcPi(int [] h) // Calculates pi using randomly generated numbers
    {
        int hitCounter = 0;
        double [] pi = new double[h.length];

        for(int i = 0; i < h.length; i++)
        {
            if(h[i] == 1)
            {
                hitCounter++;
            }
            pi[i] = 4*(hitCounter/(i + 1));
        }
        return pi;
    }

    public static void print(double [] pi) // prints results
    {
        for(int i = 0; i < 10; i++)
        {
            System.out.printf("%-7s%2d%-8s%-10.6f%n", "Trial [", i, "]: pi = ", pi[i]);
        }
        System.out.println("\t   .....");
        System.out.printf("%-17s%-10.6f%n", "Estimate of pi = ", pi[pi.length -1]);
    }

    public static void main(String [] args) // main method
    {
        int t = trials();
        double [] x = new double[t];
        double [] y = new double[t];
        int [] h = new int[t];
        double [] p = new double[t];
        x = randomX(t);
        y = randomY(t);
        h = dartBoard( x , y );
        p = calcPi( h );
        print(p);
    }
}

2 个答案:

答案 0 :(得分:3)

你的问题可能就在这一行:

pi[i] = 4*(hitCounter/(i + 1));

您正在进行整数除法,因为hitcounter始终低于i,所以它总是会返回0。

试试这个

pi[i] = 4*(hitCounter/(i + 1d));

注意1d这会强制进行双重分割。

答案 1 :(得分:0)

这可能是由于整数除法。

尝试

pi[i] = 4 * (hitCounter/(i + 1.0));

Java中的1.0字面值是double类型。基本上,从那里开始 对于此表达式中的所有其他值,也将被提升为double。